Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] geotrans/3.8 #1779

Closed
SpaceIm opened this issue May 29, 2020 · 0 comments · Fixed by #6512
Closed

[request] geotrans/3.8 #1779

SpaceIm opened this issue May 29, 2020 · 0 comments · Fixed by #6512

Comments

@SpaceIm
Copy link
Contributor

SpaceIm commented May 29, 2020

Package Details

Description Of The Library / Tool

C++ library for converting between different geographic coordinate systems.

samuel-emrys added a commit to samuel-emrys/conan-center-index that referenced this issue Jul 25, 2021
* Add CMakeLists.txt to build geotrans library
* Add CCI package configuration
* Add functional test package using geotrans library provided sample
  code
@samuel-emrys samuel-emrys mentioned this issue Jul 26, 2021
4 tasks
conan-center-bot pushed a commit that referenced this issue Oct 15, 2021
* Add geotrans package to close #1779

* Add CMakeLists.txt to build geotrans library
* Add CCI package configuration
* Add functional test package using geotrans library provided sample
  code

* Modify CMake recipe to build both libraries instead of just one

* Build both libMSPdtcc and libMSPCoordinateConversionService to remain
  consistent with the upstream package. This is a change from the
  previous state in which both of these libraries were bundled into one.
* Remove extraneous comments from test_package conanfile
* Remove extraneous print statements from test_package example.cpp

* Add component definitions to package_info

* Add component definitions to package_info. This will allow cmake
  utilities like find_package to search for and find the package and its
  component libraries, which will enable linking against these
  individually for more granular control.

* Rectify errors identified by cci hooks

* No longer a shared library by default
* Update homepage metadata
* Update URL metadata

* Apply suggestions from code review

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

* Improve geotrans package as per code review

* Fix CMake installation process
* Refactor CMakeLists to be operated from the root source directory
  rather than source_subfolder. This removes the requirements to use the
  shutil package from within conanfile.py
* Transition to usage of find_package for Threads library. This will
  allow thread library discovery to be performed in an OS agnostic way.
* Test consumer package sets the required MPCCS_DATA environment
  variable to the data folder within the conan package folder rather
  than copying it to the consumers working directory. This is for CCI
  CI runner testing efficiency purposes, elimintating the need for a
  copy.

* Add output to inform the user about geotrans MPCCS_DATA envvar

This will ideally make it easier for the user to understand the
requirements of them to correctly configure the MPCCS_DATA environment
variable prior to attempting to use the geotrans library.

* Rectify fPIC management as per KB-H007 to address CI issues

* Delete fPIC option when shared library is being built
* Remove superfluous shutil import

* Update recipes/geotrans/all/conanfile.py

Co-authored-by: Rui Oliveira <ruimail24@gmail.com>

* Remove fPIC management from config_options function

* Remove superfluous fPIC management from config_options function
* Remove superfluous C library requirements to remove cpp flags

* Link dtcc library to ccs and remove cmake_find_package values

* Link MSPdtcc to MSPCoordinateConversionService to satisfy linkage
  requirements on macOS. This rectifies CI failures.
* Remove cmake_find_package(_multi) assignments from conanfile.py at the
  advice of @madebr

* Remove -Wno-deprecated compilation flag for windows compatability

* Add MSVC compatability to geotrans

* Add LITTLE_ENDIAN pre-processor definition to enable the reading of
  the provided binary data files on Windows systems.

* Fix windows build by exporting symbols to ensure lib is created

* Add CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS definition when building shared
  libraries on windows to ensure that all symbols are exported and .lib
  object is created.

* Apply suggestions from code review

* Move responsibility for setting MSPCCS_DATA environment variable from consumer to package
* Remove usage output from build method
* Remove explicit assignment of resdir value

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

* Apply changes from code review

* Remove version number of library from CMakeLists.txt
* Remove version number of library from conanfile.py
* Move definition of CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS from conanfile to
  CMakeLists.txt
* Add commentary on requisite environment variables to be set to
  consumer conanfile.py
* Re-add call to tools.environment_append to ensure that MPCCS_DATA
  environment variable is set when executing the example binary

* [geotrans] Update source URL to use JFrog Artifactory

* Update geotrans 3.8 source URL to use JFrog Artifactory. This resolves a build reproducibility issue caused by the fact that NGA don't host a versioned mirror of the source files. The JFrog mirror provided is now versioned and will be able to be downloaded even after the release of geotrans 3.9

Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
Co-authored-by: Rui Oliveira <ruimail24@gmail.com>
Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant