Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[geotrans] update to version 3.8 (on-hold waiting for CI/VM port 21 for ftp to be opened or alternate host site) #14412

Merged
merged 3 commits into from
Jan 5, 2021
Merged

[geotrans] update to version 3.8 (on-hold waiting for CI/VM port 21 for ftp to be opened or alternate host site) #14412

merged 3 commits into from
Jan 5, 2021

Conversation

StarGate-One
Copy link
Contributor

@StarGate-One StarGate-One commented Nov 5, 2020 •
edited
Loading

  1. Added new files to CMakeLists.txt required by version 3.8
  2. Remove old style CONTROL file used by vcpkg
  3. Updated portfile.cmake for version 3.8
    • download location now a ftp server
    • requires CI/VM to be updated to open ftp port 21 or alternate host site
  4. Add new style vcpkg.json file used by vcpkg

Describe the pull request

@StarGate-One
Update port geotrans to version 3.8
5730b9d 
1. Added new files to CMakeLists.txt required by version 3.8
2. Remove old style CONTROL file used by vcpkg
3. Updated portfile.cmake for version 3.8
4. Add new style vcpkg.json file used by vcpkg
@StarGate-One
Copy link
Contributor Author

StarGate-One commented Nov 5, 2020 •
edited
Loading

@BillyONeal
Please could you stop the CI/VM runs for this PR as they all will fail until the CI/VM ftp port 21 is opened or find an alternate host site.
Thank you...

@BillyONeal BillyONeal added category:port-update The issue is with a library, which is requesting update new revision depends:vm-update PR contains changes to the VM provisioning scripts labels Nov 6, 2020
@BillyONeal
Copy link
Member

Quoting the other PR:

Although the ftp server is very slow, it takes about an hour to download the 156mb file

We might need to disable this port in our CI if it's going to hang the agents for an hour. Maybe when we can cache inputs...

@StarGate-One
Copy link
Contributor Author

StarGate-One commented Nov 6, 2020 •
edited
Loading

Quoting the other PR:

Although the ftp server is very slow, it takes about an hour to download the 156mb file

We might need to disable this port in our CI if it's going to hang the agents for an hour. Maybe when we can cache inputs...

I have no problem with it -- I have searched to see if I could find if someone else already had it cached, but could not find it anywhere, so I do not know where to we would host it?

I did previously find where the CONAN project mentions the same issue conan-io/conan-center-index#1779 .

It does look like one can download/host/redistribute the software based on the downloaded MSP Geotrans Terms of Use from their site: MSP_Geotrans_Terms_Of_Use.txt

@StarGate-One StarGate-One changed the title [geotrans] update to version 3.8 (on-hold waiting for CI/VM port 80 for ftp to be opened) [geotrans] update to version 3.8 (on-hold waiting for CI/VM port 21 for ftp to be opened) Nov 6, 2020
@StarGate-One StarGate-One changed the title [geotrans] update to version 3.8 (on-hold waiting for CI/VM port 21 for ftp to be opened) [geotrans] update to version 3.8 (on-hold waiting for CI/VM port 21 for ftp to be opened or alternate host site) Nov 6, 2020
BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Dec 9, 2020
@BillyONeal
Build Fixes 2020-12-09
4f86bed 
These results are from the build https://dev.azure.com/vcpkg/public/_build/results?buildId=46238

PASSING, REMOVE FROM FAIL LIST: tcl:x64-osx (.\scripts\ci.baseline.txt)

Unknown, maybe the vcpkg_fixup_cmake_targets change?

REGRESSION: anyrpc:x64-windows

CMake Error at CMakeLists.txt:90 (CONFIGURE_FILE):
  CONFIGURE_FILE Problem configuring file

Added DISABLE_PARALLEL_CONFIGURE.

REGRESSION: geotrans:x64-uwp

Will be fixed by microsoft#14412

-- Downloading http://earth-info.nga.mil/GandG/geotrans/geotrans3.7/linux_dev.tgz...
-- Downloading http://earth-info.nga.mil/GandG/geotrans/geotrans3.7/linux_dev.tgz... Failed. Status: 28;"Timeout was reached"
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:184 (message):

REGRESSION: ois:x64-windows-static

CMake Error at CMakeLists.txt:22 (configure_file):
  configure_file Problem configuring file

Added DISABLE_PARALLEL_CONFIGURE.

REGRESSION: osgearth:x64-windows
REGRESSION: osgearth:x86-windows

Unknown and this port has never passed in CI. After discussion with the team we are skipping this one.

REGRESSION: qt5-tools:x64-windows-static

Remains unknown.
@BillyONeal BillyONeal mentioned this pull request Dec 9, 2020
Merged
BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Dec 22, 2020
@BillyONeal
Open the FTP and SFTP ports from microsoft#14412
7d03b0b
BillyONeal added a commit that referenced this pull request Dec 22, 2020
@BillyONeal
[opentracing] Update VMs 2020-12 (#15151)
229f537 
* Add meson from #12860

* Add autoconf-archive from #13081

* Add kf5windowsystem libs from #13467

* Open the FTP and SFTP ports from #14412

* Add libxcb-util0-dev from #14678

* Add libasound2-dev from #14774

* Remove no longer necessary apt-mark calls.

* Update nasm on Linux.

* Fix longstanding bug where Storage was publicly accessible and change to generate SAS token rather than File Share

* Delete no longer necessary azure storage firewall rules.

* Install the newer Windows SDK with the VS installer instead of manually.

* Install the VS2015 and VS2017 compilers.

* Update Powershell-Core to 7.1.0.

* Update source of WDK.

* Update pools.

* [opentracing] Repair arm64-windows failures caused by mojibake in `expected.hpp` and errors in opentracing-cpp's lint for arm64 where it thinks exceptions are disabled when they are enabled.

Fixes:
C:\Dev\vcpkg\buildtrees\opentracing\src\b67575dab0-0250653c81.clean\3rd_party\include\opentracing/expected/expected.hpp(1): warning C4828: The file contains a character starting at offset 0x4a77 that is illegal in the current source character set (codepage 65001).

Fixes:
D:\buildtrees\opentracing\src\b67575dab0-0250653c81.clean\include\opentracing/tracer.h:223:5: error: cannot use 'try' with exceptions disabled [clang-diagnostic-error]
    try {
    ^

* [mmloader] Patch out overrides of CMAKE_C_FLAGS and CMAKE_CXX_FLAGS that inserted /WX.

Note that this port sets /GS-, possibly because it may be for authoring shellcode.

* Bump storage API version to 2020-04-08.
@BillyONeal BillyONeal removed the depends:vm-update PR contains changes to the VM provisioning scripts label Dec 22, 2020
@BillyONeal
Copy link
Member

Despite the port being now open looks like upstream is too unreliable. If it is acceptable to you can you add =skip entries to ci.baseline.txt with a comment about the slow/unreliable upstream?

ryukw7 pushed a commit to ryukw7/vcpkg that referenced this pull request Dec 24, 2020
@BillyONeal
[opentracing] Update VMs 2020-12 (microsoft#15151)
c712063 
* Add meson from microsoft#12860

* Add autoconf-archive from microsoft#13081

* Add kf5windowsystem libs from microsoft#13467

* Open the FTP and SFTP ports from microsoft#14412

* Add libxcb-util0-dev from microsoft#14678

* Add libasound2-dev from microsoft#14774

* Remove no longer necessary apt-mark calls.

* Update nasm on Linux.

* Fix longstanding bug where Storage was publicly accessible and change to generate SAS token rather than File Share

* Delete no longer necessary azure storage firewall rules.

* Install the newer Windows SDK with the VS installer instead of manually.

* Install the VS2015 and VS2017 compilers.

* Update Powershell-Core to 7.1.0.

* Update source of WDK.

* Update pools.

* [opentracing] Repair arm64-windows failures caused by mojibake in `expected.hpp` and errors in opentracing-cpp's lint for arm64 where it thinks exceptions are disabled when they are enabled.

Fixes:
C:\Dev\vcpkg\buildtrees\opentracing\src\b67575dab0-0250653c81.clean\3rd_party\include\opentracing/expected/expected.hpp(1): warning C4828: The file contains a character starting at offset 0x4a77 that is illegal in the current source character set (codepage 65001).

Fixes:
D:\buildtrees\opentracing\src\b67575dab0-0250653c81.clean\include\opentracing/tracer.h:223:5: error: cannot use 'try' with exceptions disabled [clang-diagnostic-error]
    try {
    ^

* [mmloader] Patch out overrides of CMAKE_C_FLAGS and CMAKE_CXX_FLAGS that inserted /WX.

Note that this port sets /GS-, possibly because it may be for authoring shellcode.

* Bump storage API version to 2020-04-08.
@StarGate-One
Copy link
Contributor Author

@BillyONeal @JackBoosY

  • I updated the CI to skip x64-linux, x64-windows and x86-windows as those are the only 3 we are building the port for. The rest of the standard triplets are handled in the file vcpkg.json supports section.
  • I also updated the warning message(s) in the file portfile.cmake stating long download time for source.

@JackBoosY
Copy link
Contributor

@StarGate-One Can we use geotrans other mirrors?

@StarGate-One
Copy link
Contributor Author

@StarGate-One Can we use geotrans other mirrors?

@JackBoosY

  • I have not found a mirror with version 3.8, although there are a few github repos with version 3.7
  • It looks, based on this document MSP_Geotrans_Terms_Of_Use.txt, it can be hosted in other repos as long as the license guidelines are followed and it is made clear the government and/or the NGA does not endorse or recommend any software it is used in...

JackBoosY
JackBoosY suggested changes Jan 4, 2021
View reviewed changes
ports/geotrans/vcpkg.json Show resolved Hide resolved
BillyONeal added a commit to microsoft/vcpkg-tool that referenced this pull request Jan 4, 2021
@BillyONeal
[opentracing] Update VMs 2020-12 (#15151)
76b9f66 
* Add meson from microsoft/vcpkg#12860

* Add autoconf-archive from microsoft/vcpkg#13081

* Add kf5windowsystem libs from microsoft/vcpkg#13467

* Open the FTP and SFTP ports from microsoft/vcpkg#14412

* Add libxcb-util0-dev from microsoft/vcpkg#14678

* Add libasound2-dev from microsoft/vcpkg#14774

* Remove no longer necessary apt-mark calls.

* Update nasm on Linux.

* Fix longstanding bug where Storage was publicly accessible and change to generate SAS token rather than File Share

* Delete no longer necessary azure storage firewall rules.

* Install the newer Windows SDK with the VS installer instead of manually.

* Install the VS2015 and VS2017 compilers.

* Update Powershell-Core to 7.1.0.

* Update source of WDK.

* Update pools.

* [opentracing] Repair arm64-windows failures caused by mojibake in `expected.hpp` and errors in opentracing-cpp's lint for arm64 where it thinks exceptions are disabled when they are enabled.

Fixes:
C:\Dev\vcpkg\buildtrees\opentracing\src\b67575dab0-0250653c81.clean\3rd_party\include\opentracing/expected/expected.hpp(1): warning C4828: The file contains a character starting at offset 0x4a77 that is illegal in the current source character set (codepage 65001).

Fixes:
D:\buildtrees\opentracing\src\b67575dab0-0250653c81.clean\include\opentracing/tracer.h:223:5: error: cannot use 'try' with exceptions disabled [clang-diagnostic-error]
    try {
    ^

* [mmloader] Patch out overrides of CMAKE_C_FLAGS and CMAKE_CXX_FLAGS that inserted /WX.

Note that this port sets /GS-, possibly because it may be for authoring shellcode.

* Bump storage API version to 2020-04-08.
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 5, 2021
@vicroms vicroms merged commit 4907797 into microsoft:master Jan 5, 2021
@StarGate-One StarGate-One deleted the geotrans branch January 5, 2021 21:20
@ruilvo ruilvo mentioned this pull request Jul 26, 2021
Merged
4 tasks
Sungeun0318 pushed a commit to Sungeun0318/-vcpkg that referenced this pull request May 15, 2024
@BillyONeal
[opentracing] Update VMs 2020-12 (#15151)
c5692a3 
* Add meson from microsoft/vcpkg#12860

* Add autoconf-archive from microsoft/vcpkg#13081

* Add kf5windowsystem libs from microsoft/vcpkg#13467

* Open the FTP and SFTP ports from microsoft/vcpkg#14412

* Add libxcb-util0-dev from microsoft/vcpkg#14678

* Add libasound2-dev from microsoft/vcpkg#14774

* Remove no longer necessary apt-mark calls.

* Update nasm on Linux.

* Fix longstanding bug where Storage was publicly accessible and change to generate SAS token rather than File Share

* Delete no longer necessary azure storage firewall rules.

* Install the newer Windows SDK with the VS installer instead of manually.

* Install the VS2015 and VS2017 compilers.

* Update Powershell-Core to 7.1.0.

* Update source of WDK.

* Update pools.

* [opentracing] Repair arm64-windows failures caused by mojibake in `expected.hpp` and errors in opentracing-cpp's lint for arm64 where it thinks exceptions are disabled when they are enabled.

Fixes:
C:\Dev\vcpkg\buildtrees\opentracing\src\b67575dab0-0250653c81.clean\3rd_party\include\opentracing/expected/expected.hpp(1): warning C4828: The file contains a character starting at offset 0x4a77 that is illegal in the current source character set (codepage 65001).

Fixes:
D:\buildtrees\opentracing\src\b67575dab0-0250653c81.clean\include\opentracing/tracer.h:223:5: error: cannot use 'try' with exceptions disabled [clang-diagnostic-error]
    try {
    ^

* [mmloader] Patch out overrides of CMAKE_C_FLAGS and CMAKE_CXX_FLAGS that inserted /WX.

Note that this port sets /GS-, possibly because it may be for authoring shellcode.

* Bump storage API version to 2020-04-08.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@NancyLi1013 NancyLi1013

@JackBoosY JackBoosY

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[geotrans] update to 3.8
5 participants
@StarGate-One @BillyONeal @JackBoosY @vicroms @NancyLi1013