import is used which is only available from conan >= 1.46.0 #11956

nilsnolde · 2022-07-28T18:17:28Z

Specify library name and version: boost/all

fixes #11955

in fact the import in question wasn't released until v1.46.x: https://github.com/conan-io/conan/blob/release/1.46/conan/tools/build/__init__.py

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

CLAassistant · 2022-07-28T18:17:33Z

All committers have signed the CLA.

ghost · 2022-07-28T18:19:56Z

I detected other pull requests that are modifying boost/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

uilianries

LGTM

uilianries · 2022-07-29T09:04:06Z

@nilsnolde thank you for your contribution, please, ask for access request first: #11956 (comment)

nilsnolde · 2022-07-30T09:01:12Z

more a philosophy question: in this simple case we could also have a conditional import e.g.

try:  # >= 1.46.0
    from conan.tools.build import cross_building
except:
    from conans.tools import cross_building

is that smth you do generally, or you avoid version conditionals and just increase the min conan version?

uilianries · 2022-08-01T09:17:56Z

more a philosophy question: in this simple case we could also have a conditional import e.g.
try:  # >= 1.46.0
    from conan.tools.build import cross_building
except:
    from conans.tools import cross_building
is that smth you do generally, or you avoid version conditionals and just increase the min conan version?

@nilsnolde Conan client parses required_conan_version to validate which version is needed to execute a recipe. However, first we need to import Conan modules. So, the best approach is:

People need to update their Conan client.

Also, Conan Center Index expects it: https://github.com/conan-io/conan-center-index/blob/master/docs/how_to_add_packages.md#submitting-a-package

nilsnolde · 2022-08-01T09:53:37Z

However, first we need to import Conan modules.

right.. then bumping the min version won't prevent the recipe to fail with conan < 1.46.0 with the same ImportError (didn't try before). wouldn't a conditional import like the one above remove the need for bumping the min version at all and be generally a better fix?

btw, I asked for access, should come soon I guess. does the ci job somehow schedule itself or I need to do smth after I got access?

uilianries · 2022-08-01T10:01:52Z

right.. then bumping the min version won't prevent the recipe to fail with conan < 1.46.0 with the same ImportError (didn't try before). wouldn't a conditional import like the one above remove the need for bumping the min version at all and be generally a better fix?

No, because there are more features involved than only cross_building.

btw, I #4 (comment), should come soon I guess. does the ci job somehow schedule itself or I need to do smth after I got access?

The access request process is executed 3 times every week. A bot collects the new names, Conan team checks those new users, then approve (or not in case a suspicious profile). After that, the CI bot will re-run automatically all PRs which were waiting for the Access Request.

conan-center-bot · 2022-08-05T05:14:05Z

All green in build 3 (59fd98fbe985343e53f1ec527fbb575887c189b5):

boost/1.72.0@:
All packages built successfully! (All logs)