New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[boost] Bump dependencies #12024

Merged

conan-center-bot merged 6 commits into conan-io:master from uilianries:boost/bump-deps

Aug 4, 2022

Member

uilianries commented Aug 3, 2022

Promote both b2 and libiconv to the latest version available on Conan Center

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

uilianries added 3 commits

August 3, 2022 13:01


          boost - bump deps

2e51673

Signed-off-by: Uilian Ries <uilianries@gmail.com>


          only bump deps

7f02bfe

Signed-off-by: Uilian Ries <uilianries@gmail.com>


          only bump deps

6249d13

Signed-off-by: Uilian Ries <uilianries@gmail.com>

conan-center-bot added the Bump dependencies label

ghost mentioned this pull request

[service] Potentially conflicting recipes #3571

Closed

ghost commented Aug 3, 2022 •

edited by ghost

Loading

I detected other pull requests that are modifying boost/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

This was referenced Aug 3, 2022

[boost] add support for multiple boost_python versions #11998

Closed

boost: add BOOST_FILESYSTEM_VERSION #11988

Merged

import is used which is only available from conan >= 1.46.0 #11956

Merged

Fix packaging of boost if os=Emscripten and header_only=True #11862

Merged


          replace tools.Version

ea909df

Signed-off-by: Uilian Ries <uilianries@gmail.com>

conan-center-bot removed the Bump dependencies label


          update more tools

8e13eed

Signed-off-by: Uilian Ries <uilianries@gmail.com>

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label


          keep previous self.copy for now

5cef0dc

Signed-off-by: Uilian Ries <uilianries@gmail.com>

conan-center-bot removed the Failed label

uilianries requested a review from SSE4

August 3, 2022 12:18

github-actions bot mentioned this pull request

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

This was referenced Aug 3, 2022

Fix issue 12028 - Conan cannot install boost on Windows based on Linux profiles #12029

Closed

Fix issue 12028 - Conan cannot install boost on Windows based on Linux profiles #12031

Merged

Collaborator

conan-center-bot commented Aug 4, 2022

All green in build 7 (5cef0dc6d401de6ecd19467da5f60b69e379dd10):

boost/1.74.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py", line 6, in <module>
    from conans import tools
ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

boost/1.70.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py", line 6, in <module>
    from conans import tools
ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

boost/1.71.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py", line 6, in <module>
    from conans import tools
ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

boost/1.78.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py", line 6, in <module>
    from conans import tools
ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

boost/1.79.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py", line 6, in <module>
    from conans import tools
ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

boost/1.72.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py", line 6, in <module>
    from conans import tools
ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

boost/1.73.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py", line 6, in <module>
    from conans import tools
ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

boost/1.76.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py", line 6, in <module>
    from conans import tools
ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

boost/1.77.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py", line 6, in <module>
    from conans import tools
ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

boost/1.75.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12024/recipes/boost/all/conanfile.py", line 6, in <module>
    from conans import tools
ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

Contributor

github-actions bot commented Aug 4, 2022

Hooks produced the following warnings for commit 5cef0dc

boost/1.78.0

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\boost_log.dll' links to system library 'secur32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\boost_log.dll' links to system library 'ws2_32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\boost_log_setup.dll' links to system library 'ws2_32' but it is not in cpp_info.system_libs.

boost/1.77.0

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\boost_log.dll' links to system library 'ws2_32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\boost_log_setup.dll' links to system library 'ws2_32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\boost_log.dll' links to system library 'secur32' but it is not in cpp_info.system_libs.

jgsogo approved these changes

View reviewed changes

Member Author

uilianries commented Aug 4, 2022

Finally passed!

SSE4 approved these changes

View reviewed changes

conan-center-bot merged commit c6cddd3 into conan-io:master

ChendoChap commented Aug 6, 2022

see the comment I've left here, I'm relatively sure this broke the recipe: c6cddd3#r80406005

SergeyKrivohatskiy commented Aug 6, 2022 •

edited

Loading

Hi!

Looks like this pull request (I guess upgrading b2) has broken boost builds on Windows with option layout=b2-default (equivalent to versioned on Windows).

For example calling this
conan install boost/1.70.0@ -b=boost -o "layout=b2-default"
will fail with the next error (I've also attached the full log.txt):

ERROR: boost/1.70.0: Error in package_info() method, line 1666
        raise ConanException("These libraries were built, but were not used in any boost module: {}".format(non_used))
        ConanException: These libraries were built, but were not used in any boost module: {'libboost_log-vc142-mt-x64-1_70', 'libboost_type_erasure-vc142-mt-x64-1_70', 'libboost_iostreams-vc142-mt-x64-1_70', 'libboost_context-vc142-mt-x64-1_70', 'libboost_regex-vc142-mt-x64-1_70', 'libboost_coroutine-vc142-mt-x64-1_70', 'libboost_contract-vc142-mt-x64-1_70', 'libboost_math_tr1l-vc142-mt-x64-1_70', 'libboost_stacktrace_noop-vc142-mt-x64-1_70', 'libboost_system-vc142-mt-x64-1_70', 'libboost_exception-vc142-mt-x64-1_70', 'libboost_graph-vc142-mt-x64-1_70', 'libboost_thread-vc142-mt-x64-1_70', 'libboost_math_tr1f-vc142-mt-x64-1_70', 'libboost_stacktrace_windbg-vc142-mt-x64-1_70', 'libboost_unit_test_framework-vc142-mt-x64-1_70', 'libboost_stacktrace_windbg_cached-vc142-mt-x
64-1_70', 'libboost_math_c99f-vc142-mt-x64-1_70', 'libboost_test_exec_monitor-vc142-mt-x64-1_70', 'libboost_random-vc142-mt-x64-1_70', 'libboost_log_setup-vc142-mt-x64-1_70', 'libboost_fiber-vc142-mt-x64-1_70', 'libboost_locale-vc142-mt-x64-1_70', 'libboost_fiber_numa-vc142-mt-x64-1_70', 'libboost_serialization-vc142-mt-x64-1_70', 'libboost_chrono-vc142-mt-x64-1_70', 'libboost_wserialization-vc142-mt-x64-1_70', 'libboost_date_time-vc142-mt-x64-1_70', 'libboost_program_options-vc142-mt-x64-1_70', 'libboost_container-vc142-mt-x64-1_70', 'libboost_math_c99l-vc142-mt-x64-1_70', 'libboost_filesystem-vc142-mt-x64-1_70', 'libboost_prg_exec_monitor-vc142-mt-x64-1_70', 'libboost_wave-vc142-mt-x64-1_70', 'libboost_math_c99-vc142-mt-x64-1_70', 'libboost_atomic-vc142-mt-x64-1_70', 'libboost_math_tr1-vc142-mt-x64-1_70', 'libboost_timer-vc142-mt-x64-1_70'}

Member Author

uilianries commented Aug 8, 2022

@SergeyKrivohatskiy thank you for reporting. Please, Open an issue (bug report) and fill all details asked on the template: https://github.com/conan-io/conan-center-index/issues/new/choose So we can reproduce your case.

markferry reviewed

View reviewed changes

recipes/boost/all/conanfile.py

Comment on lines +1575 to 1577

+                              pyversion = Version(self._python_version)
                               libformatdata["py_major"] = pyversion.major
                               libformatdata["py_minor"] = pyversion.minor

markferry Aug 8, 2022

This switches the code from using conans.client.tools.version.Version which wraps semver and has .major and .minor properties to conans.model.version.Version (which has .major and .minor methods).

So the later calls to .major and .minor aren't calling the method and we get:

@(Pdb) Version(self._python_version).major
<bound method Version.major of '3.10'>

Should I revert the change or update these to

pyversion.major(fill=False)
pyversion.minor(fill=False)

@uilianries wanted to check your intention before raising a bug.

markferry Aug 8, 2022

Member Author

uilianries Aug 9, 2022

@markferry The intention is only one: Move to Conan 2.0 https://docs.conan.io/en/latest/conan_v2.html Of course, it's a side-effect. Thanks for sharing, it deserves a new hotfix.

markferry added a commit to cognomen/conan-center-index that referenced this pull request


          wip: fix conan-io#12044: revert part of conan-io#12024 which breaks V…

403c1fc

…ersion

This switches the code from using `conans.client.tools.version.Version`
(which wraps semver and has .major and .minor properties) to
`conans.model.version.Version` (which has .major and .minor methods).

So the later calls to .major and .minor weren't calling the methods and we get:

```python
@(Pdb) Version(self._python_version).major
<bound method Version.major of '3.10'>
```

jcar87 mentioned this pull request

[boost] Revert scm.Version usage #12131

Merged

4 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet