Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mold] Add latest version 1.4.1 #12703

Closed
wants to merge 4 commits into from

Conversation

ericriff
Copy link
Contributor

@ericriff ericriff commented Aug 30, 2022

Mold has moved to CMake on its latest release, so this PR makes the recipe a bit convoluted.
Should we move the old recipe to a 1.3 folder and keep it as a different recipe? Deprecate 1.3 and keep only 1.4+? Keep both build systems on the same recipe as this PR proposes?

@conan-center-bot conan-center-bot added the Bump version PR bumping version without recipe modifications label Aug 30, 2022
@conan-center-bot

This comment has been minimized.

@ericriff
Copy link
Contributor Author

Well, I'll decline this. The recipe is not compatible with the newer version and I can't make it build locally, so working on this will be tedious for me.
The latest version now supports CMake, we should use it instead of plain makefiles.
I'll reopen this if I get the time to play around with a docker container with newer toolchains.

@ericriff ericriff closed this Aug 31, 2022
@ericriff ericriff reopened this Sep 2, 2022
@conan-center-bot conan-center-bot removed Failed Bump version PR bumping version without recipe modifications labels Sep 2, 2022
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AndreyMlashkin
Copy link
Contributor

@ericriff, I made it work with gcc10:
#12782

@AndreyMlashkin
Copy link
Contributor

I would just create a new recipe parallel to the exisiting one and use cmake there

@ghost
Copy link

ghost commented Sep 2, 2022

I detected other pull requests that are modifying mold/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ericriff
Copy link
Contributor Author

ericriff commented Sep 2, 2022

@AndreyMlashkin cool. This PR is just an experiment and needs a lot of cleanup. I'm not sure how to handle the change in build systems. Maybe we can deprecate 1.3.x? Or keep using makefiles on 1.4?

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ericriff ericriff force-pushed the eriff/add-mold-1.4.1 branch from d2d6dbb to 649d245 Compare September 5, 2022 16:43
@conan-center-bot
Copy link
Collaborator

All green in build 9 (649d24568cf81cdae1fe557b052d82de78d04cb2):

  • mold/1.3.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12703/recipes/mold/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12703/recipes/mold/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-12703/recipes/mold/all/conanfile.py", line 5, in <module>
        from conans import AutoToolsBuildEnvironment, CMake
    ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • mold/1.4.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12703/recipes/mold/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12703/recipes/mold/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-12703/recipes/mold/all/conanfile.py", line 5, in <module>
        from conans import AutoToolsBuildEnvironment, CMake
    ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    

@ericriff ericriff marked this pull request as ready for review September 5, 2022 17:45
autotools.make(target="mold", args=['SYSTEM_TBB=1', 'SYSTEM_MIMALLOC=1'])
else:
# Error out if ZLIB is not found, we want to be predictable
files.replace_in_file(self, "source_subfolder/CMakeLists.txt", "find_package(ZLIB QUIET)", "find_package(ZLIB REQUIRED)")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll move this to a proper helper function once we agree on the topics mentioned on the PR description

@AndreyMlashkin
Copy link
Contributor

I am using a cmake chain here:
#12881

I think, you can close this PR

@ericriff
Copy link
Contributor Author

ericriff commented Sep 9, 2022

Closed in favor of another PR.

@ericriff ericriff closed this Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants