-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mold] Add latest version 1.4.1 #12703
Conversation
This comment has been minimized.
This comment has been minimized.
Well, I'll decline this. The recipe is not compatible with the newer version and I can't make it build locally, so working on this will be tedious for me. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I would just create a new recipe parallel to the exisiting one and use cmake there |
I detected other pull requests that are modifying mold/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
@AndreyMlashkin cool. This PR is just an experiment and needs a lot of cleanup. I'm not sure how to handle the change in build systems. Maybe we can deprecate 1.3.x? Or keep using makefiles on 1.4? |
95627c2
to
d55952f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
d2d6dbb
to
649d245
Compare
All green in build 9 (
|
autotools.make(target="mold", args=['SYSTEM_TBB=1', 'SYSTEM_MIMALLOC=1']) | ||
else: | ||
# Error out if ZLIB is not found, we want to be predictable | ||
files.replace_in_file(self, "source_subfolder/CMakeLists.txt", "find_package(ZLIB QUIET)", "find_package(ZLIB REQUIRED)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll move this to a proper helper function once we agree on the topics mentioned on the PR description
I am using a cmake chain here: I think, you can close this PR |
Closed in favor of another PR. |
Mold has moved to CMake on its latest release, so this PR makes the recipe a bit convoluted.
Should we move the old recipe to a
1.3
folder and keep it as a different recipe? Deprecate 1.3 and keep only 1.4+? Keep both build systems on the same recipe as this PR proposes?