Add mold 142 as build system changed from makefiles to cmake #12881

AndreyMlashkin · 2022-09-09T10:08:45Z

Specify library name and version: mold/1.4.2

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

jgsogo · 2022-09-09T11:04:25Z

recipes/mold/1.3.1/conanfile.py

@@ -64,6 +64,9 @@ def _patch_sources(self):
        files.replace_in_file(self, "source_subfolder/Makefile", "MOLD_LDFLAGS += -lmimalloc", "MOLD_LDFLAGS += -L{} -lmimalloc".format(
            self.deps_cpp_info["mimalloc"].lib_paths[0]))

+    def build_requirements(self):
+        self.build_requires("cmake/3.24.1")


Why do we need latest CMake?

To keep it longer up-to-date. Is there any reason why I shouldn't use the latest version?

No, not an issue. I just wanted to know why the default (the one installed in the CI) was not enough.

If it is needed only for new version 1.4.2, please add it only to its corresponding conanfile.py, not to old versions.

Build #2 failed because of cmake requrement
mold/1.4.2:
CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
CMake 3.18 or higher is required. You are running version 3.15.7

It seems, cmake shall got a version bump first... I hoped, I will get a new mold version fast

1.3.1 continues to build with make, you don't need cmake here

I have separated versions 1.3.x and 1.4.x one is using make another is using cmake

Oh, I realized, you're right, it's not required for 1.3.x. Fixed now

ghost · 2022-09-09T11:14:05Z

I detected other pull requests that are modifying mold/all recipe:

[mold] Add latest version 1.4.1 #12703

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

AndreyMlashkin · 2022-10-03T08:42:59Z

recipes/mold/1.4.x/test_package/conanfile.py



 class MoldTestConan(ConanFile):
    settings = "os", "compiler", "build_type", "arch"
-    # VirtualRunEnv can be avoided if "tools.env.virtualenv:auto_use" is defined
-    # (it will be defined in Conan 2.0)
-    generators = "VirtualBuildEnv"


@uilianries @prince-chrismc What sould it be in the end? VirtualBuildEnv or VirtualRunEnv? I am confused

It stopped working, as I have applied a suggestion with this change.
Why on your oppinion, it should be Run environment and not build?

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

ericriff · 2022-10-03T19:57:45Z

recipes/mold/config.yml

@@ -1,3 +1,5 @@
 versions:
  "1.3.1":
-    folder: all
+    folder: 1.3.1
+  "1.4.2":


This got outdated since you included version 1.5. Would it make sense to rename the folder to all? So we have an all folder for current recipes and a legacy 1.3.1 folder. It looks like mold changes minor versions often since 1.4 is relatively new.

Yes, makes sense

uilianries · 2022-10-05T06:32:39Z

@AndreyMlashkin Could you please add a test_v1_package? It's important to ensure Conan 1.x compatibility. Basically you just need to rename the previous version of test_package to test_v1_package.

conan-center-bot · 2022-10-05T07:51:31Z

All green in build 34 (5b3cb57ad44eb0ee9ca510f3a68a89882030ecd1):

mold/1.3.1@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12881/recipes/mold/1.3.1/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12881/recipes/mold/1.3.1/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12881/recipes/mold/1.3.1/conanfile.py", line 6, in <module>
    from conans import AutoToolsBuildEnvironment
ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

mold/1.4.2@:
All packages built successfully! (All logs)
mold/1.5.1@:
All packages built successfully! (All logs)

recipes/mold/all/test_package/conanfile.py

uilianries · 2022-10-06T08:14:58Z

recipes/mold/1.3.1/conanfile.py

+        self.output.info('Appending PATH environment variable: {}'.format(bindir))
+        self.env_info.PATH.append(bindir)
+        self.env_info.LD = mold_location
+        self.buildenv_info.prepend_path("MOLD_ROOT", bindir)


Now I see why it's not working with VirtuanRunEnv, there is no configuration for self.runenv_info but it's fine, as it's a linker, there is no reason for using on runtime environment.

uilianries

LGTM

AndreyMlashkin · 2022-10-06T19:18:02Z

Johuuu, finally

ericriff

LGTM

…to cmake * add version 1.4.2 * add with_mimalloc option * add validate method * add cmake as build requrements * use minmalloc from conan * use minmalloc from conan * use tbb from conan * don't use cmake as requirement for old mold * hotfix * add cmake_find_package generator * add CMakeDeps * don't use old conans import * Update recipes/mold/1.4.x/conanfile.py Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * package licenses * make artifacts match settings * correct package method for mold 1.3.1 * package mold binary differently for gcc and clang * exclude windows builds * delete unneeded CMakeLists * Apply suggestions from code review Co-authored-by: Uilian Ries <uilianries@gmail.com> * import VirtualBuildEnv * add a newline * Apply suggestions from code review Co-authored-by: Uilian Ries <uilianries@gmail.com> * delete package id also for 1.3.1 version * use build_requirements instead of requirements in test * Apply suggestions from code review Co-authored-by: Uilian Ries <uilianries@gmail.com> * Update recipes/mold/1.4.x/test_package/conanfile.py Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * make mold test recipe work again * add version 1.5.1 * rename folder * add test_v1_package Co-authored-by: Chris Mc <prince.chrismc@gmail.com> Co-authored-by: Uilian Ries <uilianries@gmail.com>

AndreyMlashkin mentioned this pull request Sep 9, 2022

[mold] Add latest version 1.4.1 #12703

Closed

github-actions bot mentioned this pull request Sep 9, 2022

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Sep 9, 2022

This comment has been minimized.

Sign in to view

conan-center-bot removed the Failed label Sep 9, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added Failed and removed Failed labels Sep 9, 2022

jgsogo reviewed Sep 9, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Sep 9, 2022

ghost mentioned this pull request Sep 9, 2022

[service] Potentially conflicting recipes #3571

Closed

conan-center-bot removed the Failed label Sep 9, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added Failed and removed Failed labels Sep 9, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Sep 9, 2022

AndreyMlashkin added 4 commits September 9, 2022 13:59

add version 1.4.2

ea1a264

add with_mimalloc option

2022a3c

add validate method

0bd7e4a

add cmake as build requrements

b9e46d7

AndreyMlashkin force-pushed the add_mold_142 branch from 5235d75 to b9e46d7 Compare September 9, 2022 11:59

conan-center-bot removed the Failed label Sep 9, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Sep 9, 2022

This was referenced Sep 9, 2022

Updatable recipes qchateau/conan-center-bot#1

Open

[request] Updatable recipes #3470

Closed

AndreyMlashkin commented Oct 3, 2022

View reviewed changes

Update recipes/mold/1.4.x/test_package/conanfile.py

0b18808

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

conan-center-bot removed the Failed label Oct 3, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Oct 3, 2022

make mold test recipe work again

65e95ba

conan-center-bot removed the Failed label Oct 3, 2022

This comment has been minimized.

Sign in to view

add version 1.5.1

e569462

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Oct 3, 2022

ericriff reviewed Oct 3, 2022

View reviewed changes

rename folder

ca1a600

conan-center-bot removed the Failed label Oct 4, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Oct 4, 2022

add test_v1_package

5b3cb57

conan-center-bot removed the Failed label Oct 5, 2022

uilianries reviewed Oct 5, 2022

View reviewed changes

recipes/mold/all/test_package/conanfile.py Show resolved Hide resolved

uilianries reviewed Oct 6, 2022

View reviewed changes

uilianries approved these changes Oct 6, 2022

View reviewed changes

AndreyMlashkin requested a review from SSE4 October 6, 2022 08:17

prince-chrismc approved these changes Oct 6, 2022

View reviewed changes

conan-center-bot merged commit 22d8d24 into conan-io:master Oct 6, 2022

AndreyMlashkin deleted the add_mold_142 branch October 6, 2022 19:18

ericriff reviewed Oct 6, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add mold 142 as build system changed from makefiles to cmake #12881

Add mold 142 as build system changed from makefiles to cmake #12881

AndreyMlashkin commented Sep 9, 2022 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jgsogo Sep 9, 2022

AndreyMlashkin Sep 9, 2022

jgsogo Sep 9, 2022

AndreyMlashkin Sep 9, 2022

AndreyMlashkin Sep 9, 2022

ericriff Sep 9, 2022

AndreyMlashkin Sep 14, 2022

AndreyMlashkin Sep 14, 2022

This comment has been minimized.

ghost commented Sep 9, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

AndreyMlashkin Oct 3, 2022

AndreyMlashkin Oct 3, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ericriff Oct 3, 2022

AndreyMlashkin Oct 4, 2022

This comment has been minimized.

uilianries commented Oct 5, 2022

conan-center-bot commented Oct 5, 2022

uilianries Oct 6, 2022

uilianries left a comment

AndreyMlashkin commented Oct 6, 2022

ericriff left a comment

Add mold 142 as build system changed from makefiles to cmake #12881

Add mold 142 as build system changed from makefiles to cmake #12881

Conversation

AndreyMlashkin commented Sep 9, 2022 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

ghost commented Sep 9, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

uilianries commented Oct 5, 2022

conan-center-bot commented Oct 5, 2022

Choose a reason for hiding this comment

uilianries left a comment

Choose a reason for hiding this comment

AndreyMlashkin commented Oct 6, 2022

ericriff left a comment

Choose a reason for hiding this comment

AndreyMlashkin commented Sep 9, 2022 •

edited

Loading