-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boost: Add 1.80.0 #12807
boost: Add 1.80.0 #12807
Conversation
I detected other pull requests that are modifying boost/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I can't reproduce the |
I have macOS. I think I can test it after 4-5 hours (after work) |
I decided to try to build boost with -d9 (9th level of debug) b2 option. What a mistake |
I think i fixed the issue, but i don't understand how to contribute a commit. I tried to push a branch into jwillikers:conan-center-index but got rejected. |
You wouldn't have write permission to my repository. I don't have much experience with doing multi-contributor PR's, but I bet you can fork |
Here it is |
C'mon. I have already been a contributor. I think i messed up user.name in commit( |
@TheSalvator, thanks for figuring out the macOS specific fixes necessary to get this working! I've incorporated your changes in my PR, but you'll need to make sure to sign Conan Center's CLA here. Thanks again! |
I messed up again. A already have signed CLA. Can you reset my PR and force push so I change the commit author and reopen the PR |
I'll drop your commit and you can resubmit a PR to my branch. |
d54f003
to
c59a680
Compare
@TheSalvator Done. |
@jwillikers Here you go) |
This follows the documented practices for Conan Center. URL was removed in favor of the patch_source field.
@jwillikers It's a pleasure working with you. Hope there is no more patches left to submit) |
@TheSalvator Same! |
@uilianries What is |
@TheSalvator it's the CI build, it will show the final result. It seems be supicious, but Boost takes almost an entire day to be built. One thing is building locally, another thing is generating more than 100 builds for each version. Both Boost and Qt are our Nemesis in terms of CI, they take both several hours to be built, and for each new commit we need to build all again. |
ANy update on this? Are we sure it's still running? |
I think we should drop some less popular versions... this way it wont overwhelm CCI so much. I pinged the CCI team to see if it's stuck, two days is a long time. |
- patch_file: "patches/1.80.0-0001-filesystem-win-fix-dir-it-net-share.patch" | ||
patch_description: "Directory iterators may fail to construct for a network share on Windows prior to 10" | ||
patch_type: "official" | ||
patch_source: "https://github.com/boostorg/filesystem/issues/245" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I absolutely appreciate that someone took the time to add these link ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! They are super helpful for context and keeping track of what needs to be pulled forward.
If it's useful in terms of testing, I have successfully exported this recipe and built it debug and release on both intel and arm Macs, with and without ICU |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The more people approve, the more resources assigned by the CI 😄 (it would be a nice feature to have)
Are you sure it's not stuck? Usually boost takes few hours in CI, not days. |
All green in build 10 (
|
Hooks produced the following warnings for commit 0f95028boost/1.79.0
boost/1.80.0
|
* boost: Add 1.80.0 * Tweak the local Jamfile diff slightly * Tweak Jamfile for locale again * Fix Locale Jamfile * Format diff * Revert iconv related changes in 1.80.0 Jamfile.v2 * Remove URL field for patches in conandata.yml This follows the documented practices for Conan Center. URL was removed in favor of the patch_source field. Co-authored-by: TheSalvator <kazakovilya97@gmail.com>
Specify library name and version: boost/1.80.0
Fixes #12564.