[libcurl/xxx] Conan v2 migration #12956
Conversation
|
I detected other pull requests that are modifying libcurl/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
ghost
mentioned this pull request
This comment has been minimized.
This comment has been minimized.
| self.run("chmod +x configure") | ||
|
|
||
| # run configure with *LD_LIBRARY_PATH env vars it allows to pick up shared openssl | ||
| with tools.run_environment(self): |
There was a problem hiding this comment.
It seems there is still an issue here. See #12377 (comment)
| @@ -231,14 +235,19 @@ def imports(self): | |||
| # but does not work on OS X 10.11 with SIP) | |||
| # 2. copying dylib's to the build directory (fortunately works on OS X) | |||
| if self.settings.os == "Macos": | |||
| self.copy("*.dylib*", dst=self._source_subfolder, keep_path=False) | |||
| copy(self, "*.dylib*", src=self.build_folder, dst=self.source_folder, keep_path=False) | |||
There was a problem hiding this comment.
In continuation of #12377 (comment)
This comment has been minimized.
This comment has been minimized.
|
#12888 🚀 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ghost
mentioned this pull request
Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Jordan Williams <jordan@jwillikers.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
|
All green in build 20 (
|
|
Oh yes amazing~!!!!!! merge!!!!! bot now please!!!!! |
|
Yes that last for a long time! Unfortunately there was still two issues I addressed here: Do you think there is something to fix ? |
| def package_id(self): | ||
| del self.info.settings.compiler |
There was a problem hiding this comment.
What is that? Comes from bfae914 but there is no rational
There was a problem hiding this comment.
I didn't manage to find why I pushed this commit.
|
|
||
| if self.options.with_ca_bundle == False: | ||
| params.append("--without-ca-bundle") | ||
| if self.options.with_ca_bundle is False: |
There was a problem hiding this comment.
default value is None and None is False returns False, not True
Specify library name and version: libcurl/xxx
Replacing #12377 after merge conflict.
I rebased on master and will try to reference all the ongoing issues.