-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libcurl: several fixes & bump dependencies #13684
Conversation
SpaceIm
commented
Oct 22, 2022
- do not delete settings.compiler from package id (comes from [libcurl/xxx] Conan v2 migration #12956)
- bump dependencies
- no need to copy dylib files of dependencies for conftest of autotools build, it's the job of VirtualRunEnv to inject paths of dylib files to DYLD_LIBRARY_PATH (SIP is not triggered in configure script AFAIK).
- fix installation of autotools if build machine is windows
- protect deletion of settings & options
- I've read the guidelines for contributing.
- I've followed the PEP8 style guides for Python code in the recipes.
- I've used the latest Conan client version.
- I've tried at least one configuration locally with the conan-center hook activated.
In case of native build, VirtualRunEnv in build scope is sufficient
None is not False
This comment has been minimized.
This comment has been minimized.
"with_ca_bundle": [None, "ANY"], | ||
"with_ca_path": [None, "ANY"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to set the default https://docs.conan.io/en/latest/migrating_to_2.0/recipes.html#any-special-value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default is None, that's the reason of this fix actually.
I detected other pull requests that are modifying libcurl/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
929496d
All green in build 4 (
|