Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcurl: several fixes & bump dependencies #13684

Merged
merged 9 commits into from
Oct 24, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Oct 22, 2022

  • do not delete settings.compiler from package id (comes from [libcurl/xxx] Conan v2 migration #12956)
  • bump dependencies
  • no need to copy dylib files of dependencies for conftest of autotools build, it's the job of VirtualRunEnv to inject paths of dylib files to DYLD_LIBRARY_PATH (SIP is not triggered in configure script AFAIK).
  • fix installation of autotools if build machine is windows
  • protect deletion of settings & options

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

jwillikers
jwillikers previously approved these changes Oct 22, 2022
MartinDelille
MartinDelille previously approved these changes Oct 22, 2022
@conan-center-bot

This comment has been minimized.

Comment on lines +70 to +71
"with_ca_bundle": [None, "ANY"],
"with_ca_path": [None, "ANY"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is None, that's the reason of this fix actually.

@ghost
Copy link

ghost commented Oct 24, 2022

I detected other pull requests that are modifying libcurl/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@SpaceIm SpaceIm dismissed stale reviews from MartinDelille and jwillikers via 929496d October 24, 2022 09:11
@conan-center-bot
Copy link
Collaborator

All green in build 4 (929496d95beb16dbe934eeed5f8af29606979d1b):

  • libcurl/7.85.0@:
    All packages built successfully! (All logs)

  • libcurl/7.84.0@:
    All packages built successfully! (All logs)

  • libcurl/7.82.0@:
    All packages built successfully! (All logs)

  • libcurl/7.76.0@:
    All packages built successfully! (All logs)

  • libcurl/7.83.1@:
    All packages built successfully! (All logs)

  • libcurl/7.79.1@:
    All packages built successfully! (All logs)

  • libcurl/7.78.0@:
    All packages built successfully! (All logs)

  • libcurl/7.77.0@:
    All packages built successfully! (All logs)

  • libcurl/7.80.0@:
    All packages built successfully! (All logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants