libdeflate: conan v2 support

[paulharris]

Finishing the v2 upgrade

[uilianries]

Please, remove .CMakeLists.txt.swp

[uilianries]

LGTM

[jwillikers]

Does VirtualBuildEnv automatically handle VCVars?

[uilianries]

I don't think so.

https://docs.conan.io/en/latest/reference/conanfile/tools/microsoft.html?highlight=vcvars#msbuild

It only handles msbuild stuff. VirtualBuildEnv is more related to environment variables.

[jwillikers]

How does building most packages work then, when I'm not in a Visual Studio Developer Command Prompt? I figured they would fail.

[prince-chrismc]

The msbuild helper does that step 😉

[paulharris]

@jwillikers one of the reasons I want to upgrade these recipes is so I can build everything in my git-bash-SDK-msys terminal on windows. And so far, the new recipes seem to be doing it well.

[prince-chrismc]

theres some good comments above

[paulharris]

@jwillikers @uilianries continuing from other comment,

I get messages like:

install -m755 libdeflate.so.0 /build/conandata/conan-data/libdeflate/1.14/ccitest/test1/package/0582ee0920dad9fef631620d3ef80b963208d3a1/usr/local/lib;

Note it installs to /usr/local/lib

and then, [HOOK - conan-center.py] post_package(): ERROR: [DEFAULT PACKAGE LAYOUT (KB-H013)] Unknown folder 'usr' in the package (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H013)

and CMake Error at build/generators/cmakedeps_macros.cmake:39 (message): Library 'deflate' not found in package. If 'deflate' is a system library, declare it with 'cpp_info.system_libs' property Call Stack (most recent call first):

I know autotools adds PREFIX=/ to configure calls, but it didn't seem to be done this time.
Weirdly, it works on Windows without PREFIX=/

[jwillikers]

Oh wait, this is a Makefile project and not actually Autotools, right? AutotoolsToolchain passes --prefix to the Autotools configure script. You wouldn't have that here so you'd have to use PREFIX or whatever the Makefile might expect. You can probably drop the DESTDIR then. I'm sorry for the confusion. We might need a dedicated generator for Makefile projects that doesn't require using things with Autotools in the name.

[paulharris]

Ok, dropped and just use PREFIX

[conan-center-bot]

Conan v1 pipeline

All green in build 8 (b270cebdb684372d0b380ef0f22cff8a72b4c43d):

• libdeflate/1.12@:
  All packages built successfully! (All logs)

• libdeflate/1.14@:
  All packages built successfully! (All logs)

• libdeflate/1.10@:
  All packages built successfully! (All logs)

• libdeflate/1.7@:
  All packages built successfully! (All logs)

• libdeflate/1.8@:
  All packages built successfully! (All logs)

• libdeflate/1.9@:
  All packages built successfully! (All logs)

[SpaceIm]

  Checking Build System
  Building Custom Rule C:/J/w/prod/BuildSingleReference/conan-center-index/recipes/libdeflate/all/test_package/CMakeLists.txt
  test_package.c
LINK : warning LNK4098: defaultlib 'LIBCMT' conflicts with use of other libs; use /NODEFAULTLIB:library [C:\J\w\prod\BuildSingleReference\conan-center-index\recipes\libdeflate\all\test_package\build\test_package.vcxproj]
  test_package.vcxproj -> C:\J\w\prod\BuildSingleReference\conan-center-index\recipes\libdeflate\all\test_package\build\Release\test_package.exe
  Building Custom Rule C:/J/w/prod/BuildSingleReference/conan-center-index/recipes/libdeflate/all/test_package/CMakeLists.txt
libdeflate/1.14 (test package): Running test()

bad bad bad

Again, migration of recipes relying on VisualStudioBuildEnvironment should be double checked. Need the same fix done in #13851

[SpaceIm]

fix here: #14028