Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coin-osi : added 0.108.7 #15262

Merged
merged 2 commits into from
Jan 30, 2023

Conversation

oleurodecision
Copy link
Contributor

@oleurodecision oleurodecision commented Jan 15, 2023

Specify library name and version: coin-iso/0.108.7

Dependency of coin-cbc/2.10.8

Linked PR : #15261


@conan-center-bot

This comment has been minimized.

@oleurodecision oleurodecision mentioned this pull request Jan 15, 2023
3 tasks
@oleurodecision oleurodecision marked this pull request as draft January 15, 2023 06:40
@oleurodecision
Copy link
Contributor Author

OK, didn't expect that (was following https://docs.conan.io/en/latest/reference/config_files/conandata.yml.html?highlight=conandata)

Need to check what it is the recommended way for managing different requirement versions

@conan-center-bot

This comment has been minimized.

@oleurodecision oleurodecision mentioned this pull request Jan 15, 2023
3 tasks
conandata 'requirements' is not allowed by conan-center hooks
@conan-center-bot

This comment has been minimized.

@oleurodecision oleurodecision marked this pull request as ready for review January 16, 2023 06:03
@oleurodecision
Copy link
Contributor Author

oleurodecision commented Jan 16, 2023

Not very pleased with the way I has to use for managing requirement versions, should be great to have some conandata.yml 'requirements' entry supported by conan-center. Would be happy to discuss and work on the (which should just be an update of HK-0030 ?)

Well, if this PR is accepted as is, I'll updated other PR using the same approach.

Btw, thanks for that amazing tool !

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 4 (518e263318c0dd6adf1eaadb7cab83181865a0b4):

  • coin-osi/0.108.6@:
    All packages built successfully! (All logs)

  • coin-osi/0.108.7@:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a uncommon case, usually we use only the latest version available in Conan Center. But this project needs a specific version, there is no problem adding a condition in the recipe. We did not pass it conandata, because it's not a normal case and it's a small recipe. There are few cases like Boost and Qt where we list library modules in yaml files, but it's an exceptional case.

@conan-center-bot conan-center-bot merged commit d276fd8 into conan-io:master Jan 30, 2023
StellaSmith pushed a commit to StellaSmith/conan-center-index that referenced this pull request Feb 2, 2023
* coin-osi : added 0.108.7

* coin-osi : requirement version management in conanfile
conandata 'requirements' is not allowed by conan-center hooks
@oleurodecision oleurodecision deleted the coin-osi/0.108.7 branch February 21, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants