-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coin-clp : added 1.17.7 #15263
coin-clp : added 1.17.7 #15263
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
OK, didn't expect that (was following https://docs.conan.io/en/latest/reference/config_files/conandata.yml.html?highlight=conandata) Need to check what it is the recommended way for managing different requirement versions |
940c7ec
to
7c5aeb2
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ff35f15
to
548b6e7
Compare
548b6e7
to
f444062
Compare
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit f444062coin-clp/1.17.6
coin-clp/1.17.7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -2,7 +2,13 @@ sources: | |||
"1.17.6": | |||
url: "https://github.com/coin-or/Clp/archive/releases/1.17.6.tar.gz" | |||
sha256: "afff465b1620cfcbb7b7c17b5d331d412039650ff471c4160c7eb24ae01284c9" | |||
"1.17.7": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, keep the newest version on top, it's easier for human reading. Not a blocker, but consider in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've searched some common rule in recipes, didn't find one, now I have it ;)
I detected other pull requests that are modifying coin-clp/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 4f0b1b4coin-clp/1.17.6
coin-clp/1.17.7
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
You need to review again :) |
Conan v1 pipeline ✔️All green in build 10 (
Conan v2 pipeline (informative, not required for merge) ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 8 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
* coin-clp : added 1.17.7 * coin-clp : requirement version management in conanfile * Update recipes/coin-clp/all/conanfile.py --------- Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Specify library name and version: coin-clp/1.17.7
Dependency of coin-cbc/2.10.8
Linked PR : #15261 #15262