Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coin-clp : added 1.17.7 #15263

Merged
merged 4 commits into from
Feb 11, 2023

Conversation

oleurodecision
Copy link
Contributor

@oleurodecision oleurodecision commented Jan 15, 2023

Specify library name and version: coin-clp/1.17.7

Dependency of coin-cbc/2.10.8

Linked PR : #15261 #15262


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@oleurodecision oleurodecision marked this pull request as draft January 15, 2023 06:41
@oleurodecision
Copy link
Contributor Author

OK, didn't expect that (was following https://docs.conan.io/en/latest/reference/config_files/conandata.yml.html?highlight=conandata)

Need to check what it is the recommended way for managing different requirement versions

@conan-center-bot

This comment has been minimized.

@oleurodecision oleurodecision mentioned this pull request Jan 15, 2023
3 tasks
@conan-center-bot

This comment has been minimized.

@oleurodecision oleurodecision marked this pull request as ready for review January 19, 2023 10:02
@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2023

Hooks produced the following warnings for commit f444062
coin-clp/1.17.6
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libOsiClp.dylib, libClp.dylib, libOsiClp.1.14.6.dylib, libClpSolver.dylib, libClpSolver.1.14.6.dylib, libOsiClp.1.dylib, libClpSolver.1.dylib, libClp.1.dylib, libClp.1.14.6.dylib
coin-clp/1.17.7
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libOsiClp.dylib, libClp.dylib, libClpSolver.dylib, libOsiClp.1.dylib, libClpSolver.1.14.7.dylib, libClpSolver.1.dylib, libOsiClp.1.14.7.dylib, libClp.1.dylib, libClp.1.14.7.dylib

uilianries
uilianries previously approved these changes Feb 7, 2023
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -2,7 +2,13 @@ sources:
"1.17.6":
url: "https://github.com/coin-or/Clp/archive/releases/1.17.6.tar.gz"
sha256: "afff465b1620cfcbb7b7c17b5d331d412039650ff471c4160c7eb24ae01284c9"
"1.17.7":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, keep the newest version on top, it's easier for human reading. Not a blocker, but consider in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've searched some common rule in recipes, didn't find one, now I have it ;)

@ghost
Copy link

ghost commented Feb 9, 2023

I detected other pull requests that are modifying coin-clp/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 4f0b1b4
coin-clp/1.17.6
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libOsiClp.dylib, libClp.dylib, libOsiClp.1.14.6.dylib, libClpSolver.dylib, libClpSolver.1.14.6.dylib, libOsiClp.1.dylib, libClpSolver.1.dylib, libClp.1.dylib, libClp.1.14.6.dylib
coin-clp/1.17.7
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libOsiClp.dylib, libClp.dylib, libClpSolver.dylib, libOsiClp.1.dylib, libClpSolver.1.14.7.dylib, libClpSolver.1.dylib, libOsiClp.1.14.7.dylib, libClp.1.dylib, libClp.1.14.7.dylib

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@prince-chrismc
Copy link
Contributor

You need to review again :)

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 10 (d56e62b1ad605abdd8bfa06590b3f6f752a24cf2):

  • coin-clp/1.17.6@:
    All packages built successfully! (All logs)

  • coin-clp/1.17.7@:
    All packages built successfully! (All logs)


Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 8 (d56e62b1ad605abdd8bfa06590b3f6f752a24cf2):

  • coin-clp/1.17.6@:
    Error running command conan export --name coin-clp --version 1.17.6 recipes/coin-clp/all/conanfile.py:

    ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-15263/recipes/coin-clp/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-15263/recipes/coin-clp/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod-v2_cci_PR-15263/recipes/coin-clp/all/conanfile.py", line 6, in <module>
        from conans import AutoToolsBuildEnvironment, tools
    ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • coin-clp/1.17.7@:
    Error running command conan export --name coin-clp --version 1.17.7 recipes/coin-clp/all/conanfile.py:

    ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-15263/recipes/coin-clp/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-15263/recipes/coin-clp/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod-v2_cci_PR-15263/recipes/coin-clp/all/conanfile.py", line 6, in <module>
        from conans import AutoToolsBuildEnvironment, tools
    ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@conan-center-bot conan-center-bot merged commit e02343a into conan-io:master Feb 11, 2023
sabelka pushed a commit to sabelka/conan-center-index that referenced this pull request Feb 12, 2023
* coin-clp : added 1.17.7

* coin-clp : requirement version management in conanfile

* Update recipes/coin-clp/all/conanfile.py

---------

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@oleurodecision oleurodecision deleted the coin-clp/1.17.7 branch March 9, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants