-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fontconfig: migrate to util-linux-libuuid #17995
Conversation
To avoid conflict with system libuuid
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi @ericLemanissier - thanks for your contribution. On the surface of this, this makes sense. However, would you able to provide more details (preferably in the PR description) about how these potential conflicts manifest when consuming this recipe? Thanks! |
@jcar87 see #17664 and #17427 (comment) |
@ericLemanissier @jwillikers @samuel-emrys We are going to be rolling this back since it's causing lots of issues with the graph conflicts |
Why not moving forward, instead of backwards? |
It's easier to fix one then try to track down all the other recipes and get PRs through on a Friday :) Hopefully that's a reasonable response :) |
If this is being rolled back, what's the way forward on system package conflicts? Ie xorg/system which brings in the util-linux-libuuid variant and conflicts with libuuid |
see converstation in conan-io#17995 (comment)
@samuel-emrys I do not see that searching the repo https://github.com/search?q=repo%3Aconan-io%2Fconan-center-index+util-linux-libuuid&type=code so I am not sure where that is being pulled in 🤔 If you can give me more imformation I'd appreciate that 🙏 We have only 16 recipes using the libuuid |
@prince-chrismc see #17427 (comment) for context. fontconfig is where libuuid is being pulled into the tree |
#17664 is where util-linux-libuuid was added. All packages currently using libuuid should migrate to util-linux-libuuid and libuuid should be deprecated |
I don't think we can migrate the 16 recipes "at once" because there are dependencies between these 16 packages, but it is true that we should all be ready to approve quickly the 16 PRs when the migration is started, to minimize the disruption (hoping that github or C3I don't let us down during the process) The conflict Sam is talking about is one that cannot be detected by conan, because it is a conflict between a system package and a conan package. |
Can we (i.e the Conan team) plan this next week so we cause users the least amount of disruption? Does that make sense? The issue is it's late at night and most have logged off so we decided to save the work for next week, a few more days will not delay other efforts -- it's bad timing for a human perspective
Could the There's no objection to this change getting rolled out but we just want to do it correctly. :) |
see converstation in #17995 (comment)
Yep this sounds reasonable to me.
Yeah this isn't a bad idea. |
To avoid conflict with system libuuid
To avoid conflict with system libuuid
To avoid conflict with system libuuid
Specify library name and version: fontconfig/*
see #17664 and #17427 (comment) for motivation and rationale