[xorg] Model uuid dependency #18570
[xorg] Model uuid dependency #18570
Conversation
* Prevent erroneous linkage against an incompatible uuid interface when libuuid exists in the dependency tree with xorg by adding a dependency on the util-linux-libuuid conan package. This will ensure an error is raised if libuuid is in the same dependency graph as xorg.
|
🤖 Beep Boop! This pull request is making changes to 'recipes/xorg//'. 👋 @Hopobcn you might be interested. 😉 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@RubenRBS is this being considered at all? If not, I'll close this out - trying to minimise the number of plates I've got spinning for CCI contributions. |
ghost
mentioned this pull request
|
I think this is relevant anymore thanks to |
|
@valgur actually not entirely. This is about modelling the dependency in xorg itself so that it's enforced as part of the dependency tree, so that we get meaningful errors if any package in the tree uses a different libuuid. We've solved this problem for cci packages, but not anything outside this curated ecosystem |
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 (
|
| # This is necessary to prevent other packages in the dependency tree from using the "libuuid" recipe | ||
| # which conflicts with the system installation of `util-linux-libuuid` that `xorg` installs. See #17427, #17485 | ||
| # This has no functional bearing on xorg, however, as it links against the system library installed in util-linux-libs | ||
| self.requires("util-linux-libuuid/2.39") |
There was a problem hiding this comment.
| self.requires("util-linux-libuuid/2.39") | |
| self.requires("util-linux-libuuid/[*]") |
Could it be set to accept any version, maybe, to avoid the need for version bumps? (the pattern works, I tested it locally)
There was a problem hiding this comment.
I'm not opposed to this provided it gets maintainer buy in. @uilianries @RubenRBS thoughts?
There was a problem hiding this comment.
Please check: https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/dependencies.md#version-ranges
Conan maintainers may introduce this for other dependencies over time. Outside of the cases outlined above, version ranges are not allowed in ConanCenter recipes.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
Prevent erroneous linkage against an incompatible uuid interface when libuuid exists in the dependency tree with xorg by adding a dependency on the util-linux-libuuid conan package. This will ensure an error is raised if libuuid is in the same dependency graph as xorg.
This has caused issues in #17427, #17485 and this change is based on the suggestion by @prince-chrismc in #17995 (comment). Read these linked issues for context.