Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libjpeg-turbo: add version 3.0.0 #18417

Merged
merged 3 commits into from
Aug 3, 2023
Merged

libjpeg-turbo: add version 3.0.0 #18417

merged 3 commits into from
Aug 3, 2023

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Jul 8, 2023

Specify library name and version: libjpeg-turbo/3.0.0

@valgur valgur mentioned this pull request Jul 8, 2023
Merged
3 tasks
@prince-chrismc prince-chrismc mentioned this pull request Jul 8, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
valgur
valgur approved these changes Jul 8, 2023
View reviewed changes
recipes/libjpeg-turbo/all/conanfile.py Outdated
@@ -49,29 +49,32 @@ class LibjpegTurboConan(ConanFile):
def config_options(self):
if self.settings.os == "Windows":
del self.options.fPIC
if Version(self.version) >= Version("3.0.0"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if Version(self.version) >= Version("3.0.0"):
if Version(self.version) >= "3.0.0":

A tiny cosmetic suggestion.

recipes/libjpeg-turbo/all/conanfile.py Outdated
tc.variables["WITH_TURBOJPEG"] = self.options.get_safe("turbojpeg", False)
tc.variables["WITH_JAVA"] = self.options.get_safe("java", False)
tc.variables["WITH_12BIT"] = self.options.enable12bit
if Version(self.version) < Version("3.0.0"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if Version(self.version) < Version("3.0.0"):
if Version(self.version) < "3.0.0":

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur mentioned this pull request Jul 9, 2023
Closed
3 tasks
@mayeut
Copy link
Contributor Author

mayeut commented Jul 11, 2023 •
edited
Loading

old versions still in use:

conan-center-index % grep -r 'libjpeg-turbo/' recipes | grep -v 'recipes/libjpeg-turbo' | grep -v '/2.1.5' | sort
recipes/diligent-tools/all/conanfile.py:   self.requires("libjpeg-turbo/2.1.4")
recipes/gdal/post_3.5.0/conanfile.py:      self.requires("libjpeg-turbo/2.1.4")
recipes/gdal/pre_3.5.0/conanfile.py:       self.requires("libjpeg-turbo/2.1.4")
recipes/gst-plugins-base/all/conanfile.py: self.requires("libjpeg-turbo/2.1.2")
recipes/imagemagick/all/conanfile.py:      self.requires("libjpeg-turbo/2.1.0")
recipes/libfreenect2/all/conanfile.py:     self.requires("libjpeg-turbo/2.1.1")

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@jcar87 jcar87 self-assigned this Aug 2, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (cae9c3ef1e0bc8801d63188e15c74406935d592e):

  • libjpeg-turbo/2.1.5@:
    All packages built successfully! (All logs)

  • libjpeg-turbo/2.0.6@:
    All packages built successfully! (All logs)

  • libjpeg-turbo/3.0.0@:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 2 (cae9c3ef1e0bc8801d63188e15c74406935d592e):

  • libjpeg-turbo/2.0.6@:
    All packages built successfully! (All logs)

  • libjpeg-turbo/2.1.5@:
    All packages built successfully! (All logs)

  • libjpeg-turbo/3.0.0@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 243374c into conan-io:master Aug 3, 2023
@mayeut mayeut deleted the libjpeg-turbo-add-3.0.0 branch August 3, 2023 11:20
klausholstjacobsen pushed a commit to klausholstjacobsen/conan-center-index that referenced this pull request Aug 5, 2023
@mayeut @klausholstjacobsen
(conan-io#18417) libjpeg-turbo: add version 3.0.0
ed752a3 
* libjpeg-turbo: add version 3.0.0

* simplify version comparison

* libjpeg-turbo: remove older versions

per https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/sources_and_patches.md#removing-old-versions
klausholstjacobsen pushed a commit to klausholstjacobsen/conan-center-index that referenced this pull request Aug 28, 2023
@mayeut @klausholstjacobsen
(conan-io#18417) libjpeg-turbo: add version 3.0.0
7be7cd8 
* libjpeg-turbo: add version 3.0.0

* simplify version comparison

* libjpeg-turbo: remove older versions

per https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/sources_and_patches.md#removing-old-versions
ericLemanissier pushed a commit to ericLemanissier/conan-center-index that referenced this pull request Sep 15, 2023
@mayeut @ericLemanissier
(conan-io#18417) libjpeg-turbo: add version 3.0.0
ca8a981 
* libjpeg-turbo: add version 3.0.0

* simplify version comparison

* libjpeg-turbo: remove older versions

per https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/sources_and_patches.md#removing-old-versions
immortalsalomon pushed a commit to immortalsalomon/conan-center-index that referenced this pull request Mar 18, 2024
@mayeut
(conan-io#18417) libjpeg-turbo: add version 3.0.0
e4c35a1 
* libjpeg-turbo: add version 3.0.0

* simplify version comparison

* libjpeg-turbo: remove older versions

per https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/sources_and_patches.md#removing-old-versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@jcar87 jcar87 jcar87 approved these changes

@valgur valgur valgur approved these changes

@toge toge toge approved these changes

Assignees

@jcar87 jcar87

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mayeut @conan-center-bot @toge @valgur @jcar87 @uilianries