Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harfbuzz: add with_coretext option #20870

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Nov 1, 2023

Specify library name and version: harfbuzz/all

Before #13942 (switch from cmake to meson), CoreText was always enabled on macOS.
Meson is the official way to build and has CoreText disabled by default. The CMake build had a default of enabling CoreText on macOS.

This PR adds the option to enable/disable CoreText with the default being to enable it (which differs from the official default).

Why enabled by default: the pango recipe being ported to v2 in multiple PRs requires harfbuzz to be built with CoreText enabled (c.f. the v2 build logs in #20795 (comment)).
I couldn't get pango to build on macOS by disabling CoreText (by patching pango). While this might be doable, I won't have the time to investigate this option and I'm thus proposing to re-enable CoreText as a default on macOS.


Copy link
Contributor

@jwillikers jwillikers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed explanation!

@conan-center-bot

This comment has been minimized.

@uilianries uilianries self-assigned this Nov 6, 2023
@uilianries
Copy link
Member

@mayeut Thank you for bringing this topic in this PR. It seems be a blocker indeed, but have tried to discuss with the upstream first? Maybe coretext could be enabled by default in Harfbuzz project again.

@ghost
Copy link

ghost commented Nov 13, 2023

I detected other pull requests that are modifying harfbuzz/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Nov 13, 2023
3 tasks
@ghost ghost mentioned this pull request Nov 19, 2023
3 tasks
@mayeut
Copy link
Contributor Author

mayeut commented Nov 19, 2023

@uilianries, "Maybe coretext could be enabled by default in Harfbuzz project again.", it never has been enabled by default officially, it was only enabled by default in the contrib cmake build that was used before.

@valgur
Copy link
Contributor

valgur commented Nov 28, 2023

@uilianries Pinging for a review, as the issue fixed by this PR is a blocker for pango and in turn a number other packages relying on GTK components.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Checked https://github.com/harfbuzz/harfbuzz/blob/main/CMakeLists.txt and this change makes sense.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (65846728e61d44159b870a27cea664148001e7a6):

  • harfbuzz/8.3.0:
    All packages built successfully! (All logs)

  • harfbuzz/8.2.1:
    All packages built successfully! (All logs)

  • harfbuzz/8.0.1:
    All packages built successfully! (All logs)

  • harfbuzz/8.1.1:
    All packages built successfully! (All logs)

  • harfbuzz/8.2.2:
    All packages built successfully! (All logs)

  • harfbuzz/6.0.0:
    All packages built successfully! (All logs)

  • harfbuzz/7.3.0:
    All packages built successfully! (All logs)

  • harfbuzz/5.1.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (65846728e61d44159b870a27cea664148001e7a6):

  • harfbuzz/8.2.2:
    All packages built successfully! (All logs)

  • harfbuzz/8.1.1:
    All packages built successfully! (All logs)

  • harfbuzz/8.0.1:
    All packages built successfully! (All logs)

  • harfbuzz/8.2.1:
    All packages built successfully! (All logs)

  • harfbuzz/7.3.0:
    All packages built successfully! (All logs)

  • harfbuzz/6.0.0:
    All packages built successfully! (All logs)

  • harfbuzz/5.1.0:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 3d66a5e into conan-io:master Dec 1, 2023
@SpaceIm
Copy link
Contributor

SpaceIm commented Dec 1, 2023

And shouldn't you update package_info() in order to avoid to add CoreText to cpp_info.frameworks when with_coretext is disabled?

@mayeut mayeut deleted the harfbuzz-with_coretext branch December 3, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants