Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

harfbuzz: fix frameworks used in package_info #21553

Merged
merged 2 commits into from
Dec 3, 2023
Merged

harfbuzz: fix frameworks used in package_info #21553

merged 2 commits into from
Dec 3, 2023

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Dec 3, 2023

Specify library name and version: harfbuzz/all

This addresses the comment #20870 (comment) by @SpaceIm

Apple frameworks are only used when with_coretext=True.

On macOS, harfbuzz links against the ApplicationServices framework.
For other Apple OS, it links against CoreFoundation, CoreGraphics & CoreText frameworks.

mayeut added 2 commits December 3, 2023 13:42
@mayeut
harfbuzz: fix frameworks used in package_info
2858cca 
Apple frameworks are only used when `with_coretext=True`.

On macOS, harfbuzz links against the ApplicationServices framework.
For other OS, it links against CoreFoundation, CoreGraphics & CoreText frameworks.
@mayeut
Merge branch 'master' into harfbuzz-coretext-fix
aae3918
@prince-chrismc prince-chrismc mentioned this pull request Dec 3, 2023
Open
AbrilRBS
AbrilRBS approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking the time to fix this one :)

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (aae39182bc4cd07163da29881d38c11cf621d7b0):

  • harfbuzz/7.3.0:
    All packages built successfully! (All logs)

  • harfbuzz/6.0.0:
    All packages built successfully! (All logs)

  • harfbuzz/8.3.0:
    All packages built successfully! (All logs)

  • harfbuzz/8.0.1:
    All packages built successfully! (All logs)

  • harfbuzz/8.1.1:
    All packages built successfully! (All logs)

  • harfbuzz/5.1.0:
    All packages built successfully! (All logs)

  • harfbuzz/8.2.2:
    All packages built successfully! (All logs)

  • harfbuzz/8.2.1:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (aae39182bc4cd07163da29881d38c11cf621d7b0):

  • harfbuzz/8.3.0:
    All packages built successfully! (All logs)

  • harfbuzz/8.2.2:
    All packages built successfully! (All logs)

  • harfbuzz/8.2.1:
    All packages built successfully! (All logs)

  • harfbuzz/8.0.1:
    All packages built successfully! (All logs)

  • harfbuzz/8.1.1:
    All packages built successfully! (All logs)

  • harfbuzz/6.0.0:
    All packages built successfully! (All logs)

  • harfbuzz/5.1.0:
    All packages built successfully! (All logs)

  • harfbuzz/7.3.0:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit de91926 into conan-io:master Dec 3, 2023
5 checks passed
@mayeut mayeut deleted the harfbuzz-coretext-fix branch December 12, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@SpaceIm SpaceIm SpaceIm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mayeut @conan-center-bot @AbrilRBS @SpaceIm