Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poppler: migrate to Conan v2 #21135

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open

poppler: migrate to Conan v2 #21135

wants to merge 42 commits into from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Nov 14, 2023 •
edited
Loading

Worked locally with all options enabled.

@valgur valgur mentioned this pull request Nov 14, 2023
Open
@ghost ghost mentioned this pull request Nov 14, 2023
Closed
@prince-chrismc prince-chrismc mentioned this pull request Nov 14, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@AbrilRBS AbrilRBS mentioned this pull request Nov 16, 2023
Closed
@AbrilRBS AbrilRBS self-assigned this Nov 16, 2023
@AbrilRBS
Copy link
Member

Feel free to remove 21.07.0, after looking at it with @uilianries it's going to be faster than the alternative of trying to properly support it :)
Just remember to remove the toolchain variables that would no longer be needed after that!

@valgur valgur force-pushed the migrate/poppler branch 2 times, most recently from 87039e6 to 7ac49ae Compare November 16, 2023 14:16
@conan-center-bot

This comment has been minimized.

Sign in to view
@h-2
Copy link

h-2 commented Nov 20, 2023

Having this package in Conan2 is one of our main blockers, so work on this is very much appreciated!

Btw, does the package also offer the details headers found in operating system packages like libpoppler-private-dev on Ubuntu?
Thanks!

@uilianries
Copy link
Member

@h-2 I didn't check but I would say yes. Most of Conan packages are equivalent of -dev on Ubuntu.

@h-2
Copy link

h-2 commented Nov 22, 2023

@h-2 I didn't check but I would say yes. Most of Conan packages are equivalent of -dev on Ubuntu.

Yeah, but the normal ubuntu dev package is libpoppler-dev. The one I asked for is libpoppler-private-dev which includes things not normally included. Maybe that would be an extra component?

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@mayeut mayeut mentioned this pull request Dec 3, 2023
Merged
3 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 7 (aa6493692c85759ded24d9599c0edd469fc05912):

  • poppler/24.05.0:
    CI failed to create some packages (All logs)

    Logs for packageID 2b5bb8bdb3e8fe5ec77ac388dc3c7b43b82896c7: 
    [settings]
arch=x86_64
build_type=Debug
compiler=Visual Studio
compiler.runtime=MDd
compiler.version=16
os=Windows
[options]
poppler:shared=True

    [...]
   poppler source folder or specify the location of your
   checkout with -DTESTDATADIR=/path/to/checkoutdir/test.
    


Building Poppler with support for:
  font configuration:   generic
  use boost (Splash):   yes
  cairo output:         no
  qt5 wrapper:          no
  qt6 wrapper:          no
  glib wrapper:         no
    introspection:      no
    gtk-doc:            no
  cpp wrapper:          yes
  use libjpeg:          yes
  use libpng:           yes
  use libtiff:          yes
  use zlib uncompress:  yes
  use nss3:             no
  use gpg:              no
    default signature backend:          None
  use curl:             no
  use libopenjpeg2:     yes
  use lcms2:            yes
  command line utils:   no
  fuzz target:          no
  test data dir:        C:/J/workspace/prod-v1/bsr/92164/ebeaa/.conan/data/poppler/24.05.0/_/_/build/2b5bb8bdb3e8fe5ec77ac388dc3c7b43b82896c7/src/../test
Warning: Using zlib is not totally safe
CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_POLICY_DEFAULT_CMP0091


WARN: *** Conan 1 is legacy and on a deprecation path ***
WARN: *** Please upgrade to Conan 2 ***
WARN: freetype/2.13.2: requirement libpng/[>=1.6 <2] overridden by poppler/24.05.0 to libpng/1.6.43 
WARN: freetype/2.13.2: requirement zlib/[>=1.2.10 <2] overridden by poppler/24.05.0 to zlib/1.3.1 
WARN: libpng/1.6.43: requirement zlib/[>=1.2.11 <2] overridden by freetype/2.13.2 to zlib/1.3.1 
WARN: libtiff/4.6.0: requirement zlib/[>=1.2.11 <2] overridden by poppler/24.05.0 to zlib/1.3.1 
WARN: boost/1.85.0: requirement zlib/[>=1.2.11 <2] overridden by poppler/24.05.0 to zlib/1.3.1 
boost/1.85.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
poppler/24.05.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
poppler/24.05.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
poppler/24.05.0: ERROR: Package '2b5bb8bdb3e8fe5ec77ac388dc3c7b43b82896c7' build failed
poppler/24.05.0: WARN: Build folder C:\J\workspace\prod-v1\bsr\92164\ebeaa\.conan\data\poppler\24.05.0\_\_\build\2b5bb8bdb3e8fe5ec77ac388dc3c7b43b82896c7\build
ERROR: poppler/24.05.0: Error in build() method, line 277
	cmake.build()
	ConanException: Error 1 while executing cmake --build "C:\J\workspace\prod-v1\bsr\92164\ebeaa\.conan\data\poppler\24.05.0\_\_\build\2b5bb8bdb3e8fe5ec77ac388dc3c7b43b82896c7\build" --config Debug

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 7 (aa6493692c85759ded24d9599c0edd469fc05912):

  • poppler/24.05.0:
    CI failed to create some packages (All logs)

    Logs for packageID 06b653581942b7a7e154926efc9d6cf7a2764147: 
    [settings]
arch=x86_64
build_type=Release
compiler=msvc
compiler.cppstd=17
compiler.runtime=dynamic
compiler.runtime_type=Release
compiler.version=192
os=Windows
[options]
*/*:shared=True

    [...]
          ] (compiling source file C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\src\poppler\BBoxOutputDev.cc)
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\memory(3198): message : see reference to function template instantiation 'void std::default_delete<X509CertificateInfo>::operator ()(_Ty *) noexcept const' being compiled [C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\build\poppler.vcxproj]
          with
          [
              _Ty=X509CertificateInfo
          ] (compiling source file C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\src\poppler\BBoxOutputDev.cc)
  SplashFTFontFile.cc
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\memory(3125): message : see reference to class template instantiation 'std::default_delete<X509CertificateInfo>' being compiled (compiling source file C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\src\poppler\BBoxOutputDev.cc) [C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\build\poppler.vcxproj]
C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\src\poppler\SignatureInfo.h(87): message : see reference to class template instantiation 'std::unique_ptr<X509CertificateInfo,std::default_delete<X509CertificateInfo>>' being compiled (compiling source file C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\src\poppler\BBoxOutputDev.cc) [C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\build\poppler.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\memory(3089,25): error C2338: can't delete an incomplete type (compiling source file C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\src\poppler\BBoxOutputDev.cc) [C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\build\poppler.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\memory(3090,1): warning C4150: deletion of pointer to incomplete type 'X509CertificateInfo'; no destructor called (compiling source file C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\src\poppler\BBoxOutputDev.cc) [C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\build\poppler.vcxproj]
C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\src\poppler\Form.h(59): message : see declaration of 'X509CertificateInfo' (compiling source file C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\src\poppler\BBoxOutputDev.cc) [C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\build\poppler.vcxproj]
  SplashFont.cc
  SplashFontEngine.cc
C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\src\poppler\SplashOutputDev.cc(2624,34): warning C4805: '^': unsafe mix of type 'unsigned char' and type 'bool' in operation [C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\build\poppler.vcxproj]
  SplashFontFile.cc
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\memory(3089,1): error C2027: use of undefined type 'X509CertificateInfo' (compiling source file C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\src\poppler\SplashOutputDev.cc) [C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\build\poppler.vcxproj]
C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\src\poppler\Form.h(59): message : see declaration of 'X509CertificateInfo' (compiling source file C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\src\poppler\SplashOutputDev.cc) [C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\build\poppler.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\memory(3088): message : while compiling class template member function 'void std::default_delete<X509CertificateInfo>::operator ()(_Ty *) noexcept const' [C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\build\poppler.vcxproj]
          with
          [
              _Ty=X509CertificateInfo
          ] (compiling source file C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\src\poppler\SplashOutputDev.cc)
  SplashFontFileID.cc
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\memory(3198): message : see reference to function template instantiation 'void std::default_delete<X509CertificateInfo>::operator ()(_Ty *) noexcept const' being compiled [C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\build\poppler.vcxproj]
          with
          [
              _Ty=X509CertificateInfo
          ] (compiling source file C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\src\poppler\SplashOutputDev.cc)
  SplashPath.cc
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\memory(3125): message : see reference to class template instantiation 'std::default_delete<X509CertificateInfo>' being compiled (compiling source file C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\src\poppler\SplashOutputDev.cc) [C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\build\poppler.vcxproj]
  SplashPattern.cc
C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\src\poppler\SignatureInfo.h(87): message : see reference to class template instantiation 'std::unique_ptr<X509CertificateInfo,std::default_delete<X509CertificateInfo>>' being compiled (compiling source file C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\src\poppler\SplashOutputDev.cc) [C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\build\poppler.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\memory(3089,25): error C2338: can't delete an incomplete type (compiling source file C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\src\poppler\SplashOutputDev.cc) [C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\build\poppler.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\memory(3090,1): warning C4150: deletion of pointer to incomplete type 'X509CertificateInfo'; no destructor called (compiling source file C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\src\poppler\SplashOutputDev.cc) [C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\build\poppler.vcxproj]
C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\src\poppler\Form.h(59): message : see declaration of 'X509CertificateInfo' (compiling source file C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\src\poppler\SplashOutputDev.cc) [C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\build\poppler.vcxproj]
  SplashScreen.cc
  SplashState.cc
  SplashXPath.cc
  SplashXPathScanner.cc
  DCTStream.cc
  FlateStream.cc
  JPEG2000Stream.cc

poppler/24.05.0: ERROR: 
Package '06b653581942b7a7e154926efc9d6cf7a2764147' build failed
poppler/24.05.0: WARN: Build folder C:\J\workspace\prod-v2\bsr@2\82732\eafdf\p\b\poppl934aebcbe0945\b\build
ERROR: poppler/24.05.0: Error in build() method, line 277
	cmake.build()
	ConanException: Error 1 while executing

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@perseoGI perseoGI mentioned this pull request Sep 23, 2024
Open
@valgur
Merge remote-tracking branch 'upstream/master' into migrate/poppler
44a2cf9
@valgur
Use pkgconf/[>=2.2 <3]
bd2a109
@valgur
Use a version range for Qt dependencies
c93dac0
@valgur
List only the C component of libtiff under requires
1bdff3f
@valgur
poppler: remove a broken version check
c5599f3 
CMake Error at CMakeLists.txt:151 (find_package):
  Could not find a configuration file for package "FREETYPE" that is
  compatible with requested version "2.10".

  The following configuration files were considered but not accepted:

    build/Release/generators/FREETYPEConfig.cmake, version: 26.1.20
@valgur
poppler: fix with_qt=True cross-compilation
19b812f
@valgur
poppler: drop test_v1_package
cb8dd51
@AbrilRBS AbrilRBS removed their assignment Dec 3, 2024
@user4223 user4223 mentioned this pull request Jan 4, 2025
Draft
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 7, 2025
@valgur
Copy link
Contributor Author

valgur commented Jan 7, 2025

.

@github-actions github-actions bot removed the stale label Jan 8, 2025
@user4223
Copy link

@valgur thanks for your work on this. for one of my projects, this package is the last one to be able to migrate to conan 2, so i am quite interested to get this pr merged. locally, i was able to create the package on linux and macos with very few modifications only. i could pr this changes when desired.
i am really unsure what else has to be done to get this merged, excepting a review. because the default builds for different platforms are one point. but honestly, there are a lot of recipe options and to get them working or failing with proper message in any valid combination could be really time consuming and/or one would need to have a good understanding of library internals.
anyway, i would really appreciate progress with this recipe, when i can contribute somehow, i would try.
thanks

@valgur
Copy link
Contributor Author

valgur commented Jan 11, 2025

@user4223 Feel free to open a PR at https://github.com/valgur/conan-center-index.

The Poppler recipe had some pretty difficult linker errors in the CI, which seemed to be caused by the order of the linked libraries. There might even be a dependency cycle somewhere in the deps.

Anyway, it's difficult to move forward with this PR if I can't use the CI to catch the failing configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@valgur @conan-center-bot @AbrilRBS @h-2 @uilianries @user4223