-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ffmpeg: added openvino support #21151
base: master
Are you sure you want to change the base?
Conversation
🤖 Beep Boop! This pull request is making changes to 'recipes/ffmpeg//'. 👋 @MartinDelille you might be interested. 😉 |
e942540
to
12d398e
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
recipes/ffmpeg/all/conanfile.py
Outdated
@@ -450,6 +457,7 @@ def opt_append_disable_if_set(args, what, v): | |||
opt_enable_disable("iconv", self.options.with_libiconv), | |||
opt_enable_disable("libopenjpeg", self.options.with_openjpeg), | |||
opt_enable_disable("libopenh264", self.options.with_openh264), | |||
opt_enable_disable("libopenvino", self.options.with_openvino), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In old versions or when avfilter is True, this breaks because the option has been deleted. Maybe using get_safe
is enough?
12d398e
to
0f24d33
Compare
This comment has been minimized.
This comment has been minimized.
Hi @ilya-lavrenov ! For my personal culture, what do allow openvino and ffmpeg ? |
https://www.phoronix.com/news/FFmpeg-OpenVINO-GPU Shortly, FFMPEG has AI blocks in avfilter, which can be speeded up with OpenVINO. |
What does AI blocks in avfilter is about ? |
@@ -125,6 +126,7 @@ class FFMpegConan(ConanFile): | |||
"with_freetype": True, | |||
"with_openjpeg": True, | |||
"with_openh264": True, | |||
"with_openvino": True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's a good idea to enable openvino in ffmpeg by default:
- there are already too many dependencies enabled in ffmpeg recipe, and it will leak to other recipes like opencv.
- openvino is a C++ library while ffmpeg is a C library
- openvino recipe has too many common cases of ConanInvalidConfiguration (build_type=Debug, clang with libc++, only recent compilers while ffmpeg supports many compilers), it will leak to downstream recipes, not good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was done for testing purposes.
I agree that adding heavy dependency like OpenVINO should be done with False
by default
This comment has been minimized.
This comment has been minimized.
084e4e3
to
bdedd6b
Compare
This comment has been minimized.
This comment has been minimized.
bdedd6b
to
7b0630b
Compare
This comment has been minimized.
This comment has been minimized.
7b0630b
to
702b0b7
Compare
This comment has been minimized.
This comment has been minimized.
I just updated this branch to follow the hotfix in spdlog in master branch. |
This comment has been minimized.
This comment has been minimized.
4836712
to
0d25680
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ❌Failure in build 2 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping See details:Failure in build 2 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
… into ffmpeg-openvino
… into ffmpeg-openvino
Hello @ilya-lavrenov! Thank you for submitting OpenVino support in FFMpeg. As you can see, the FFMpeg is not able to find openvino: https://c3i.jfrog.io/c3i/misc-v2/logs/pr/21151/2-linux-gcc/ffmpeg/6.1//997490e522ee4e58468e21e3575ee58ef920db58-build.txt
I found similar reports like openvinotoolkit/openvino#11502 (comment) and https://patchwork.ffmpeg.org/project/ffmpeg/patch/PH7PR11MB5887027AF6937DA80DB24F7EDAE29@PH7PR11MB5887.namprd11.prod.outlook.com/ where people had problems to find OpenVino too. The current configure script in FFMpeg looks be expecting an older version of OpenVino: https://git.ffmpeg.org/gitweb/ffmpeg.git/blob/refs/heads/release/6.1:/configure#l6783
I know some libraries and headers changed over OpenVino releases, so Regards. |
Following the current state, is not possible to add OpenVino in FFMpeg without a workaround. The ffmpeg uses pkg-config to find openvino package and execute a test to validate it: https://git.ffmpeg.org/gitweb/ffmpeg.git/blob/refs/heads/release/6.1:/configure#l6783
That test fails, because the PkgConfigDeps generated, contains an absolute path to a library, returning it with the prefix
It requires further investigation over OpenVino, if this is something to be fixed in the recipe, or the I opened an issue to ConanCenterIndex with more details: #24795 |
Specify library name and version: lib/1.0