-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ffmpeg: add v6.1.1, drop old versions #22195
Conversation
🤖 Beep Boop! This pull request is making changes to 'recipes/ffmpeg//'. 👋 @MartinDelille you might be interested. 😉 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit ca0dd5fffmpeg/6.1.1@#da706d2f63ba9e9072024bfca8aa53ea
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit a4db9e7ffmpeg/6.1.1@#151917482d851ddee0b230f5491a77e3
ffmpeg/6.0@#8eb86652d8434aab63e7f82b969f344e
ffmpeg/5.0@#a7d143bb77c1ceba3633397bde17def2
ffmpeg/6.1@#a56200c86ce7e20b2924aa0d5d98965e
ffmpeg/6.0.1@#fbac9cc8026a1270407eaf7c4152fe87
ffmpeg/4.4.3@#722b8fc3e0658a814d828800809a9efc
ffmpeg/4.4@#6c0ac1da7d6b950b6178a40736d754b1
ffmpeg/4.4.4@#56f520025bc950fafe2b99a3fe050402
ffmpeg/5.1.3@#2052e01e0dee5a4540c7760c0a6929fd
ffmpeg/4.2.1@#6f882983eeb382ccc97598fe07acb8fd
ffmpeg/5.0.3@#f7483a9440e87428a123222180704a97
ffmpeg/5.1@#1bcf8a53fc28985b4baf662439d49535
ffmpeg/4.3.2@#3418a6fcd5c651431c9e3880e71d87e8
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 8 (
|
Hooks produced the following warnings for commit 2a6a5c4ffmpeg/6.1@#86301ee90b1c2076eb77a4d4737629cd
ffmpeg/6.1.1@#63f5ef76dd8601954eb61e75f6279c71
ffmpeg/5.1.3@#c07249bf355da7bf89959e2903738102
ffmpeg/6.0.1@#408b53806a19043dfcb8946fa98e8f9c
ffmpeg/5.0.3@#11199642a708bc44ec7379579dc52398
ffmpeg/4.4.4@#283f5c55fb44e1566af748747401a50e
|
if conan_version.major == 1 and is_msvc(self) and self.options.shared: | ||
# Linking fails with "Argument list too long" for some reason on Conan v1 | ||
raise ConanInvalidConfiguration("MSVC shared build is not supported for Conan v1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused. It works fine with previous versions but not for 6.1.1, but this PR now prevents shared msvc with conan v1 for these versions also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It actually fails for all versions - I tested with disabling it just for v6.1.1, but it did not help and I force-pushed over it (sorry about that): https://github.com/conan-io/conan-center-index/compare/a4db9e764789ae8bca3f91b24d7e49e5dae2a276..395f7f6c00511abb9a88d2182d2c2e18959cef1c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shared was building fine in this pass: #22195 (comment)
# Fix for mslink: Argument list too long | ||
short_paths = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did it fix anything in the end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it didn't.
Also cleaned up package_info() a bit.