[sdl_image] Fix static sdl_image with shared sdl

[Ahajha]

Specify library name and version: sdl_image/2.6.3

Resolves #22532

This only affects 2.6.3, neither 2.0.5 nor the upcoming 2.8.x is affected.

The issue was that sdl_image's CMake would try to read from ${SDL2_INCLUDE_DIR}/SDL_version.h, where the variable was a list, so it failed. The only thing this ultimately was used for was to get the version as a string, which Conan already provides as a variable directly.

This seems to also be bitten by #22485.
Xorg is used by pulseaudio and xcbcommon, which both specify xorg components, but don't have -Wl,--as-needed in their build process. Should be two simple PRs to get those fixed.

---

• I've read the contributing guidelines.
• I've used a recent Conan client version close to the currently deployed.
• I've tried at least one configuration locally with the conan-center hook activated.

[jcar87]

(see comments)

[Ahajha]

@jcar87 What comments? Unless you're referring to @valgur's comment?

[jcar87]

@jcar87 What comments? Unless you're referring to @valgur's comment?

oops sorry! my comments regarding how --as-needed has been the default in most Linux distros for years (or should be!) - so it's surprising that it's needed (pun intended) at all - would like to investigate in case that's an actual issue with our gcc docker images

Edit: oh, apologies I didn't see the referenced issue here #22485

Reading that thread, I think it all points to our gcc/Docker images not passing this correctly - is this still a problem right now? that is, does the recipe not build on our CI without passing this --as-needed here?

[jcar87]

Continuing the discussion here: #22485 - really well diagnosed :D

As for this PR, does adding --as-needed fix a CI issue that prevents this PR from being merged? If that's the case let me know, otherwise I would suggest removing that line, as by all accounts the issue seems to be somewhere ese

[Ahajha]

I will check - I don't think it's entirely necessary at this point (there's been some changes to the xorg recipe since the issue arose). I will try removing it and see what happens.

[conan-center-bot]

Conan v1 pipeline ✔️

All green in build 1 (1a4ea53b4595aae8d79eca62a411484b074812c0):

• sdl_image/2.6.3:
  All packages built successfully! (All logs)

• sdl_image/2.0.5:
  All packages built successfully! (All logs)

---

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (1a4ea53b4595aae8d79eca62a411484b074812c0):

• sdl_image/2.6.3:
  All packages built successfully! (All logs)

• sdl_image/2.0.5:
  All packages built successfully! (All logs)

Clarified

[Ahajha]

@jcar87 Seems like it works, perhaps it would be worth checking if the resulting binaries are still linking to all the extra xorg libraries. Maybe the issue still exists, just it doesn't actually cause a problem since all the requisite libraries are there now.

[jcar87]

See my comment in #22532 (comment) -
static sdl_image and shared SDL fails because when SDL sdl_image is being built as static, it expects the SDL2::SDL2-static target to be satisfied by find_package(SDL2) - which is not the case when sdl is shared. we can fix this in sdl image by creating an alias (without a patch) in a single line, such that SDL2::SDL2-static is an alias to SDL2::SDL2, however this seems off - I'd be more inclined to mark this as an unsupported/invalid configuration in the validate() method - or to report this upstream first.