-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump sdl_image dependencies #23218
base: master
Are you sure you want to change the base?
bump sdl_image dependencies #23218
Conversation
This comment has been minimized.
This comment has been minimized.
@@ -96,17 +96,17 @@ def layout(self): | |||
|
|||
def requirements(self): | |||
# Headers are exposed https://github.com/conan-io/conan-center-index/pull/16167#issuecomment-1508347351 | |||
self.requires("sdl/2.28.3", transitive_headers=True) | |||
self.requires("sdl/2.28.5", transitive_headers=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be better if we could use the latest sdl on ConanCenter, which is the 2.30.1? So the latest of sdl_image
doesn't conflict with the latest of sdl
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, responding to myself, and checking other recipes in ConanCenter, the other recipes in ConanCenter depends on 2.28, so this cannot be done and would require some coordination, please be patience, this might take some time. We are trying to improve the CI to be able to do these changes more streamlined, but this is a big effort.
if self.options.with_libwebp: | ||
self.requires("libwebp/1.3.2") | ||
if self.options.get_safe("with_avif"): | ||
self.requires("libavif/1.0.1") | ||
self.requires("libavif/1.0.4") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good
🚦 Thank for your Bump dependencies PR. The build service will be triggered soon by a Conan team member. |
No description provided.