Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc : add version 1.64.2 #23085

Closed
wants to merge 1 commit into from

Conversation

sophieeihpos
Copy link
Contributor

@sophieeihpos sophieeihpos commented Mar 13, 2024

grpc/1.64.2

fixes #23084

© 2024 Morgan Stanley.
THIS SOFTWARE IS CONTRIBUTED SUBJECT TO THE TERMS OF THE Conan-io project Contributor License Agreement.
THIS SOFTWARE IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS.

@CLAassistant
Copy link

CLAassistant commented Mar 13, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

🤖 Beep Boop! This pull request is making changes to 'recipes/protobuf//'.

👋 @Hopobcn you might be interested. 😉

@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this Mar 13, 2024
@AbrilRBS
Copy link
Member

Hi @sophieeihpos thanks a lot for taking the time to contribute to Conan Center

Unfortunately you'll need to split the PR in two, as right now only 1 recipe can be changed per PR :)

@sophieeihpos
Copy link
Contributor Author

Thanks @RubenRBS I created a separate PR for protobuf #23095

@sophieeihpos sophieeihpos changed the title grpc : add version 1.55.0 ; protobuf : add version 3.22.3 grpc : add version 1.55.0 Mar 14, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@sophieeihpos sophieeihpos changed the title grpc : add version 1.55.0 grpc : add version 1.64.2 Jun 11, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added the Version conflict There is a version conflict when solving the dependencies graph label Jun 13, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot removed the Version conflict There is a version conflict when solving the dependencies graph label Jun 13, 2024
@conan-center-bot

This comment has been minimized.

@sophieeihpos sophieeihpos force-pushed the grpc_add_1.55.0 branch 2 times, most recently from 804b353 to 4a41cd9 Compare June 14, 2024 12:39
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@sophieeihpos sophieeihpos marked this pull request as ready for review June 17, 2024 09:38
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 16 (a27bf8a0c39fe34f0e56dce1f096f1c593e42ea0):

  • grpc/1.62.2:
    All packages built successfully! (All logs)

  • grpc/1.64.2:
    All packages built successfully! (All logs)

  • grpc/1.48.4:
    All packages built successfully! (All logs)

  • grpc/1.54.3:
    All packages built successfully! (All logs)

  • grpc/1.50.0:
    All packages built successfully! (All logs)

  • grpc/1.50.1:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 16 (a27bf8a0c39fe34f0e56dce1f096f1c593e42ea0):

  • grpc/1.62.2:
    All packages built successfully! (All logs)

  • grpc/1.64.2:
    All packages built successfully! (All logs)

  • grpc/1.54.3:
    All packages built successfully! (All logs)

  • grpc/1.50.1:
    All packages built successfully! (All logs)

  • grpc/1.48.4:
    All packages built successfully! (All logs)

  • grpc/1.50.0:
    All packages built successfully! (All logs)

@jcar87
Copy link
Contributor

jcar87 commented Aug 8, 2024

Hi @sophieeihpos - thank you for this PR and the time you dedicated to it! It's a remarkable effort!

In the end, in #24215 we opted to keep a static list of the grpc dependencies, similar to what is done for Qt and Boost, as we want to avoid text-parsing the CMake output. Parsing the CMake config files textually via regex was too complex for us to be comfortable.

Other points:

So I think the only feature missing in this PR that is not yet merged is the ability to switch off systemd support, correct? Please let me know how you'd like to proceed with that, thanks!

@sophieeihpos
Copy link
Contributor Author

Hi @sophieeihpos - thank you for this PR and the time you dedicated to it! It's a remarkable effort!

In the end, in #24215 we opted to keep a static list of the grpc dependencies, similar to what is done for Qt and Boost, as we want to avoid text-parsing the CMake output. Parsing the CMake config files textually via regex was too complex for us to be comfortable.

Other points:

So I think the only feature missing in this PR that is not yet merged is the ability to switch off systemd support, correct? Please let me know how you'd like to proceed with that, thanks!

Hi @jcar87 ,

Thank you for checking the PR.
I still see issue for the shared build in 1.65.0 as described here: grpc/grpc#36654. We will use 1.62 as a workaround for now.
with_systemd is add as an option in the recipe, and it works fine.
I will close the PR for now, as the issues are resolved in other PRs.

@sophieeihpos
Copy link
Contributor Author

Fixed in other PRs

@jcar87
Copy link
Contributor

jcar87 commented Aug 8, 2024

Thanks @sophieeihpos for checking.

I'm surprised! The shared=True configuration on macOS should work as per: https://github.com/jcar87/conan-center-index/blob/ab602fc61b892c624f864198fd3cebe922d3b48f/recipes/grpc/all/conanfile.py#L226-L232

If this doesn't work please let us know opening a new issue and we can certainly look into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] grpc/1.55.0
5 participants