-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc : add version 1.64.2 #23085
grpc : add version 1.64.2 #23085
Conversation
🤖 Beep Boop! This pull request is making changes to 'recipes/protobuf//'. 👋 @Hopobcn you might be interested. 😉 |
This comment has been minimized.
This comment has been minimized.
Hi @sophieeihpos thanks a lot for taking the time to contribute to Conan Center Unfortunately you'll need to split the PR in two, as right now only 1 recipe can be changed per PR :) |
Thanks @RubenRBS I created a separate PR for protobuf #23095 |
ae3accb
to
0217242
Compare
This comment has been minimized.
This comment has been minimized.
0217242
to
e9b2c26
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
e9b2c26
to
476bd5d
Compare
This comment has been minimized.
This comment has been minimized.
476bd5d
to
06ed139
Compare
This comment has been minimized.
This comment has been minimized.
1a9cbcb
to
43daa0e
Compare
This comment has been minimized.
This comment has been minimized.
43daa0e
to
f3aaf94
Compare
This comment has been minimized.
This comment has been minimized.
f3aaf94
to
a90b0f5
Compare
This comment has been minimized.
This comment has been minimized.
a90b0f5
to
b67fcb6
Compare
This comment has been minimized.
This comment has been minimized.
804b353
to
4a41cd9
Compare
This comment has been minimized.
This comment has been minimized.
4a41cd9
to
a27bf8a
Compare
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 16 (
Conan v2 pipeline ✔️
All green in build 16 (
|
Hi @sophieeihpos - thank you for this PR and the time you dedicated to it! It's a remarkable effort! In the end, in #24215 we opted to keep a static list of the grpc dependencies, similar to what is done for Qt and Boost, as we want to avoid text-parsing the CMake output. Parsing the CMake config files textually via regex was too complex for us to be comfortable. Other points:
So I think the only feature missing in this PR that is not yet merged is the ability to switch off systemd support, correct? Please let me know how you'd like to proceed with that, thanks! |
Hi @jcar87 , Thank you for checking the PR. |
Fixed in other PRs |
Thanks @sophieeihpos for checking. I'm surprised! The If this doesn't work please let us know opening a new issue and we can certainly look into this |
grpc/1.64.2
fixes #23084
© 2024 Morgan Stanley.
THIS SOFTWARE IS CONTRIBUTED SUBJECT TO THE TERMS OF THE Conan-io project Contributor License Agreement.
THIS SOFTWARE IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS.