-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc add version 1.65 #24215
grpc add version 1.65 #24215
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
as we feared - very very sensitive to the exact version of protobuf, by the looks of it. |
@jcar87 To move forward on this topic might it worth trying a version < 1.63.0 which still would resolve these two CVEs? CVE-2023-44487, Severity: High See also here: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This seems to be a duplicate to #23085, which adds v1.62.2 and v1.64.2. |
Conan v1 pipeline ✔️All green in build 13 (
Conan v2 pipeline ✔️
All green in build 13 ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👏
thanks @swaeberle - have reviewed the PR - but it adds a rather complex (yet functional!) cmake parsing that we rather avoid maintaining. There are other changes in that PR worth considering (tangential to the new versions), so will reach out to the PR author. Please comment or open an issue if you think it is still worth to add the older versions (1.62, 1.64) - I would advise to use 1.65 unless there's any specific reason not to. |
@jcar87 thanks for your explanation. I think I can go on with v1.65.0. I just wanted to point out, that I stumbled upon another PR not yet linked to each other. Thanks for your work 👍 |
Build errors due to oversight in LD_LIBRARY_PATH logic under Linux has a proposed fix here: #24651 |
This comment was marked as abuse.
This comment was marked as abuse.
Apologies if this has caused any issues - you are not providing any details, so unfortunately we cannot help. A couple of issues that have been reported to us, have been fixed as soon as we were made aware of them - and from what I can see only affected a subset of users rather than generalised. If there are any other issues that were not addressed by either #24651 or #24700 please provide details and we will look into it. We strive to avoid causing disruption to any of our users. On top of this, Conan Center has revisions enabled (for Conan 1, and default behaviour in Conan 2) - so users have a variety of ways to ensure they dont automatically consume freshly published revisions - chief among them being lockfiles. You can red about this here: https://docs.conan.io/2/devops/using_conancenter.html That said, please consider editing your message and extending an apology. Further abuse will result in a ban. |
grpc
as a shared library on Linux and any of its dependencies are shared - this is due to the fact that the grpc build scripts invoke the just-built grpc_cpp_plugin. Not a problem on macOS due to rpath handling.