Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc add version 1.65 #24215

Merged
merged 13 commits into from
Jul 17, 2024
Merged

grpc add version 1.65 #24215

merged 13 commits into from
Jul 17, 2024

Conversation

jcar87
Copy link
Contributor

@jcar87 jcar87 commented Jun 4, 2024

  • Add grpc 1.65.0
  • Refactor logic to handle component information in cpp_info to a separate file per version
  • Use version range for abseil (only two versions match that range, should be compatible), and c-ares (C library with known backwards compatibility)
  • Add logic to handle case when building grpc as a shared library on Linux and any of its dependencies are shared - this is due to the fact that the grpc build scripts invoke the just-built grpc_cpp_plugin. Not a problem on macOS due to rpath handling.
  • Simplify test package

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@jcar87
Copy link
Contributor Author

jcar87 commented Jun 5, 2024

grpc/grpc#36654

as we feared - very very sensitive to the exact version of protobuf, by the looks of it.

@saschasc
Copy link

saschasc commented Jun 12, 2024

@jcar87 To move forward on this topic might it worth trying a version < 1.63.0 which still would resolve these two CVEs?

CVE-2023-44487, Severity: High
CVE-2023-32731, Severity: High

See also here:

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@swaeberle
Copy link

This seems to be a duplicate to #23085, which adds v1.62.2 and v1.64.2.
Maybe both PRs can be merged?

@jcar87 jcar87 changed the title grpc add new versions / WIP / do not merge grpc add version 1.65 Jul 17, 2024
@jcar87 jcar87 marked this pull request as ready for review July 17, 2024 08:13
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 13 (ab602fc61b892c624f864198fd3cebe922d3b48f):

  • grpc/1.65.0:
    All packages built successfully! (All logs)

  • grpc/1.50.0:
    All packages built successfully! (All logs)

  • grpc/1.54.3:
    All packages built successfully! (All logs)

  • grpc/1.50.1:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 13 (ab602fc61b892c624f864198fd3cebe922d3b48f):

  • grpc/1.65.0:
    All packages built successfully! (All logs)

  • grpc/1.50.0:
    All packages built successfully! (All logs)

  • grpc/1.54.3:
    All packages built successfully! (All logs)

  • grpc/1.50.1:
    All packages built successfully! (All logs)

Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👏

@conan-center-bot conan-center-bot merged commit 1f93300 into conan-io:master Jul 17, 2024
24 checks passed
@jcar87 jcar87 deleted the lcc/grpc-1.64 branch July 17, 2024 09:26
@jcar87
Copy link
Contributor Author

jcar87 commented Jul 17, 2024

This seems to be a duplicate to #23085, which adds v1.62.2 and v1.64.2. Maybe both PRs can be merged?

thanks @swaeberle - have reviewed the PR - but it adds a rather complex (yet functional!) cmake parsing that we rather avoid maintaining. There are other changes in that PR worth considering (tangential to the new versions), so will reach out to the PR author.

Please comment or open an issue if you think it is still worth to add the older versions (1.62, 1.64) - I would advise to use 1.65 unless there's any specific reason not to.

@swaeberle
Copy link

@jcar87 thanks for your explanation.

I think I can go on with v1.65.0. I just wanted to point out, that I stumbled upon another PR not yet linked to each other.

Thanks for your work 👍

@nextsilicon-itay-bookstein
Copy link
Contributor

Build errors due to oversight in LD_LIBRARY_PATH logic under Linux has a proposed fix here: #24651

@Presburger

This comment was marked as abuse.

@jcar87
Copy link
Contributor Author

jcar87 commented Jul 25, 2024

Why do you change the behavior of the old version when you add a new version?

Apologies if this has caused any issues - you are not providing any details, so unfortunately we cannot help. A couple of issues that have been reported to us, have been fixed as soon as we were made aware of them - and from what I can see only affected a subset of users rather than generalised. If there are any other issues that were not addressed by either #24651 or #24700 please provide details and we will look into it.

We strive to avoid causing disruption to any of our users. On top of this, Conan Center has revisions enabled (for Conan 1, and default behaviour in Conan 2) - so users have a variety of ways to ensure they dont automatically consume freshly published revisions - chief among them being lockfiles. You can red about this here: https://docs.conan.io/2/devops/using_conancenter.html

That said, please consider editing your message and extending an apology. Further abuse will result in a ban.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants