Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc: Revert grpc component name to _grpc #24700

Merged

Conversation

AbrilRBS
Copy link
Member

Summary

Changes to recipe: grpc/[*]

Motivation

The _grpc component might be used in some recipes (See google-cloud-cpp) which breaks when changing the name. For now let's revert it back

Details

#24215 refactored the recipe to make it more maintainable, but this breaking change was not considered important as there was no expectation for the explicit usage of the component outside the recipe

Closes #24698


@AbrilRBS AbrilRBS requested a review from uilianries July 24, 2024 11:03
@AbrilRBS AbrilRBS self-assigned this Jul 24, 2024
@AbrilRBS AbrilRBS requested a review from jcar87 July 24, 2024 11:03
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (65a3003fe45470ae7bc9c354ce421a53a13a6caf):

  • grpc/1.65.0:
    All packages built successfully! (All logs)

  • grpc/1.54.3:
    All packages built successfully! (All logs)

  • grpc/1.50.1:
    All packages built successfully! (All logs)

  • grpc/1.50.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (65a3003fe45470ae7bc9c354ce421a53a13a6caf):

  • grpc/1.65.0:
    All packages built successfully! (All logs)

  • grpc/1.54.3:
    All packages built successfully! (All logs)

  • grpc/1.50.0:
    All packages built successfully! (All logs)

  • grpc/1.50.1:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit e323a7d into conan-io:master Jul 25, 2024
24 checks passed
@jcar87 jcar87 mentioned this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] google-cloud-cpp/2.19.0:grpc::_grpc component not found
4 participants