-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc: Fix recipe to prepend to LD_LIBRARY_PATH rather than clobber #24651
grpc: Fix recipe to prepend to LD_LIBRARY_PATH rather than clobber #24651
Conversation
This comment has been minimized.
This comment has been minimized.
Hi @nextsilicon-itay-bookstein , thanks for opening this PR. We are currently in maintenance, but will get to this shortly. I would imagine that this is something specific to your case, rather than something general? that is, you have en overridden LD_LIBRARY_PATH to support the system runtime (glibc, libstdc++, libm, pthread, etc), correct? Otherwise this should not cause errors |
Yes, for example easybuild/lmod foreign package manager, where loading packages sets this environment variable. Note that the Mac flow just a few lines beforehand does prepend instead of assign. |
Actually, upon further inspection, the Mac flow only propagates, doesn't preprend. Odd. |
This comment has been minimized.
This comment has been minimized.
In the presence of an ambient LD_LIBRARY_PATH we want to prepend rather than clobber, same as in the case of Mac. Otherwise we may end up missing library paths required by the user.
5df4d03
to
9665f1d
Compare
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 5 (
Conan v2 pipeline ✔️
All green in build 5 ( |
In the presence of an ambient LD_LIBRARY_PATH we want to prepend rather than clobber, same as in the case of Mac. Otherwise we may end up missing library paths required by the user.
Summary
Changes to recipe: grpc
Motivation
Recipe modifies cmake in a way that invokes protoc with a modified LD_LIBRARY_PATH under Linux. However, rather than prepending, it assigns, causing build errors when LD_LIBRARY_PATH is necessary.
Details
The PR fixes the recipe to prepend to the existing environment variable.