Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zserio 2.14.0 #23846

Merged
merged 11 commits into from
May 21, 2024
Merged

Zserio 2.14.0 #23846

merged 11 commits into from
May 21, 2024

Conversation

Mi-La
Copy link
Contributor

@Mi-La Mi-La commented May 2, 2024

Specify library name and version: zserio/2.14.0

Add new Zserio release 2.14.0.


@Mi-La
Copy link
Contributor Author

Mi-La commented May 2, 2024

Hi! The only bigger change is that we added zserio_compiler.cmake script to our GitHub release and thus it will not be needed to use the one from conan-center-index repository anymore.
However it's still needed for zserio-2.13.0. I didn't know how to do it nicer than just to use if-s in the conanfile.py.
Any hints are very welcome ;-).

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@Mi-La
Copy link
Contributor Author

Mi-La commented May 13, 2024

@uilianries Hello, just wondering what the status of this pull request? Do I need to do something more? Thanks.

@AbrilRBS AbrilRBS self-assigned this May 13, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mi-La sorry for the delay, I misstagged the PR internally so did not get a reminder to circle back to this, sorry! We appreciate you taking the time to create the PR :)
I'll review this alongside @uilianries tomorrow, but for now I have a minor question

recipes/zserio/all/conanfile.py Outdated Show resolved Hide resolved
Mi-La and others added 2 commits May 14, 2024 11:30
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@Mi-La
Copy link
Contributor Author

Mi-La commented May 16, 2024

@uilianries @RubenRBS I'm not sure if it's still my turn now? If you want to do bigger changes, feel free to fork my PR repo and change anything needed, you can simply close this PR and make your own.

To be honest it seems to me quite painful to publish release using conan. It's now two weeks since our official release ...

uilianries
uilianries previously approved these changes May 16, 2024
@uilianries
Copy link
Member

@Mi-La Sorry the review delay, but when having changes in the release we really need be careful reviewing the recipe to avoid future patches and bugs. The whole process delayed more than could be, yes, but keep in mind we have more 600 PRs waiting for review, even other authors publishing their releases too, so we are doing our best to keep all PRs reviewed as much as possible.

@Mi-La
Copy link
Contributor Author

Mi-La commented May 16, 2024

@uilianries I absolutely understand that it's complicated to review all the changes manually, moreover when users have almost unlimited possibilities how to write the recipe, which is the biggest problem I think.

I hope that next time I'll have almost no changes, just add the links to the new release and it will simply work :-).

Maybe in future we could completely delete the Zserio 2.13 release from conan and simplify the recipe again? Would it be acceptable?

@uilianries
Copy link
Member

Maybe in future we could completely delete the Zserio 2.13 release from conan and simplify the recipe again? Would it be acceptable?

Totally! Thank you for your understanding 😄

@AbrilRBS
Copy link
Member

I hope that next time I'll have almost no changes, just add the links to the new release and it will simply work :-).

The community has provided tools to make this even faster for you, check #3470 for one such case :)

@Mi-La
Copy link
Contributor Author

Mi-La commented May 20, 2024

@RubenRBS Could you please approve the PR, or shall I still do some changes?

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! This PR is most of the way there, only a minor thing left missing from me, but this will get merged today :)

recipes/zserio/all/conanfile.py Outdated Show resolved Hide resolved
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 8 (92f491ad1976a88877be8dd2d6e556de33f61d4c):

  • zserio/2.14.0:
    All packages built successfully! (All logs)

  • zserio/2.13.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 8 (92f491ad1976a88877be8dd2d6e556de33f61d4c):

  • zserio/2.14.0:
    All packages built successfully! (All logs)

  • zserio/2.13.0:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit c923862 into conan-io:master May 21, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants