-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zserio 2.14.0 #23846
Zserio 2.14.0 #23846
Conversation
Hi! The only bigger change is that we added |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@uilianries Hello, just wondering what the status of this pull request? Do I need to do something more? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Mi-La sorry for the delay, I misstagged the PR internally so did not get a reminder to circle back to this, sorry! We appreciate you taking the time to create the PR :)
I'll review this alongside @uilianries tomorrow, but for now I have a minor question
Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@uilianries @RubenRBS I'm not sure if it's still my turn now? If you want to do bigger changes, feel free to fork my PR repo and change anything needed, you can simply close this PR and make your own. To be honest it seems to me quite painful to publish release using conan. It's now two weeks since our official release ... |
@Mi-La Sorry the review delay, but when having changes in the release we really need be careful reviewing the recipe to avoid future patches and bugs. The whole process delayed more than could be, yes, but keep in mind we have more 600 PRs waiting for review, even other authors publishing their releases too, so we are doing our best to keep all PRs reviewed as much as possible. |
@uilianries I absolutely understand that it's complicated to review all the changes manually, moreover when users have almost unlimited possibilities how to write the recipe, which is the biggest problem I think. I hope that next time I'll have almost no changes, just add the links to the new release and it will simply work :-). Maybe in future we could completely delete the Zserio 2.13 release from conan and simplify the recipe again? Would it be acceptable? |
Totally! Thank you for your understanding 😄 |
The community has provided tools to make this even faster for you, check #3470 for one such case :) |
@RubenRBS Could you please approve the PR, or shall I still do some changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! This PR is most of the way there, only a minor thing left missing from me, but this will get merged today :)
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Conan v1 pipeline ✔️All green in build 8 (
Conan v2 pipeline ✔️
All green in build 8 ( |
Specify library name and version: zserio/2.14.0
Add new Zserio release 2.14.0.