Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for minimum C++ standard version doesn't work #614

Closed
Mi-La opened this issue May 14, 2024 · 1 comment
Closed

Check for minimum C++ standard version doesn't work #614

Mi-La opened this issue May 14, 2024 · 1 comment
Assignees
Labels
bug Something isn't working c++ C++ language generator
Milestone

Comments

@Mi-La
Copy link
Contributor

Mi-La commented May 14, 2024

Zserio version and language
Zserio: 2.14.0
Language: C++

Describe the bug
Check for minimum C++ standard doesn't work in some cases.

Expected behavior
The check will fire an error when C++ standard is lower than C++11.

Additional context
The check is here

if ("${CMAKE_CXX_STANDARD}" STREQUAL "98")
message(FATAL_ERROR "C++98 standard is not supported, please set CMAKE_CXX_STANDARD at least to C++11!")
endif ()
.

It seems that when compilers uses a default C++ standard version which is lower than C++11, the check doesn't work.

See failed builds on conan-center-index for MacOS Clang 13 and gcc 5.

@Mi-La Mi-La added the bug Something isn't working label May 14, 2024
@Mi-La Mi-La added this to the 2.15 milestone May 14, 2024
@Mi-La
Copy link
Contributor Author

Mi-La commented May 14, 2024

@mikir mikir closed this as completed May 20, 2024
@mikir mikir added the c++ C++ language generator label Jul 18, 2024
@mikir mikir modified the milestones: 2.15, 2.14.1 Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c++ C++ language generator
Projects
None yet
Development

No branches or pull requests

2 participants