added recipe for extra-cmake-modules #3211

boussaffawalid · 2020-10-15T19:13:16Z

Specify library name and version: lib/1.0

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

CLAassistant · 2020-10-15T19:13:20Z

All committers have signed the CLA.

conan-center-bot · 2020-10-15T19:14:04Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

recipes/extra-cmake-modules/all/conanfile.py

recipes/extra-cmake-modules/all/conandata.yml

conan-center-bot · 2020-10-15T19:37:45Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2020-10-15T19:39:55Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2020-10-15T21:23:45Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

recipes/extra-cmake-modules/all/conanfile.py

recipes/extra-cmake-modules/all/test_package/CMakeLists.txt

recipes/extra-cmake-modules/all/test_package/conanfile.py

recipes/extra-cmake-modules/all/conanfile.py

madebr · 2020-10-15T22:29:35Z

recipes/extra-cmake-modules/all/conanfile.py

+from conans import ConanFile, CMake, tools
+
+class ExtracmakemodulesConan(ConanFile):
+    name = "extra-cmake-modules"


Should the name be namespaced?
e.g. kde-extra-cmake-modules

extra-cmake-modules sounds generic.

This is just a question, let's hear the opinion of the others.

extra-cmake-modules sounds generic.

Indeed, I didn't know about this project, but when searching, it's well referenced to KDE, both Debian packages and Qt points to KDE page. Also, Conda offers extra-cmake-modules by the same name. So I think extra-cmake-modules is okay, as there is no other popular project using the same name or similar.

KDE does prefix almost everything with a k. What a shame that they haven't done here the same and leave us with this unfortunate choice 😄

The package got into many Linux distros with the unchanged name. I guess we can leave it at that

https://pkgs.org/download/extra-cmake-modules

recipes/extra-cmake-modules/all/conanfile.py

conan-center-bot · 2020-10-15T23:26:47Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

recipes/extra-cmake-modules/all/conanfile.py

conan-center-bot · 2020-10-20T08:07:06Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2020-10-20T08:07:29Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2020-10-20T11:16:48Z

An unexpected error happened and has been reported. Help is on its way! 🏇

conan-center-bot · 2020-10-20T15:15:54Z

Some configurations of 'extra-cmake-modules/5.75.0' failed in build 9 (8d7fcc81e11269cb0367708a7fe0a2e67a41c3be):

Linux x86_64, Release, gcc 4.9, libstdc++
- Hooks errors detected:
  - [HOOK - conan-center.py] post_package(): ERROR: [MATCHING CONFIGURATION (KB-H014)] Empty package (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H014)
  - [HOOK - conan-center.py] post_package(): ERROR: [MATCHING CONFIGURATION (KB-H014)] Packaged artifacts does not match the settings used: os=None, compiler=None (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H014)
  - [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] The conan-center repository doesn't allow the packages to contain CMake find modules or config files. The packages have to be located using generators and the declared cpp_infoinformation (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H016)
  - [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] Found files: ./res/ECM/cmake/ECMConfig.cmake; ./res/ECM/find-modules/FindCanberra.cmake; ./res/ECM/find-modules/FindEGL.cmake; ./res/ECM/find-modules/FindFontconfig.cmake; ./res/ECM/find-modules/FindGLIB2.cmake; ./res/ECM/find-modules/FindGperf.cmake; ./res/ECM/find-modules/FindIcoTool.cmake; ./res/ECM/find-modules/FindInotify.cmake; ./res/ECM/find-modules/FindKF5.cmake; ./res/ECM/find-modules/FindLibExiv2.cmake; ./res/ECM/find-modules/FindLibGit2.cmake; ./res/ECM/find-modules/FindOpenEXR.cmake; ./res/ECM/find-modules/FindPhoneNumber.cmake; ./res/ECM/find-modules/FindPoppler.cmake; ./res/ECM/find-modules/FindPulseAudio.cmake; ./res/ECM/find-modules/FindPythonModuleGeneration.cmake; ./res/ECM/find-modules/FindQHelpGenerator.cmake; ./res/ECM/find-modules/FindQtWaylandScanner.cmake; ./res/ECM/find-modules/FindReuseTool.cmake; ./res/ECM/find-modules/FindSasl2.cmake; ./res/ECM/find-modules/FindSeccomp.cmake; ./res/ECM/find-modules/FindSharedMimeInfo.cmake; ./res/ECM/find-modules/FindTaglib.cmake; ./res/ECM/find-modules/FindUDev.cmake; ./res/ECM/find-modules/FindWayland.cmake; ./res/ECM/find-modules/FindWaylandProtocols.cmake; ./res/ECM/find-modules/FindWaylandScanner.cmake; ./res/ECM/find-modules/FindX11_XCB.cmake; ./res/ECM/find-modules/FindXCB.cmake (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H016)
- Log download
- Log error Download
- Profile
Access to all the logs

boussaffawalid · 2020-10-21T09:08:21Z

KB-H014 : I don't understand this error, clarification please!
KB-H016: This package provide cmake helper modules so I think this is a false positive error. Any way to disable this check for this recipe ?

Croydon · 2020-10-21T15:01:06Z

Reading H016, this makes me wonder if those should actually be packaged... extra-cmake-modules has more scripts and NOT only find scripts, right?

The thing is, Conan is supposed to generate find scripts, so if you have a dependency tree with extra-cmake-modules and lets say OpenEXR, then you might end up having two conflicting FindOpenEXR,cmake scripts. And if you don't let Conan generate find scripts and you actually use those from the package then it raises the question if those are compatible with Conan and would find dependencies provided by Conan

🤔

madebr · 2020-10-21T15:06:19Z

I think this one and ignition-cmake should remove the FindXXX.cmake scripts for finding dependencies of third-party depenencies.
In ignition-cmake's case, the main installed FinxIgnitionCMake.cmake contains extra code that should be carefully modelled using conan.
The fact that conan is currently unable to generate multipe FindXXX.cmake scripts for one recipe also hampers this process.

boussaffawalid · 2020-10-21T16:24:11Z

ECM does not only contains find package scripts but also other cmake modules.
I can exclude the find scripts from the package but this will result to something different than the actual ECM package.

This means that if somebody have OpenEXR installed at the system level and he relay on ECM to find it, He won't be able to achieve that with the current package.

joxoby · 2020-10-21T17:13:32Z

I think this one and ignition-cmake should remove the FindXXX.cmake scripts for finding dependencies of third-party depenencies.

Maybe relevant: gazebosim/gz-cmake#119

conan-center-bot · 2020-10-21T19:46:28Z

Some configurations of 'extra-cmake-modules/5.75.0' failed in build 10 (5a5afba4b4c4f42654bd2ce386f05a9ceb58438c):

Linux x86_64, Release, gcc 4.9, libstdc++
- Hooks errors detected:
  - [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] The conan-center repository doesn't allow the packages to contain CMake find modules or config files. The packages have to be located using generators and the declared cpp_infoinformation (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H016)
  - [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] Found files: ./res/ECM/cmake/ECMConfig.cmake (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H016)
- Log download
- Log error Download
- Profile
Access to all the logs

boussaffawalid · 2020-10-21T19:48:15Z

I've excluded all Find*.cmake from the package.
ECMConfig.cmake cannot be excluded thought as it define some variables that are used by the cmake modules provided in this package, unless there a way to define custom variables in the FindECM.cmake generated by conan.

This package provides cmake helper modules and obviously will only be used by cmake. so it is pointless to define self.cpp_info.names[“generator”] .

uilianries · 2020-10-22T17:09:44Z

Can you add to build_modules, to be loaded automatically?

madebr · 2020-10-22T17:23:09Z

Can you add to build_modules, to be loaded automatically?

I don't know about extra-cmake-cmodules, but it is not always desired to blanket load all cmake modules automatically.

uilianries · 2020-10-22T18:09:00Z

Yes, ecm has a lot of modules, and probably you don't it, but for main modules. For example, ECMConfig.

madebr · 2020-10-22T18:10:19Z

Still it is a common pattern to first do a find_package such that some directory is added to CMAKE_MODULE_PATH, and then include the files you need.

uilianries · 2020-10-22T18:15:03Z

My point is about mandatory cmake files, not optional. I can use CMAKE_MODULE_PATH and include what I need, but my question is what is mandatory if I use ECM.

madebr · 2020-10-22T18:19:51Z

Not a lot, looking at its documentation at https://api.kde.org/ecm/manual/ecm.7.html#id3

boussaffawalid · 2020-10-22T18:20:15Z

Nothing needs to be included to build_modules. ECM handle including the required modules itself.

Here is the code from ECMConfig.cmake

set(ECM_FIND_MODULE_DIR "${PACKAGE_PREFIX_DIR}/res/ECM/find-modules/")
set(ECM_MODULE_DIR "${PACKAGE_PREFIX_DIR}/res/ECM/modules/")
set(ECM_KDE_MODULE_DIR "${PACKAGE_PREFIX_DIR}/res/ECM/kde-modules/")
set(ECM_PREFIX "${PACKAGE_PREFIX_DIR}")
set(ECM_MODULE_PATH "${ECM_MODULE_DIR}" "${ECM_FIND_MODULE_DIR}" "${ECM_KDE_MODULE_DIR}")
set(ECM_GLOBAL_FIND_VERSION "${ECM_FIND_VERSION}")

include("${ECM_MODULE_DIR}/ECMUseFindModules.cmake")

This mean when u run find_package(ECM REQUIRED NO_MODULE) cmake will load needed ECM modules.

uilianries · 2020-10-22T18:24:22Z

Great, so we can skip it from hooks.

uilianries · 2020-10-22T18:31:32Z

conan-io/hooks#248

conan-center-bot · 2020-11-23T15:00:37Z

All green in build 11 (e6bb5d3397bb34d409d2a37c3927aa6fd8a81e0f)! 😊

extra-cmake-modules/5.75.0: Generated 1 packages. All logs here

prince-chrismc · 2020-12-02T23:32:34Z

recipes/extra-cmake-modules/all/test_package/foo.h

@@ -0,0 +1,5 @@
+int success() 


is this supposed to be merged?

yes, there is no C++ interface to test with, dummy example is okay

* master: (73 commits) (conan-io#3878) opengl: support FreeBSD (conan-io#3882) [system-cci] Fix hooks (conan-io#3881) [szip] Fix hooks (conan-io#3880) [tcl] Fix hooks (conan-io#3866) xorg: add freebsd packages (conan-io#3825) Adds baikal-p7 5.6 (conan-io#3758) minimal recipe for pciutils/3.7.0 (conan-io#3211) added recipe for extra-cmake-modules (conan-io#3870) tl: fix compiler version check again (conan-io#3865) bump eigen/3.3.9 (conan-io#3864) add functionalplus/0.2.13-p0 bump fmt/7.1.3 (conan-io#3694) (conan-io#3858) fix: zulu-openjdk package info (conan-io#3836) gmp: bump + enable building static libraries on MSVC (conan-io#3812) Add logr v0.1.0 (conan-io#3786) add Open62541 recipe v1.0.3 and v1.1.3 (conan-io#3696) openh264: refactor + add 2.1.1 release (conan-io#3607) add botan/2.17.2 (conan-io#3854) Add PEGTL 3.0.0 (conan-io#3859) bump spdlog/1.8.2 ...

conan-center-bot added the No Beta user label Oct 15, 2020

Croydon reviewed Oct 15, 2020

View reviewed changes

recipes/extra-cmake-modules/all/conanfile.py Outdated Show resolved Hide resolved

Croydon reviewed Oct 15, 2020

View reviewed changes

recipes/extra-cmake-modules/all/conandata.yml Show resolved Hide resolved

boussaffawalid force-pushed the extra-cmake-modules branch from 2e3c366 to 000f906 Compare October 15, 2020 19:39

madebr reviewed Oct 15, 2020

View reviewed changes

boussaffawalid force-pushed the extra-cmake-modules branch from 96e2d2a to 6865161 Compare October 15, 2020 23:26

This was referenced Oct 19, 2020

added recipe for kcodecs #3255

Closed

added recipe for karchive #3260

Closed

uilianries requested changes Oct 19, 2020

View reviewed changes

recipes/extra-cmake-modules/all/conanfile.py Outdated Show resolved Hide resolved

recipes/extra-cmake-modules/all/conanfile.py Outdated Show resolved Hide resolved

conan-center-bot removed the No Beta user label Oct 20, 2020

conan-center-bot added the Unexpected Error label Oct 20, 2020

uilianries closed this Oct 20, 2020

uilianries reopened this Oct 20, 2020

conan-center-bot added Failed and removed Unexpected Error labels Oct 20, 2020

uilianries mentioned this pull request Oct 22, 2020

Skip KB-H016 and KB-H014 for extra-cmake-modules conan-io/hooks#248

Merged

danimtb requested a review from uilianries October 28, 2020 13:39

added recipe for extra-cmake-modules 5.75.0

e6bb5d3

boussaffawalid force-pushed the extra-cmake-modules branch from 5a5afba to e6bb5d3 Compare November 23, 2020 14:55

conan-center-bot removed the Failed label Nov 23, 2020

madebr approved these changes Nov 26, 2020

View reviewed changes

prince-chrismc reviewed Dec 2, 2020

View reviewed changes

SSE4 approved these changes Dec 14, 2020

View reviewed changes

uilianries approved these changes Dec 14, 2020

View reviewed changes

conan-center-bot merged commit 9e38f4d into conan-io:master Dec 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added recipe for extra-cmake-modules #3211

added recipe for extra-cmake-modules #3211

boussaffawalid commented Oct 15, 2020 •

edited

Loading

CLAassistant commented Oct 15, 2020 •

edited

Loading

conan-center-bot commented Oct 15, 2020

conan-center-bot commented Oct 15, 2020

conan-center-bot commented Oct 15, 2020

conan-center-bot commented Oct 15, 2020

madebr Oct 15, 2020

uilianries Oct 19, 2020 •

edited

Loading

Croydon Oct 20, 2020

conan-center-bot commented Oct 15, 2020

conan-center-bot commented Oct 20, 2020

conan-center-bot commented Oct 20, 2020

conan-center-bot commented Oct 20, 2020

conan-center-bot commented Oct 20, 2020

boussaffawalid commented Oct 21, 2020

Croydon commented Oct 21, 2020

madebr commented Oct 21, 2020

boussaffawalid commented Oct 21, 2020

joxoby commented Oct 21, 2020

conan-center-bot commented Oct 21, 2020

boussaffawalid commented Oct 21, 2020

uilianries commented Oct 22, 2020

madebr commented Oct 22, 2020

uilianries commented Oct 22, 2020

madebr commented Oct 22, 2020

uilianries commented Oct 22, 2020

madebr commented Oct 22, 2020

boussaffawalid commented Oct 22, 2020

uilianries commented Oct 22, 2020

uilianries commented Oct 22, 2020

conan-center-bot commented Nov 23, 2020

prince-chrismc Dec 2, 2020

SSE4 Dec 14, 2020

added recipe for extra-cmake-modules #3211

added recipe for extra-cmake-modules #3211

Conversation

boussaffawalid commented Oct 15, 2020 • edited Loading

CLAassistant commented Oct 15, 2020 • edited Loading

conan-center-bot commented Oct 15, 2020

conan-center-bot commented Oct 15, 2020

conan-center-bot commented Oct 15, 2020

conan-center-bot commented Oct 15, 2020

madebr Oct 15, 2020

Choose a reason for hiding this comment

uilianries Oct 19, 2020 • edited Loading

Choose a reason for hiding this comment

Croydon Oct 20, 2020

Choose a reason for hiding this comment

conan-center-bot commented Oct 15, 2020

conan-center-bot commented Oct 20, 2020

conan-center-bot commented Oct 20, 2020

conan-center-bot commented Oct 20, 2020

conan-center-bot commented Oct 20, 2020

boussaffawalid commented Oct 21, 2020

Croydon commented Oct 21, 2020

madebr commented Oct 21, 2020

boussaffawalid commented Oct 21, 2020

joxoby commented Oct 21, 2020

conan-center-bot commented Oct 21, 2020

boussaffawalid commented Oct 21, 2020

uilianries commented Oct 22, 2020

madebr commented Oct 22, 2020

uilianries commented Oct 22, 2020

madebr commented Oct 22, 2020

uilianries commented Oct 22, 2020

madebr commented Oct 22, 2020

boussaffawalid commented Oct 22, 2020

uilianries commented Oct 22, 2020

uilianries commented Oct 22, 2020

conan-center-bot commented Nov 23, 2020

prince-chrismc Dec 2, 2020

Choose a reason for hiding this comment

SSE4 Dec 14, 2020

Choose a reason for hiding this comment

boussaffawalid commented Oct 15, 2020 •

edited

Loading

CLAassistant commented Oct 15, 2020 •

edited

Loading

uilianries Oct 19, 2020 •

edited

Loading