Add ignition-cmake #3268
Merged
Add ignition-cmake #3268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some configurations of 'ignition-cmake/2.5.0' failed in build 1 (
|
|
I'm not sure how to package |
madebr
reviewed
Oct 19, 2020
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
|
Recipe syntax error in build 5: |
added 3 commits
October 19, 2020 15:40
|
You might also want to add the cmake patch that I added to |
|
Some configurations of 'ignition-cmake/2.5.0' failed in build 6 (
|
|
Some configurations of 'ignition-cmake/2.5.0' failed in build 7 (
|
|
Some configurations of 'ignition-cmake/2.5.0' failed in build 8 (
|
|
See joxoby#3 |
|
Failure in build 9 (
|
madebr
reviewed
Oct 20, 2020
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
|
Some configurations of 'ignition-cmake/2.5.0' failed in build 10 (
|
|
To get rid of the hook error, you will need to open a pull request at the hooks repo, adding the name of this recipe here: |
|
| homepage = "https://github.com/ignitionrobotics/ign-cmake" | ||
| description = "A set of CMake modules that are used by the C++-based Ignition projects." | ||
| topics = ("ignition", "robotics", "cmake") | ||
| settings = "os", "compiler", "build_type", "arch" |
There was a problem hiding this comment.
Hard to see on mobile but I believe the settings are not used.. can they be removed in this case?
There was a problem hiding this comment.
I think so. Will remove.
There was a problem hiding this comment.
Well, the cmake script builds a test library.
I left it in to be certain it would select the correct toolchain.
There was a problem hiding this comment.
Removing settings results in error:
ignition-cmake/2.5.0: ERROR: Generator cmake_find_package_multi(file:None) failed
'settings.build_type' doesn't exist
'settings' possible configurations are none
ERROR: 'settings.build_type' doesn't exist
'settings' possible configurations are none
There was a problem hiding this comment.
I think you can remove cmake_find_package from generators.
There was a problem hiding this comment.
It's currently not part of generators. You mean line:
self.cpp_info.names["cmake_find_package"] = "ignition-cmake{}".format(version_major)?
madebr
reviewed
Oct 20, 2020
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
|
Some configurations of 'ignition-cmake/2.5.0' failed in build 11 (
|
prince-chrismc
previously approved these changes
Oct 20, 2020
uilianries
reviewed
Oct 20, 2020
| self.cpp_info.builddirs = [ | ||
| os.path.join("lib", "cmake", "ignition-cmake{}".format(version_major)), | ||
| os.path.join("lib", "cmake", "ignition-cmake{}".format(version_major), "cmake{}".format(version_major)), | ||
| ] |
There was a problem hiding this comment.
You have to pass build_modules:
There was a problem hiding this comment.
I tried with:
def package_info(self):
version_major = tools.Version(self.version).major
self.cpp_info.names["cmake_find_package"] = "ignition-cmake{}".format(version_major)
self.cpp_info.names["cmake_find_package_multi"] = "ignition-cmake{}".format(version_major)
cmake_base_path = os.path.join("lib", "cmake", "ignition-cmake{}".format(version_major), "cmake{}".format(version_major))
self.cpp_info.builddirs = [
os.path.join("lib", "cmake", "ignition-cmake{}".format(version_major)),
cmake_base_path,
]
for cmake_file in glob.glob("{}/*.cmake".format(cmake_base_path)):
self.cpp_info.build_modules.append(cmake_file)But adding the last for loop results in an error during the test_package:
CMake Error at /home/juan/.conan/data/ignition-cmake/2.5.0/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/lib/cmake/ignition-cmake2/cmake2/IgnPkgConfig.cmake:75 (_ign_cmake_parse_arguments):
Unknown CMake command "_ign_cmake_parse_arguments".
Call Stack (most recent call first):
/home/juan/.conan/data/ignition-cmake/2.5.0/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/lib/cmake/ignition-cmake2/cmake2/FindAVCODEC.cmake:19 (ign_pkg_check_modules_quiet)
build/8e7da137254ca61c29cfd61de2482b72ba0ff99c/conanbuildinfo.cmake:857 (include)
build/8e7da137254ca61c29cfd61de2482b72ba0ff99c/conanbuildinfo.cmake:335 (conan_include_build_modules)
CMakeLists.txt:5 (conan_basic_setup)
-- Configuring incomplete, errors occurred!
This reverts commit 96b2ed3.
|
Some configurations of 'ignition-cmake/2.5.0' failed in build 13 (
|
4 tasks
|
All green in build 14 (
|
|
Just checking if we are waiting for something in particular to move forward |
|
I don't really like these files in the package: They are used to finding dependencies of ignition libraries. But I checked, through grep, that the generated package contains no absolute path to the build machine. |
prince-chrismc
approved these changes
Nov 8, 2020
|
Should we move forward? |
Tag some extra reviewers, see if we can get some action here... |
SSE4
approved these changes
Nov 23, 2020
uilianries
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: ignition-cmake/2.5.0
conan-center hook activated.