Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[boost] Add nowide lib #3894

Closed
wants to merge 4 commits into from
Closed

[boost] Add nowide lib #3894

wants to merge 4 commits into from

Conversation

fpelliccioni
Copy link
Contributor

@fpelliccioni fpelliccioni commented Dec 14, 2020

Specify library name and version: boost/1.74.0

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@fpelliccioni fpelliccioni changed the title Add nowide lib to Boost recipe [boost] Add nowide lib Dec 14, 2020
@prince-chrismc
Copy link
Contributor

Could you please add something to the test_packge too?

@madebr
Copy link
Contributor

madebr commented Dec 14, 2020

@fpelliccioni

You will also need to run the rebuild-dependencies.py script.
The script runs on Linux.
I'm not sure about windows, I have seen some strange behavior of git/boostdep and don't trust it.

@fpelliccioni
Copy link
Contributor Author

d something to the

Sure, like... what?

@fpelliccioni
Copy link
Contributor Author

@fpelliccioni

You will also need to run the rebuild-dependencies.py script.
The script runs on Linux.
I'm not sure about windows, I have seen some strange behavior of git/boostdep and don't trust it.

I tried to run the script on macOS but it end up with an error

ERROR: Unable to find 'boostdep/1.74.0' in remotes
Traceback (most recent call last):
  File "/Users/fernando/dev/conan-center-index/recipes/boost/all/rebuild-dependencies.py", line 481, in <module>
    sys.exit(main())
  File "/Users/fernando/dev/conan-center-index/recipes/boost/all/rebuild-dependencies.py", line 472, in main
    boost_collector.do_install_boostdep()
  File "/Users/fernando/dev/conan-center-index/recipes/boost/all/rebuild-dependencies.py", line 156, in do_install_boostdep
    subprocess.check_call(["conan", "install", "boostdep/{}@".format(self.boostdep_version), "-g", "json"])
  File "/usr/local/Cellar/python@3.9/3.9.0_5/Frameworks/Python.framework/Versions/3.9/lib/python3.9/subprocess.py", line 373, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['conan', 'install', 'boostdep/1.74.0@', '-g', 'json']' returned non-zero exit status 1.

I do not have a Linux box at hand.

@madebr
Copy link
Contributor

madebr commented Dec 15, 2020

Macos might work, I didn't test it though. It will probably work on all unixes.
Boostdep is from #2096
I bumped boostdep in the mean time, but there is an argument for the script to use a newer boostdep.

@ghost ghost mentioned this pull request Dec 15, 2020
4 tasks
@prince-chrismc
Copy link
Contributor

You can take the stock example off the website

Something like this ceb1278 (near the bottom of the diff)

@fpelliccioni
Copy link
Contributor Author

d boostdep in the mean time, but there is an arg

I ran ...

./rebuild-dependencies.py -U -v 1.74.0

... on Linux and I got the same error:

ERROR: Unable to find 'boostdep/1.74.0' in remotes

Do you have the exact command to run, please?
Thanks!

@ghost ghost mentioned this pull request Dec 15, 2020
4 tasks
@madebr
Copy link
Contributor

madebr commented Dec 15, 2020

The script has a -h option:

$ ./rebuild-dependencies.py -h
usage: rebuild-dependencies.py [-h] [--verbose] [-t TMPPATH]
                               [-d BOOSTDEP_VERSION] [-u GIT_URL] [-U]
                               [-o OUTPUTDIR] [-x] (-v BOOST_VERSION | -A)

optional arguments:
  -h, --help           show this help message and exit
  --verbose            verbose output
  -t TMPPATH           temporary folder where to clone boost (default is
                       system temporary folder)
  -d BOOSTDEP_VERSION  boostdep version
  -u GIT_URL           boost git url
  -U                   update the git repo
  -o OUTPUTDIR         output dependency dir
  -x                   unsafe fast(er) operation
  -v BOOST_VERSION     boost version
  -A                   All boost versions

So:

./rebuild-dependencies -d 1.75.0 -U -A

If you run the script multiple times, then you don't need to add the -U option, as it will update the git boost repo.
The boost repo is cloned to a temporary folder, so it will be cleared on reboot.

The -v option is to only update the dependencies of one particular boost version.
Since we want to update all boost versions, add -A.
(-A and -v cannot be used together)

@fpelliccioni
Copy link
Contributor Author

The script has a -h option:

$ ./rebuild-dependencies.py -h

I know, but everything you explain below is not easy to deduce using the -h.

Thank you!

@madebr
Copy link
Contributor

madebr commented Dec 15, 2020

Depending on what pr gets merged first (yours or #3872), the scripts will have to be re-run because #3872 adds 1.75.0 and yours adds a nowide option.

@fpelliccioni
Copy link
Contributor Author

Depending on what pr gets merged first (yours or #3872), the scripts will have to be re-run because #3872 adds 1.75.0 and yours adds a nowide option.

I will look at the progress of #3872

@madebr
Copy link
Contributor

madebr commented Dec 15, 2020

@fpelliccioni
Is it ok for you if I add nowide to #3872?
Then we have less builds, less wait time, ...
And it's better for the environment 😄 🌳 🌐

@fpelliccioni
Copy link
Contributor Author

./rebuild-dependencies -d 1.75.0 -U -A

I ran

python rebuild-dependencies.py -d 1.75.0 -U -A

and I am still getting:

boostdep/1.75.0: Not found in local cache, looking in remotes...
boostdep/1.75.0: Trying with 'conan-center'...
ERROR: Unable to find 'boostdep/1.75.0' in remotes
Traceback (most recent call last):

@fpelliccioni
Copy link
Contributor Author

nd it's better for the enviro

Sure, please, do it.

@madebr
Copy link
Contributor

madebr commented Dec 15, 2020

@fpelliccioni
Can you check #3872?

@conan-center-bot
Copy link
Collaborator

Failure in build 2 (ae04a65bc626c7bb4e5041ff76ec30a1b3000d4b):

  • libdispatch/5.3.0
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "5.3.2" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "5.3.2". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • libdispatch/6.0.0
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "5.3.2" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "5.3.2". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • libdispatch/6.1.0
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "5.3.2" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "5.3.2". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • libdispatch/6.1.1
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "5.3.2" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "5.3.2". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • libdispatch/6.1.2
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "5.3.2" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "5.3.2". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • libdispatch/6.2.0
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "5.3.2" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "5.3.2". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • libdispatch/6.2.1
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "5.3.2" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "5.3.2". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • libdispatch/7.0.1
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "5.3.2" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "5.3.2". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • libdispatch/7.0.2
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "5.3.2" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "5.3.2". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • libdispatch/7.0.3
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "5.3.2" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "5.3.2". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • libdispatch/7.1.0
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "5.3.2" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "5.3.2". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • libdispatch/7.1.1
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "5.3.2" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "5.3.2". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • libdispatch/7.1.2
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "5.3.2" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "5.3.2". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)
  • libdispatch/7.1.3
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "5.3.2" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "5.3.2". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)

@conan-center-bot
Copy link
Collaborator

config.yml syntax error in build 3:

Only one library can be changed in the same PR: [boost/all, libdispatch/all]|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants