-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[boost] Allow apple-clang version 10 for nowide and C++ 11 #3977
[boost] Allow apple-clang version 10 for nowide and C++ 11 #3977
Conversation
- Tested with apple-clang 10.0, which is equivalent to clang 4.2. - Boost config reports that std::fstream is swappable and movable.
I detected other pull requests that are modifying boost/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
Some configurations of 'boost/1.69.0' failed in build 1 (
|
@datalogics-kam And tip while debugging this recipe: disable all other os'es and build only Release to get faster feedback of c3i. |
the default mode of apple-clang 12 (and 10) is C++03:
you have to activate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should probably return None for apple-clang instead of 10/12
@SSE4 The default C++ language standard in apple clang 12 is gnu++14 (~C++14 with GNU specific extensions).
then search "default C++" |
Does it seem like documentation is lying? I can't compile C++14 code without passing |
Trust no one. :-) Maybe Apple means XCode sets the option gnu++14 by default. |
Co-authored-by: SSE4 <tomskside@gmail.com>
04602a6
Co-authored-by: SSE4 <tomskside@gmail.com>
The boost packages on CCI are without nowide, fiber, numa, json, right? |
The logs have not be uploaded yet (boost is huge and it takes time) We'll need to wait before we can check them. @SSE4 since you are following this PR, do you know if (the community) can pull packages from the internal "conan-upstream" remote? |
|
this is a WIP, we're going to add |
I don't think so, AFAIK this is the only temporary repository that exists for a short period of time, and then removed to avoid wasting CI resources (disk space). |
I think so, as well as without MPI, python, stack trace and several other libraries |
you know my point of view conan-io/conan#8304. Please rethink your "default" choice, do not use apple-clang in prehistoric c++003 mode. Set cppstd=14 for apple-clang (12) in boost recipe and the problem is fixed. And this is safe also because no one use apple-clang on command line.
With the difference that graph_parallel, mpi, python are disabled by default but json, nowide, fiber are skipped because Conan think apple-clang not supported c++11 standard (#3977 (comment)).
|
We're using apple-clang 10 at the moment, and from the command line. And while you can use an IDE to build our code, it's primarily built from the command line, from CMake projects. Also, I don't think the language standard should be hardcoded in this recipe. Whatever gets passed to B2 should be from |
I would wonder if you have not set the same c++ standard in your CMake projects that is set in Xcode 10. But agreed, the default c++ standard should rather be set everywhere by Conan itself. |
All green in build 7 (
|
About the Nevertheless, we talked to the hierarchy, and we are allowed to burn more resources if needed. So the plan is to generate packages for other
Maybe the answer is not to generate ALL, but only some of the |
@jgsogo Yes you will get the packages, but they are not actually consumable from Xcode. Because Xcode passes c++14 as standard by default. |
And the next boost version can anyway no longer be compiled in C++03 mode at all. As example: |
Specify library name and version: boost/1.75.0
conan-center hook activated.
Supporting information
This was my build configuration:
Boost reported:
apple-clang
10 isclang
4.2: Wikipedia table...and
clang
4.2 definitely supports all of C++ 11: Cppreference compiler support tables.