Add Qt integration to sentry

[MartinDelille]

Specify library name and version: sentry/0.4.9

See the doc here: https://docs.sentry.io/platforms/native/guides/qt/

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the
  conan-center hook activated.

[ericLemanissier]

You could add

if self.options.qt:
    self.requires("qt/....")

[ghost]

I detected other pull requests that are modifying sentry-native/all recipe:

• sentry-native: add crashpad support #5524
• sentry-native: add version 0.4.7 #4525

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

[MartinDelille]

@ericLemanissier I personnaly don't use the Qt recipe from CCI yet (I'd love to do so but it isn't very clear for me how to do it, especially with my local environment and Qt Creator). Won't this cause trouble for my setup ?

[ericLemanissier]

If you require another qt recipe in your recipe (qt/...@bincrafters/stable for example), then this qt package will be used instead of CCI's package https://docs.conan.io/en/latest/using_packages/conanfile_txt.html#overriding-requirements

If you are using a qt coming from somewhere else than conan (manually built, official qt binary, or provided by some other package manager), it's true that it could be a problem.

[MartinDelille]

This is quite out of topic but I'll be happy to know how people use the CCI qt recipe with Qt Creator for example. Do I need to run conan and then add the kit manually ?

[madebr]

You could add

if self.options.qt:
    self.requires("qt/....")

The recipe is missing self.requires("qt/...").
Does this recipe actually build when no qt is installed and configured with -o sentry-native:qt=True?

[SSE4]

please clarify if Qt integration requires Qt dependency to build/run. I am not familiar with sentry, so it's hard to judge for me right away.
(e.g. I can imagine it may not require an actual Qt if it only generates some headers containing #include <QtWidgets> or similar code)

[MartinDelille]

The recipe does indeed need Qt to build if the option is set https://github.com/getsentry/sentry-native/blob/master/CMakeLists.txt#L462-L475

Unfortunately when trying to add the requirement, cmake is unable to find Qt when building sentry-native...

I pushed the update recipe with qt option set to true to share my issue.

[mjvankampen]

In my opinion the CCI Qt recipe is not a full drop in replacement for the official Qt binaries (mostly qml related). So I wouldn't impose Qt as a requirement.

[SSE4]

from that I see, it reports merge conflicts which don't exist (at least GitHub doesn't report them):

+ git merge --no-ff 2f71c2f10dfbe4a87595bdc619aeef8262a9e6d0
Removing recipes/vorbis/all/patches/link-libm.patch
Removing recipes/srt/all/patches/002-cmake-link-targets.patch
Removing recipes/srt/all/patches/001-cmake-link-targets.patch
Auto-merging recipes/sentry-native/all/conanfile.py
Auto-merging recipes/sentry-native/all/conandata.yml
CONFLICT (content): Merge conflict in recipes/sentry-native/all/conandata.yml
Removing recipes/pkgconf/all/patches/0002-c89-compatible.patch
Automatic merge failed; fix conflicts and then commit the result.

probably, bug in CI? @jgsogo @danimtb

[jgsogo]

@MartinDelille , please, push an empty commit to your branch:

git commit -m "touch" --allow-empty
git push

[conan-center-bot]

All green in build 19 (51be319783e47c1a20921bfcff688bbb9335ce1b):

• sentry-native/0.4.9@:
  All packages built successfully! (All logs)

• sentry-native/0.4.8@:
  All packages built successfully! (All logs)

• sentry-native/0.4.7@:
  All packages built successfully! (All logs)

• sentry-native/0.4.1@:
  All packages built successfully! (All logs)

• sentry-native/0.2.6@:
  All packages built successfully! (All logs)

[madebr]

Is qt integration by default useful?

[prince-chrismc]

Yes but at the expense of current users who do no require it

https://docs.sentry.io/platforms/native/guides/qt/#install

Looks off by default from upstream

[madebr]

buildroot has some kind of ci system where it builds random combinations to find regressions.
Something similar where non-default option combinations are built would be useful.