sentry-native: add crashpad support

[madebr]

Specify library name and version: sentry-native/all

Add crashpad support to sentry-native.
Depends on #5511 when using with -o crashpad:backend=crashpad.

---

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the
  conan-center hook activated.

[ghost]

I detected other pull requests that are modifying sentry-native/all recipe:

• Add Qt integration to sentry #5440
• sentry-native: add version 0.4.7 #4525

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

[espkk]

This looks nice, but IIRC sentry-native uses own crashpad fork
It basically allows sentry_options_add_attachment to be used. Without it crashpad backend vs raw crashpad does not make much sense...
Am I missing something?

[madebr]

@espkk
You're right. attachment support is a feature of getsentry's fork.
These are the changes between chromium's crahpad and getsentry's: https://github.com/getsentry/crashpad/compare/master..getsentry

I just looked at the release page of sentry-native, and it looks like they provide a sentry-native.zip file with everything included.
https://github.com/getsentry/sentry-native/releases

[conan-center-bot]

All green in build 2 (9aac11adff9e146069a06136b97ca7810e294f9a):

• sentry-native/0.4.9@:
  All packages built successfully! (All logs)

• sentry-native/0.4.7@:
  All packages built successfully! (All logs)

• sentry-native/0.2.6@:
  All packages built successfully! (All logs)

• sentry-native/0.4.8@:
  All packages built successfully! (All logs)

• sentry-native/0.4.1@:
  All packages built successfully! (All logs)

[espkk]

I just looked at the release page of sentry-native, and it looks like they provide a sentry-native.zip file with everything included.
https://github.com/getsentry/sentry-native/releases

That's nice! I was sure it is shipped without submodules.
I believe
self.requires("crashpad/cci.20210507") and
self._cmake.definitions["SENTRY_CRASHPAD_SYSTEM"] = True should be removed then
also, self.cpp_info.libs probably should include backend libraries

[madebr]

@espkk
I'm working on a sentry-crashpad recipe at #5536

[espkk]

@espkk
I'm working on a sentry-crashpad recipe at #5536

I see... But could you please explain why we need it if it's anyway downloaded in the source bundle?
Considering that the fork already makes it cmake-compatiable I do not understand that additional dependency

[madebr]

Increased modularity.
You can use crashpad from multiple sources: the official sources (this pr) or a fork (sentry's one).

[espkk]

Increased modularity.
You can use crashpad from multiple sources: the official sources (this pr) or a fork (sentry's one).

Ok, that makes sense.
Then may I ask you one more question since I'm not familar enough with conan yet.
How in practice can I switch between 'the official sources (this pr) or a fork (sentry's one)'?
I mean, I would expect some package:option that switches SENTRY_CRASHPAD_SYSTEM (and adds/removes self.requires)
Could you please show an example of configuration?

[madebr]

How to switch transparently (or from the command line or using profiles), that I don't know because I will hardcode sentry-crashpad in the requirement list in the sentry-native recipe.

By using provides, conan will complain if you try to mix multiple crashpad packages.

[jgsogo]

There are some recipes that are already modifying the requirements based on some option, you can find examples related to the different JPEG implementations

conan-center-index/recipes/libyuv/all/conanfile.py

Line 40 in 41d4fbb

def requirements(self):

[Dev-vlad]

Hi @madebr! I saw that you are working on a recipe for the sentry-crashpad. Do you plan to integrate it with the current one?
I'm not sure how conan ci works, but I'm getting a build error on windows:
sentry_backend_crashpad.cpp(254,31): error C2039: 'SetFirstChanceExceptionHandler': is not a member of 'cra shpad::CrashpadClient'
I've checked the generated projects and the version of crashpad used in the current recipe is not compatible with sentry-native on windows.

[madebr]

@Dev-vlad
Can you open an issue containing a small reproducer cmake project?
I tested the test package on Linux and it worked.
sentry's fork of crashpad (sentry-crashpad) has also become available on cci,
so I'll add an option to the sentry-native recipe to switch between crashpad and sentry-crashpad.

[madebr]

@Dev-vlad
I could reproduce your issue by building sentry-native with MSVC. "It works" on Linux 😄 .
Soon, I'll open a pr.

[Dev-vlad]

@madebr, thanks!
Yes, this issue is only for Windows. I checked sentry-crashpad and they have a different API under #ifdef (OS_WIN) that is not available in the original crashpad project.
I don't have much experience with conan, but will think about how we can cover this with a test to make sure not to break this in future.

[madebr]

@Dev-vlad
See #5717