-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add osgearth/3.2 #7535
add osgearth/3.2 #7535
Conversation
This comment has been minimized.
This comment has been minimized.
There seems to be no binary package for openscenegraph/3.6.5 + gcc10 |
This comment has been minimized.
This comment has been minimized.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sorry I kind of had forgotten about this PR, holidays etc.
|
Okay, regarding the second point, of course you can debug with the docker container... |
This comment has been minimized.
This comment has been minimized.
define flag in case of msvc static lib dont build procedural nodekit on windows
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
del draco option for gcc11
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Okay, so I finally got around to applying your suggestions. I would have never guessed using os_info was the problem, but I can see it makes way more sense to use settings.os. Finally all green, nice! |
This comment has been minimized.
This comment has been minimized.
set(GDAL_LIBRARY ${GDAL_LIBRARIES}) | ||
|
||
# curl | ||
find_package(CURL REQUIRED) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a little surprised to see this here.
https://github.com/gwaldron/osgearth/blob/master/CMakeLists.txt
Has this already. I am not familiar with the project but some of this logic seems a tad extra.
Is everything required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
osgearth has custom cmake find modules which unfortunately set different variables than the ones generated by conan (most notably *_LIBRARY instead of *_LIBRARIES, but also different names). These are then used in multiple places throughout, so I opted for setting these non-standard variables in the wrapper.
I agree though, that since I do a patch anyway, the wrapper could probably eliminated. Do you think it is necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wrapper is needed and I suspect Conan V2 will have an impact...
Let's improve the comments!
- change license to "LGPL-3.0" - remove version range from draco dependency - better comment in CMakeLists.txt wrapper
This comment has been minimized.
This comment has been minimized.
All green in build 18 (
|
Specify library name and version: osgearth/3.2
osgEarth is a really cool library, that I am using.
It is on the list in Issue #621.
conan-center hook activated.