Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add osgearth/3.2 #7535
add osgearth/3.2 #7535
Changes from 10 commits
c3ab92c
9b5ceef
41cd0f0
af1f202
e865699
bd5652f
87476d7
1a1b76e
501222b
5c76617
248d269
c78d765
8a00af8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a little surprised to see this here.
https://github.com/gwaldron/osgearth/blob/master/CMakeLists.txt
Has this already. I am not familiar with the project but some of this logic seems a tad extra.
Is everything required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
osgearth has custom cmake find modules which unfortunately set different variables than the ones generated by conan (most notably *_LIBRARY instead of *_LIBRARIES, but also different names). These are then used in multiple places throughout, so I opted for setting these non-standard variables in the wrapper.
I agree though, that since I do a patch anyway, the wrapper could probably eliminated. Do you think it is necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wrapper is needed and I suspect Conan V2 will have an impact...
Let's improve the comments!