Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boost: change Boost.Math cppstd error message on Macos #7862

Merged
merged 4 commits into from
Nov 7, 2021
Merged

boost: change Boost.Math cppstd error message on Macos #7862

merged 4 commits into from
Nov 7, 2021

Conversation

madebr
Copy link
Contributor

@madebr madebr commented Oct 28, 2021

Specify library name and version: boost/all

Fixes #7861
Also replaced some usages of single quotes with double quotes + more usage of str.format.

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@madebr madebr changed the title Patch 1 boost: change Boost.Math cppstd error message on Macos Oct 28, 2021
@conan-center-bot

This comment has been minimized.

Sign in to view
@ghost ghost mentioned this pull request Oct 28, 2021
Closed
@ghost
Copy link

ghost commented Oct 28, 2021 •
edited by ghost
Loading

I detected other pull requests that are modifying boost/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

All green in build 3 (c3aa5aacfafb1a0578c2016e304642db938ebade):

  • boost/1.69.0@:
    All packages built successfully! (All logs)

  • boost/1.72.0@:
    All packages built successfully! (All logs)

  • boost/1.73.0@:
    All packages built successfully! (All logs)

  • boost/1.70.0@:
    All packages built successfully! (All logs)

  • boost/1.71.0@:
    All packages built successfully! (All logs)

  • boost/1.74.0@:
    All packages built successfully! (All logs)

  • boost/1.75.0@:
    All packages built successfully! (All logs)

  • boost/1.76.0@:
    All packages built successfully! (All logs)

  • boost/1.77.0@:
    All packages built successfully! (All logs)

@prince-chrismc prince-chrismc mentioned this pull request Oct 28, 2021
Open
@SSE4 SSE4 requested a review from uilianries October 29, 2021 05:38
uilianries
uilianries approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost mentioned this pull request Oct 31, 2021
Merged
4 tasks
@conan-center-bot conan-center-bot merged commit cd6528d into conan-io:master Nov 7, 2021
ivanvurbanov pushed a commit to ivanvurbanov/conan-center-index that referenced this pull request Dec 2, 2021
@madebr @ivanvurbanov
(conan-io#7862) boost: change Boost.Math cppstd error message on Macos
f9781b6 
* boost: rewrite Boost.Math cppstd error message + double quotes

* Update conanfile.py

* Update conanfile.py

* Update recipes/boost/all/conanfile.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@uilianries uilianries uilianries approved these changes

@SSE4 SSE4 SSE4 approved these changes

@jgsogo jgsogo Awaiting requested review from jgsogo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[package] boost/1.76: Fails to build on MacOS due to compiler version restrictions
5 participants
@madebr @conan-center-bot @SSE4 @uilianries @prince-chrismc