Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boost: checking libiconv exists even if libc already found #7908

Merged
merged 1 commit into from
Nov 13, 2021
Merged

boost: checking libiconv exists even if libc already found #7908

merged 1 commit into from
Nov 13, 2021

Conversation

AntonHorbach
Copy link
Contributor

@AntonHorbach AntonHorbach commented Oct 31, 2021 •
edited
Loading

Specify library name and version: boost/1.77.0

fix #7907

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@CLAassistant
Copy link

CLAassistant commented Oct 31, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

Sign in to view
@ghost ghost mentioned this pull request Oct 31, 2021
Closed
@ghost
Copy link

ghost commented Oct 31, 2021

I detected other pull requests that are modifying boost/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Oct 31, 2021
Merged
4 tasks
@AntonHorbach AntonHorbach mentioned this pull request Oct 31, 2021
Closed
@AntonHorbach AntonHorbach reopened this Nov 2, 2021
@prince-chrismc prince-chrismc mentioned this pull request Nov 2, 2021
Open
@conan-center-bot
Copy link
Collaborator

All green in build 2 (734bf30d546f92ef31931793b5ca0b7fb27c09cf):

  • boost/1.69.0@:
    All packages built successfully! (All logs)

  • boost/1.71.0@:
    All packages built successfully! (All logs)

  • boost/1.70.0@:
    All packages built successfully! (All logs)

  • boost/1.73.0@:
    All packages built successfully! (All logs)

  • boost/1.72.0@:
    All packages built successfully! (All logs)

  • boost/1.74.0@:
    All packages built successfully! (All logs)

  • boost/1.77.0@:
    All packages built successfully! (All logs)

  • boost/1.75.0@:
    All packages built successfully! (All logs)

  • boost/1.76.0@:
    All packages built successfully! (All logs)

uilianries
uilianries approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 3491c18 into conan-io:master Nov 13, 2021
ivanvurbanov pushed a commit to ivanvurbanov/conan-center-index that referenced this pull request Dec 2, 2021
@AntonHorbach @ivanvurbanov
(conan-io#7908) boost: checking libiconv exists even if libc already …
adb879e 
…found
@AntonHorbach AntonHorbach deleted the boost_separate_libiconv branch December 20, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@uilianries uilianries uilianries approved these changes

@SSE4 SSE4 SSE4 approved these changes

@danimtb danimtb Awaiting requested review from danimtb

@czoido czoido Awaiting requested review from czoido

@jgsogo jgsogo Awaiting requested review from jgsogo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[package] boost/1.77.0: can't build boost.locale on Linux with separate libiconv
6 participants
@AntonHorbach @CLAassistant @conan-center-bot @SSE4 @uilianries @prince-chrismc