Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't use distutils if Python version >= 3.10 #8759

Merged
merged 1 commit into from
Jan 17, 2022
Merged

don't use distutils if Python version >= 3.10 #8759

merged 1 commit into from
Jan 17, 2022

Conversation

Enhex
Copy link
Contributor

@Enhex Enhex commented Jan 10, 2022 •
edited by uilianries
Loading

Specify library name and version: boost/1.78.0

Boost recipe is broken with Python 3.10, see #8638

fixes #8638

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@CLAassistant
Copy link

CLAassistant commented Jan 10, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

Sign in to view
@Enhex Enhex mentioned this pull request Jan 10, 2022
Closed
@ghost
Copy link

ghost commented Jan 10, 2022

I detected other pull requests that are modifying boost/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

This was referenced Jan 10, 2022
Closed
Merged
Merged
@prince-chrismc prince-chrismc mentioned this pull request Jan 11, 2022
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
SSE4
SSE4 reviewed Jan 12, 2022
View reviewed changes
recipes/boost/all/conanfile.py
python_version_parts = self.info.options.python_version.split('.')
python_major = int(python_version_parts[0])
python_minor = int(python_version_parts[1])
if(python_major >= 3 and python_minor >= 10):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good enough (well, it won't work for python 4.0, but okay for today)

@Enhex
Copy link
Contributor Author

Enhex commented Jan 17, 2022

@SSE4 it seems @prince-chrismc approval didn't count towards the required reviews

@ericLemanissier
Copy link
Contributor

no, but the CI failed for an unknown reason:
image
You can close the pr, wait 10 seconds and reopen the PR to retrigger CI

@Enhex Enhex closed this Jan 17, 2022
@Enhex Enhex reopened this Jan 17, 2022
@conan-center-bot
Copy link
Collaborator

All green in build 4 (b9ad567c93b4dd247fd9a42b2aca9def2a33078c):

  • boost/1.78.0@:
    All packages built successfully! (All logs)

  • boost/1.76.0@:
    All packages built successfully! (All logs)

  • boost/1.69.0@:
    All packages built successfully! (All logs)

  • boost/1.70.0@:
    All packages built successfully! (All logs)

  • boost/1.72.0@:
    All packages built successfully! (All logs)

  • boost/1.73.0@:
    All packages built successfully! (All logs)

  • boost/1.71.0@:
    All packages built successfully! (All logs)

  • boost/1.74.0@:
    All packages built successfully! (All logs)

  • boost/1.75.0@:
    All packages built successfully! (All logs)

  • boost/1.77.0@:
    All packages built successfully! (All logs)

@prince-chrismc
Copy link
Contributor

it seems @prince-chrismc approval didn't count towards the required reviews

The GitHub UI does account for the costume logic the bot uses to merge PRs

@conan-center-bot conan-center-bot merged commit a57ead8 into conan-io:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@uilianries uilianries uilianries approved these changes

@SSE4 SSE4 SSE4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[package] boost/1.78.0: fails to find Python
7 participants
@Enhex @CLAassistant @conan-center-bot @ericLemanissier @prince-chrismc @SSE4 @uilianries