Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost: Configure the proper namespace for CMake targets #8446

Merged

Conversation

jwillikers
Copy link
Contributor

Specify library name and version: boost/1.77.0

This PR updates Boost for use with the CMakeDeps generator per Conan 1.43. The CMake namespace for Boost targets is Boost::. Note the capital B. Currently, the CMake targets are under the boost:: namespace when using the CMakeDeps generator. This PR uses set_property to configure the absolute CMake target names using the correct namespace.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@ghost
Copy link

ghost commented Dec 15, 2021

@conan-center-bot

This comment has been minimized.

madebr
madebr previously approved these changes Dec 21, 2021
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@alex-700
Copy link
Contributor

Any update on this?

I think that CI should be OK after #8719 and #8671 (namely, their build for gcc11).

@jwillikers
Copy link
Contributor Author

Any update on this?

I think that CI should be OK after #8719 and #8671 (namely, their build for gcc11).

@alex-700 I've updated my branch to the latest changes on master. Hopefully that works. Thanks for the update!

@conan-center-bot
Copy link
Collaborator

All green in build 4 (a3b1a188934a11a1380dbbbe3c4a9aee1855cfc8):

  • boost/1.72.0@:
    All packages built successfully! (All logs)

  • boost/1.70.0@:
    All packages built successfully! (All logs)

  • boost/1.69.0@:
    All packages built successfully! (All logs)

  • boost/1.71.0@:
    All packages built successfully! (All logs)

  • boost/1.78.0@:
    All packages built successfully! (All logs)

  • boost/1.74.0@:
    All packages built successfully! (All logs)

  • boost/1.73.0@:
    All packages built successfully! (All logs)

  • boost/1.77.0@:
    All packages built successfully! (All logs)

  • boost/1.75.0@:
    All packages built successfully! (All logs)

  • boost/1.76.0@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 89e6169 into conan-io:master Jan 26, 2022
@SpaceIm
Copy link
Contributor

SpaceIm commented Jan 26, 2022

cmake_find_mode both (but maybe not useful since FindBoost.cmake fallbacks to BoostConfig.cmake if found).

@jwillikers
Copy link
Contributor Author

cmake_find_mode both (but maybe not useful since FindBoost.cmake fallbacks to BoostConfig.cmake if found).

@SpaceIm Sorry, I missed this before this PR was merged. If you like I can make a separate PR to add that.

@SpaceIm
Copy link
Contributor

SpaceIm commented Jan 27, 2022

Well actually I think it's fine, since FindBoost.cmake fallbacks to BoostConfig.cmake if found. This behavior is there since at least 3.0 I believe, so no need to override FindBoost.

Sahnvour pushed a commit to Sahnvour/conan-center-index that referenced this pull request Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants