-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boost: Configure the proper namespace for CMake targets #8446
boost: Configure the proper namespace for CMake targets #8446
Conversation
I detected other pull requests that are modifying boost/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
f5dc2e9
to
a3b1a18
Compare
All green in build 4 (
|
cmake_find_mode both (but maybe not useful since FindBoost.cmake fallbacks to BoostConfig.cmake if found). |
@SpaceIm Sorry, I missed this before this PR was merged. If you like I can make a separate PR to add that. |
Well actually I think it's fine, since FindBoost.cmake fallbacks to BoostConfig.cmake if found. This behavior is there since at least 3.0 I believe, so no need to override FindBoost. |
Specify library name and version: boost/1.77.0
This PR updates Boost for use with the CMakeDeps generator per Conan 1.43. The CMake namespace for Boost targets is
Boost::
. Note the capitalB
. Currently, the CMake targets are under theboost::
namespace when using the CMakeDeps generator. This PR usesset_property
to configure the absolute CMake target names using the correct namespace.conan-center hook activated.