Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost: Fix path finder for python libraries #9059

Merged

Conversation

Minimonium
Copy link
Contributor

Specify library name and version: boost/all

Fixes #2973


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@ghost
Copy link

ghost commented Jan 24, 2022

@conan-center-bot

This comment has been minimized.

@SSE4
Copy link
Contributor

SSE4 commented Jan 25, 2022

/cc @grafikrobot

I don't remember all the details of how boost.python finds python libraries, it will require checking the docs and code, I only recall it was very cryptic, and AFAIK it requires a full path to the python library (otherwise, how did it know which one to pick if there are several variants in the same directory, like debug/release or static/shared).

@prince-chrismc
Copy link
Contributor

I recall a few PRs from @madebr trying to sort this out as well... there's too many issues and PRs I wasnt able to find anything 😖

@madebr
Copy link
Contributor

madebr commented Jan 26, 2022

That function is used here

if not self.options.without_python:
# https://www.boost.org/doc/libs/1_70_0/libs/python/doc/html/building/configuring_boost_build.html
contents += '\nusing python : {version} : "{executable}" : "{includes}" : "{libraries}" ;'\
.format(version=self._python_version,
executable=self._python_executable,
includes=self._python_includes,
libraries=self._python_libraries)

I think that function is misnamed, it should be called _python_library_dirs or something similar.

@ghost ghost mentioned this pull request Jan 26, 2022
4 tasks
@SSE4
Copy link
Contributor

SSE4 commented Jan 28, 2022

reading https://github.com/boostorg/build/blob/ae1b579606d06b8d8900fe65fd63dffb46647588/src/tools/python.jam, it seems like it is indeed a library directory, not a path to the library file. @grafikrobot can you confirm?

@conan-center-bot
Copy link
Collaborator

All green in build 2 (79527885987f60e2ba82f608804556a7de02d0a8):

  • boost/1.77.0@:
    All packages built successfully! (All logs)

  • boost/1.72.0@:
    All packages built successfully! (All logs)

  • boost/1.70.0@:
    All packages built successfully! (All logs)

  • boost/1.69.0@:
    All packages built successfully! (All logs)

  • boost/1.73.0@:
    All packages built successfully! (All logs)

  • boost/1.76.0@:
    All packages built successfully! (All logs)

  • boost/1.75.0@:
    All packages built successfully! (All logs)

  • boost/1.74.0@:
    All packages built successfully! (All logs)

  • boost/1.78.0@:
    All packages built successfully! (All logs)

  • boost/1.71.0@:
    All packages built successfully! (All logs)

Copy link
Contributor

@SSE4 SSE4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's move forward. If I have some time, I'll run some tests with python on different platforms, but no promises.

@conan-center-bot conan-center-bot merged commit 28518a3 into conan-io:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] boost/1.72.0: not compile on Windows with shared and python options.
6 participants