-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support cmake_target_namespace in legacy cmake_find_package, cmake_find_package_multi generators #10005
Support cmake_target_namespace in legacy cmake_find_package, cmake_find_package_multi generators #10005
Conversation
Co-authored-by: James <james@conan.io>
…om:czoido/conan into support_cmake_target_namespace_legacy_gens
{} | ||
""") | ||
|
||
client.save({"hello.py": hello.format('self.cpp_info.set_property("cmake_target_namespace", "hello_namespace")'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also check cmake_target_namespace
property works on component level?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the documentation https://docs.conan.io/en/latest/reference/conanfile/tools/cmake/cmakedeps.html#properties I think it should not work at component level, just at the root cpp_info level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that if you want to change the namespace at component level you should use the alias feature right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for sure, you may use an alias. it's just misleading and confusing for me that some properties work on component level, but some don't.
Changelog: omit
Docs: omit
This was reverted by #10099
Also check: #10098
Related discussion: #10077
Closes: #9946
#TAGS: slow