Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cmake_target_namespace in legacy cmake_find_package, cmake_find_package_multi generators #10005

Merged

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Nov 11, 2021

Changelog: omit
Docs: omit

This was reverted by #10099

Also check: #10098

Related discussion: #10077

Closes: #9946

#TAGS: slow

@czoido czoido added this to the 1.43 milestone Nov 11, 2021
@czoido czoido requested a review from memsharded November 11, 2021 16:09
@czoido czoido changed the title Support cmake_target_namespace legacy cmake_find_package, cmake_find_package_multi generators Support cmake_target_namespace in legacy cmake_find_package, cmake_find_package_multi generators Nov 11, 2021
conans/model/build_info.py Outdated Show resolved Hide resolved
conans/client/generators/cmake_find_package.py Outdated Show resolved Hide resolved
czoido and others added 3 commits November 11, 2021 19:40
Co-authored-by: James <james@conan.io>
…om:czoido/conan into support_cmake_target_namespace_legacy_gens
{}
""")

client.save({"hello.py": hello.format('self.cpp_info.set_property("cmake_target_namespace", "hello_namespace")'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also check cmake_target_namespace property works on component level?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the documentation https://docs.conan.io/en/latest/reference/conanfile/tools/cmake/cmakedeps.html#properties I think it should not work at component level, just at the root cpp_info level.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that if you want to change the namespace at component level you should use the alias feature right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for sure, you may use an alias. it's just misleading and confusing for me that some properties work on component level, but some don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[question] cmake_target_namespace support in cmake_find_package(_multi) generators?
5 participants