Deprecated names, filenames and build_modules
#369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franramirez688
force-pushed
the
feature/hook_conan_cmake_names
branch
from
82c0a2e to
3c130d0
Compare
franramirez688
force-pushed
the
feature/hook_conan_cmake_names
branch
from
4ecdef0 to
663ca00
Compare
|
I think this PR is blocked till the new Conan 1.43 will be published due to the need to have this change available conan-io/conan#10005 |
|
Running a tentative hook check with the changes proposed on this PR led to the following refenreces failing: |
jgsogo
suggested changes
Dec 30, 2021
There was a problem hiding this comment.
ATM we cannot forbid these parameters, as they are needed for the stable generators to work properly.
We can print a warning and recommend the contributor to add set_property, but we cannot remove these ones until we deprecate cmake_find_package[_multi] generators (only after deprecating Conan v1).
|
This PR does not make sense for now. Closing it 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
conanfile.pyrecipe is using any of the legacy propertiesnames,filenamesand/orbuild_modules, this hook will show an error. It will help to avoid problems with the newconan.toolsgenerators likeCMakeDeps,PkgConfigDeps, etc.Issue related: conan-io/conan#9943
Docs: https://github.com/conan-io/conan-center-index/pull/XXXX