-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added concep list Needham-1897-263 #1419
Conversation
@alzkuc could you to moderate? Thank you. |
hi @LinguList! would you please review this PR? :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, a couple of things that must be modifiied please:
- Can you please reinsert the Lexibank_Gloss? We need it, as it links the concept list to your data.
- Also: we need an explanation for ditto-cases, the asterisk.
- Also: you are not giving us the literal form: you write
Bury, v
but it should beBury, v.
. This is indeed very important for Concepticon to stick to the true value we find in the source. (Chillic has quotes, etc.)
If we have these covered, I make a thorough review afterwards.
On the dittos, do you mean that there needs to be an explanation on how we changed "do." to the concept being dittoed? Should this then go into a comment column? I have corrected For I had understood that we were adding Neeham'd concept list first. Then my corrections of his from van Dam & Mossang 2025 as a second, which in turn (the latter) would be submitted to Lexibank as the language data. That way the historical data would still be correctly linked to it's meaning. |
There are two things to be considered here, but what is really important
is that we avoid making things more complicated.
Can you please provide me with a list of cases where you think that a
concept A was elicited, but a word meaning b was returned? Here, please?
The number of cases is important. I decide how to proceed from there.
|
I will close this PR now and move to this one where I typed off the data another time to have a version that is also linked to the data that would be added to Lexibank. This also addresses the discussion we had here. |
Pull request checklist
concepticon notlinked --gloss "NEW_GLOSS"
Additional information
Concepts from Needham 1897 mapped to Concepticon concepts based on the author's intended targets.