Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added concep list Needham-1897-263 #1419

Closed
wants to merge 5 commits into from

Conversation

patkaiist
Copy link
Collaborator

Pull request checklist

  • add new concept list
  • add new metadata
  • add new Concepticon concept sets
    • checked whether the new concept(s) can be applied to existing lists with
      concepticon notlinked --gloss "NEW_GLOSS"
  • add new Concepticon concept relations
  • refine existing Concepticon concept set mappings
  • refine Concepticon glosses
  • refine Concepticon concept relations
  • refine Concepticon concept definitions
  • retire data

Additional information

Concepts from Needham 1897 mapped to Concepticon concepts based on the author's intended targets.

@patkaiist
Copy link
Collaborator Author

@alzkuc could you to moderate? Thank you.

@alzkuc
Copy link
Collaborator

alzkuc commented Nov 8, 2024

hi @LinguList! would you please review this PR? :-)

@alzkuc alzkuc requested a review from LinguList November 8, 2024 09:18
@alzkuc alzkuc assigned alzkuc and unassigned alzkuc Nov 8, 2024
Copy link
Contributor

@LinguList LinguList left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a couple of things that must be modifiied please:

  • Can you please reinsert the Lexibank_Gloss? We need it, as it links the concept list to your data.
  • Also: we need an explanation for ditto-cases, the asterisk.
  • Also: you are not giving us the literal form: you write Bury, v but it should be Bury, v.. This is indeed very important for Concepticon to stick to the true value we find in the source. (Chillic has quotes, etc.)

If we have these covered, I make a thorough review afterwards.

@patkaiist
Copy link
Collaborator Author

patkaiist commented Nov 8, 2024

On the dittos, do you mean that there needs to be an explanation on how we changed "do." to the concept being dittoed? Should this then go into a comment column?

I have corrected Bury, v to Bury, v. and Chillic with quotes, and the rest. All punctuation is as in the original, including the (mis)spelling of "leech" as "leach".

For Lexibank_Gloss, I removed it since this is Needham's attempted concepts, not the ones the speakers actually returned. The concepticon mappings here are what Needham intended. I had planned to submit my corrected version of his data as a modification of the original, as the Swadesh modifications currently exist in Concepticon. For that, the Concepticon mappings will be different, since they will match the actual concepts given. That is what I expected the Lexebank data to mater for. That's what I was trying to clarify on Mattermost yesterday.

I had understood that we were adding Neeham'd concept list first. Then my corrections of his from van Dam & Mossang 2025 as a second, which in turn (the latter) would be submitted to Lexibank as the language data. That way the historical data would still be correctly linked to it's meaning.

@LinguList
Copy link
Contributor

LinguList commented Nov 8, 2024 via email

@LinguList
Copy link
Contributor

I will close this PR now and move to this one where I typed off the data another time to have a version that is also linked to the data that would be added to Lexibank. This also addresses the discussion we had here.

@LinguList LinguList closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants