-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding needham #1420
adding needham #1420
Conversation
@LinguList Thank you, I have gone through this in more detail now. I want to clarify the process slightly. Let me know if this is correct:
In this case the only thing I need to do is add a couple more glosses. Petticoat is actually simply If the numbered points above are correct, then I will do that, and afterward we can finalise the PR. |
@patkaiist, so if I understand properly you'd say that Needham writes down he asked for "petticoat" but he received the word for "skirt" and you deduce this from the modern fieldwork? |
If this is the case, let us handle it in the following way:
|
I think in this way, we are true to the source, true to the interpretation, and open for including this in Lexibank with the more recent data. |
@patkaiist, where are we on this? Didn't you want to finalize something here, or is it okay now and we can merge? |
I think it may be fine to merge. I wanted to check on the tones in the orthography profile but I looked earlier today and everything is accounted for. |
Okay, then if you could please resolve conflicts, and merge yourself? I'd then check next week the lexibank integration, so this is good for your publication! |
Just resovled the conflicts on my side. |
Pull request checklist
concepticon notlinked --gloss "NEW_GLOSS"
Additional information
@patkaiist, please check my PR here, where I add Needham in a version compatible with Lexibank, solving your problem. We must review the mappings now, but that is what I meant.