Merge Hotfix 2.12.2 #1329
Merged
Merge Hotfix 2.12.2 #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PT-187796954] Previously only site admins and managers could toggle the hide names control in the learner reports. This expands this ability for project admins of any project to also toggle this control. The original reason that only site admins and managers had access is the user could use the learner report page to select teachers or resources both in and out of a project they admined so there was not enough fine grained control. It was decided to open this toggle up to any project admin as those roles have blanket coverage in the IRBs.
This fixes two issues: 1. Updates pre-loading to add project pre-loading of teacher and student cohorts and removes unneeded pre-loading of teacher_clazzes: [:clazz] based on an eager loading errors that Rails was outputting. 2. Limits the result set to 10 from the default of 30. There are no more eager loading errors and I've verified that the query is limited to 10 results. The only real way to tell if this fixes production, given its large number of users, is to try it there after validating the changes on staging.
…min-can-see-hide-names fix: Allow project admins of any project to toggle hide names control [PT-187796954]
…ser-admin-page-load fix: Slow load on user admin page [PT-187797154]
With the update to React 18 the Formsy input validations broke as they relied on state updates being done before the validations. This commit changes the password confirmation validation to use a function that compares the passed form values. It also updates the the password length validations to remove the max length validation.
…rds-do-not-match fix: Passwords validations in signup form [PT-187798321] [PT-187798313]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.