mark initial win+cuda builds for faiss as broken #235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines for marking packages as broken:
instead of marking packages as broken. This alternative workflow makes environments more reproducible.
not technically broken and should not be marked as such.
but should be patched in the repo data and be marked unbroken later.
the maintainers only, we can allow packages to be marked broken more liberally.
conda-forge/core
) try to make a decision on these requests within 24 hours.Checklist:
broken/*
for adding thebroken
label,not_broken/*
for removing thebroken
label)After a long journey with conda-forge/faiss-split-feedstock#19, things built fine, the CI ran through and the PR got merged. Once I tried the package locally, I found out that the GPU-specific test suite has some failures and segfaults.
Since these packages are only a few hours old and fundamentally broken for what they claim to do, I propose to mark them as broken.
PS. I should have tested this from the artefacts of the PR, sorry for the bother.
CC @beckermr @isuruf