Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark initial win+cuda builds for faiss as broken #235

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

h-vetinari
Copy link
Member

Guidelines for marking packages as broken:

  • We prefer to patch the repo data (see here)
    instead of marking packages as broken. This alternative workflow makes environments more reproducible.
  • Packages with requirements/metadata that are too strict but otherwise work are
    not technically broken and should not be marked as such.
  • Packages with missing metadata can be marked as broken on a temporary basis
    but should be patched in the repo data and be marked unbroken later.
  • In some cases where the number of users of a package is small or it is used by
    the maintainers only, we can allow packages to be marked broken more liberally.
  • We (conda-forge/core) try to make a decision on these requests within 24 hours.

Checklist:

  • Make sure your package is in the right spot (broken/* for adding the
    broken label, not_broken/* for removing the broken label)
  • Added a description of the problem with the package in the PR description.
  • Added links to any relevant issues/PRs in the PR description.
  • Pinged the team for the package for their input.

After a long journey with conda-forge/faiss-split-feedstock#19, things built fine, the CI ran through and the PR got merged. Once I tried the package locally, I found out that the GPU-specific test suite has some failures and segfaults.

Since these packages are only a few hours old and fundamentally broken for what they claim to do, I propose to mark them as broken.

PS. I should have tested this from the artefacts of the PR, sorry for the bother.

CC @beckermr @isuruf

@h-vetinari h-vetinari requested a review from a team as a code owner February 18, 2021 11:05
@h-vetinari
Copy link
Member Author

One build took a bunch longer, seems the last packages haven't made it through the CDN yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants