Release 2021.11.0 with grayskull #28

charlesbluca · 2021-11-10T19:47:48Z

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

Closes #29

Main change we need here is the Dask pinning in the first commit, the rest is optional suggestions made when generating the recipe with grayskull.

cc @quasiben

conda-forge-linter · 2021-11-10T19:47:54Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

requirements: run: dask==2021.10.0 must contain a space between the name and the pin, i.e. dask ==2021.10.0

jakirkham · 2021-11-10T19:59:21Z

recipe/meta.yaml

  number: 0
-  script: {{ PYTHON }} -m pip install . --no-deps -vv
+  skip: true   # [py2k]


This seems to be added because of the selector below. So makes sense

jakirkham · 2021-11-10T20:01:46Z

Would suggest taking the dependencies before and after and sorting them. Then doing a diff on those. That should help clarify what has actually changed. Also raised issue ( conda/grayskull#259 ) on keeping these in the original order

conda-forge-linter · 2021-11-10T20:08:06Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

charlesbluca · 2021-11-10T20:09:05Z

Resorted the dependencies here to match the original ordering to simplify the diff

jakirkham · 2021-11-10T20:11:49Z

recipe/meta.yaml

-    - python >=3.6
-    - setuptools_scm
+    - python
+    - setuptools-scm


This should be fine. We provide both - & _

jakirkham

Thanks Charles! 😄

Raised a few issues based on trying things here. Made a few observations above. Some are actionable. Though some are not.

jakirkham · 2021-11-10T20:12:27Z

recipe/meta.yaml

    - pandas >=1.0.0
    - jpype1 >=1.0.2
-    - openjdk >=8


Obviously we want to keep this. Raised issue ( conda/grayskull#261 )

Do we also want to keep the maven build requirement?

Sorry missed that. Agree we want to keep that. Commented above

jakirkham · 2021-11-10T20:14:10Z

recipe/meta.yaml

-    - prompt_toolkit >=3.0.8
-    - pygments >=2.7.3
-    - nest-asyncio >=1.0.0
-    - tabulate >=0.8.9
+    - prompt-toolkit
+    - pygments
+    - nest-asyncio
+    - tabulate


While it may seem surprising that these constraints were dropped, that did happen in the setup.py. So this is expected behavior (at least from Grayskull). Whether they should or shouldn't be there upstream is another question

Good point - I notice that those packages are constrained by the CI environment so I can open an issue to keep track of making those consistent for the next release

jakirkham · 2021-11-10T20:15:00Z

recipe/meta.yaml

+    - pygments
+    - nest-asyncio
+    - tabulate
+    - importlib-metadata  # [py<38]


This is picked up from upstream and expected. This is also why the package can no longer be noarch

jakirkham · 2021-11-10T20:19:08Z

recipe/meta.yaml


 test:
  imports:
    - dask_sql
+    - dask_sql.input_utils


Not sure why this is here. We can drop this. Raised issue ( conda/grayskull#262 )

jakirkham · 2021-11-10T20:19:27Z

recipe/meta.yaml

+    - dask-sql-server --help
+    - dask-sql --help


These seem like a good idea to check :)

jakirkham · 2021-11-10T20:19:40Z

recipe/meta.yaml

  requires:
    - pip

 about:
-  home: http://github.com/nils-braun/dask-sql/
-  summary: SQL Query Layer for dask
+  home: http://github.com/dask-contrib/dask-sql/


Glad it caught this 😄

It actually didn't catch this one 🙁 this was one of the few things I changed manually

Interesting if I run this locally, Grayskull seems to get this right. It should just be grabbing it from here. Could you please recheck?

Ah yeah my bad, I'm thinking of the change I made to the summary - this was caught by grayskull 🎉

Ah ok. In that case we might want to update this line

jakirkham · 2021-11-10T20:21:59Z

We should also re-render now that the package is not noarch

jakirkham · 2021-11-10T20:26:32Z

Adding to arch migrations ( conda-forge/conda-forge-pinning-feedstock#2160 ) since this will be not be noarch any more. This should help us provide packages on other architectures (like ARM)

jakirkham · 2021-11-10T20:31:36Z

recipe/meta.yaml

-  build:
-    - maven >=3.6.0


Yes please keep this too

jakirkham · 2021-11-10T21:00:55Z

Windows Python 3.9 failures appear to be due to missing jpype1 packages. PR ( conda-forge/jpype1-feedstock#40 ) should resolve that.

quasiben

Thanks for the comments @jakirkham and the work here along with grayskull @charlesbluca :)

charlesbluca · 2021-11-11T00:35:18Z

@conda-forge-admin, please restart CI

github-actions · 2021-11-11T00:51:46Z

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

linter: passed
azure: passed

Thus the PR was passing and merged! Have a great day!

jakirkham · 2021-11-11T01:30:54Z

Rerunning CI now that jpype1 has been built, uploaded, and mirrored

jakirkham · 2021-11-11T01:35:16Z

Noticed a clobber warning in the log. Mentioned here ( conda-forge/openjdk-feedstock#59 (comment) )

jakirkham · 2021-11-11T03:21:03Z

Looks like packages are up and available from the CDN 🙂

charlesbluca added 5 commits November 10, 2021 11:43

Update version + dask pinning

35f5a3b

Update about section

61bfc73

Update build section with grayskull

45456ea

Update test section with grayskull

7a0d7f5

Update requirements with grayskull

a5d4af1

charlesbluca requested review from nils-braun and quasiben as code owners November 10, 2021 19:47

jakirkham mentioned this pull request Nov 10, 2021

[BUG] Requirement listing extras misses space conda/grayskull#260

Closed

jakirkham reviewed Nov 10, 2021

View reviewed changes

Resort grayskull requirements

87aea1a

jakirkham mentioned this pull request Nov 10, 2021

Handling non-Python dependencies conda/grayskull#261

Open

jakirkham reviewed Nov 10, 2021

View reviewed changes

jakirkham mentioned this pull request Nov 10, 2021

[BUG] Random modules/packages in test/imports conda/grayskull#262

Closed

jakirkham reviewed Nov 10, 2021

View reviewed changes

Rerender feedstock

75216c9

jakirkham reviewed Nov 10, 2021

View reviewed changes

Add necessary Java deps, remove unnecessary import test

3bbd321

jakirkham approved these changes Nov 10, 2021

View reviewed changes

quasiben reviewed Nov 10, 2021

View reviewed changes

quasiben approved these changes Nov 10, 2021

View reviewed changes

jakirkham added the automerge Merge the PR when CI passes label Nov 10, 2021

conda-forge-linter closed this Nov 11, 2021

conda-forge-linter reopened this Nov 11, 2021

github-actions bot merged commit 305f80d into conda-forge:master Nov 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 2021.11.0 with grayskull #28

Release 2021.11.0 with grayskull #28

charlesbluca commented Nov 10, 2021 •

edited by jakirkham

Loading

conda-forge-linter commented Nov 10, 2021

jakirkham Nov 10, 2021

jakirkham commented Nov 10, 2021

conda-forge-linter commented Nov 10, 2021

charlesbluca commented Nov 10, 2021

jakirkham Nov 10, 2021

jakirkham left a comment

jakirkham Nov 10, 2021

charlesbluca Nov 10, 2021

jakirkham Nov 10, 2021

jakirkham Nov 10, 2021

charlesbluca Nov 10, 2021

jakirkham Nov 10, 2021

jakirkham Nov 10, 2021

jakirkham Nov 10, 2021

jakirkham Nov 10, 2021

charlesbluca Nov 10, 2021 •

edited

Loading

jakirkham Nov 10, 2021

charlesbluca Nov 10, 2021

jakirkham Nov 10, 2021

jakirkham commented Nov 10, 2021

jakirkham commented Nov 10, 2021

jakirkham Nov 10, 2021

jakirkham commented Nov 10, 2021

quasiben left a comment

charlesbluca commented Nov 11, 2021

github-actions bot commented Nov 11, 2021 •

edited

Loading

jakirkham commented Nov 11, 2021

jakirkham commented Nov 11, 2021

jakirkham commented Nov 11, 2021 •

edited

Loading

Release 2021.11.0 with grayskull #28

Release 2021.11.0 with grayskull #28

Conversation

charlesbluca commented Nov 10, 2021 • edited by jakirkham Loading

conda-forge-linter commented Nov 10, 2021

Choose a reason for hiding this comment

jakirkham commented Nov 10, 2021

conda-forge-linter commented Nov 10, 2021

charlesbluca commented Nov 10, 2021

Choose a reason for hiding this comment

jakirkham left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

charlesbluca Nov 10, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakirkham commented Nov 10, 2021

jakirkham commented Nov 10, 2021

Choose a reason for hiding this comment

jakirkham commented Nov 10, 2021

quasiben left a comment

Choose a reason for hiding this comment

charlesbluca commented Nov 11, 2021

github-actions bot commented Nov 11, 2021 • edited Loading

jakirkham commented Nov 11, 2021

jakirkham commented Nov 11, 2021

jakirkham commented Nov 11, 2021 • edited Loading

charlesbluca commented Nov 10, 2021 •

edited by jakirkham

Loading

charlesbluca Nov 10, 2021 •

edited

Loading

github-actions bot commented Nov 11, 2021 •

edited

Loading

jakirkham commented Nov 11, 2021 •

edited

Loading