Drop skip (needed for Windows Python 3.9+ packages) #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-forge-linter
requested review from
caspervdw,
mariusvniekerk and
marscher
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2021.11.10.20.45.22
Python 2 has long since been dropped. Also we already appear to build from source on Windows. So the constraints that limited Windows packaging before (likely repackaging binaries) no longer affect us. So go ahead and drop the skip to simplify maintenance and pick up missing packages (like for newer Windows + Python versions).
|
@conda-forge-admin, please re-render |
…nda-forge-pinning 2021.11.10.20.45.22
jakirkham
changed the title
5 tasks
jakirkham
reviewed
Nov 10, 2021
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
* Changelog additions * Azure CI configuration bits
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the
skipto build Windows packages for Python 3.9+. Also added an upstream patch to resolve Python 3.10 Windows build issues. This is needed for the Python 3.10 migration where Windows packages are missed. Plus for packages that need this on Python 3.9.Hi! This is the friendly automated conda-forge-webservice.
I've rerendered the recipe as instructed in #39.
Here's a checklist to do before merging.
Fixes #39
Follow-up to PR ( #38 )