Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add macos to build #9

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

feat: Add macos to build #9

wants to merge 11 commits into from

Commits on Aug 14, 2024

  1. Remove setuptools_scm as no longer using build

    @matthewfeickert
    matthewfeickert committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    769a0c8 View commit details
    Browse the repository at this point in the history

  2. feat: Add macos to build by skipping windows 

    * Bump build number.
    @matthewfeickert
    matthewfeickert committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    121f637 View commit details
    Browse the repository at this point in the history

  3. feat: Add patch to remove renaming of libtool on macos 

    * Using conda-forge this isn't necessary and kills the build.
    @matthewfeickert
    matthewfeickert committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    2ecf8af View commit details
    Browse the repository at this point in the history

  4. feat: Add patch to remove gmake calls 

    * gmake is still not available for unix builds of make?
    @matthewfeickert
    matthewfeickert committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    83f69f7 View commit details
    Browse the repository at this point in the history

  5. try to patch in loader_path to _rpath like ORIGIN

    @matthewfeickert
    matthewfeickert committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    3041579 View commit details
    Browse the repository at this point in the history

  6. try dropping the '$' in front of '@loader_path'

    @matthewfeickert
    matthewfeickert committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    36cae5e View commit details
    Browse the repository at this point in the history

  7. Make the dynamic link variable in runtime_library_dirs os dependent

    @matthewfeickert
    matthewfeickert committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    1529171 View commit details
    Browse the repository at this point in the history

  8. Drop '$' in front of '@loader_path' in the actuall formatting so it s… 

    …tays
    @matthewfeickert
    matthewfeickert committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    08d6329 View commit details
    Browse the repository at this point in the history

  9. Add pybind11-abi given recommendations 

    * c.f. https://conda-forge.org/docs/maintainer/knowledge_base/#pybind11-abi-constraints
    @matthewfeickert
    matthewfeickert committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    a8e41ac View commit details
    Browse the repository at this point in the history

  10. take a quick guess at macos dynamic link args and debug this later on… 

    … M2 machine
    @matthewfeickert
    matthewfeickert committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    600cbf0 View commit details
    Browse the repository at this point in the history

  11. MNT: Re-rendered with conda-build 24.7.1, conda-smithy 3.38.0, and co… 

    …nda-forge-pinning 2024.08.13.15.51.23
    conda-forge-webservices[bot] committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    6cf4fbd View commit details
    Browse the repository at this point in the history